Bug 1045972

Summary:	Modidying configure text file for gear shell message is invalid
Product:	OpenShift Container Platform	Reporter:	Nan Wei <nwei>
Component:	Containers	Assignee:	Brenton Leanhardt <bleanhar>
Status:	CLOSED ERRATA	QA Contact:	libra bugs <libra-bugs>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	2.0.0	CC:	adellape, jolamb, libra-onpremise-devel, pruan, xtian
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	rubygem-openshift-origin-node-1.17.5.9-1.el6op	Doc Type:	Bug Fix
Doc Text:	The MOTD_FILE setting in the /etc/openshift/node.conf file on the node host contained an extraneous white space at the beginning of the quoted string. If this setting was used as provided, the MOTD file was not read correctly. This bug fix removes the leading white space in the quoted string, and the supplied example MOTD_CONF setting now works correctly.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-02-25 15:42:47 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Nan Wei 2013-12-23 04:59:31 UTC

Description of problem:
When modify configure text file for gear shell message, gear shell message is invalid yet. But I do it successfully in devenv. It shows some messages as follow: "Messages from Welcome file" in devenv.
Version-Release number of selected component (if applicable):
OpenShift Enterprise 2.0.1 puddle: 2.0.z/2013-12-16.2
How reproducible:
always
Steps to Reproduce:
1. SSH into a instance and add following line into /etc/openshift/node.conf file
MOTD_FILE="/etc/openshift/welcome.rhcsh"
2. Create file with test strings
cat /etc/openshift/welcome.rhcsh
Messages from Welcome file.
3. Restart "mcollective" service
service ruby193-mcollective restart
4. Create an app
rhc app create cdiy diy-0.1 --no-git
5. SSH login to this app and check the shell messages
rhc ssh cdiy
Actual results:
Prompt messages don't exist some message like this: "Messages from Welcome file"
Expected results:
There should exist some messages like below: "Messages from Welcome file"
Additional info:

Comment 2 Brenton Leanhardt 2014-02-03 17:38:27 UTC

Upstream commit:

commit 9090141580402a599571bc7c67638b70099d2d47
Author: Brenton Leanhardt <bleanhar>
Date:   Mon Feb 3 12:32:58 2014 -0500

    Bug 1045972 - Removing whitespace on default MOTD_FILE value

Comment 7 Nan Wei 2014-02-07 05:23:03 UTC

openshift enterprise puddle: 2014-02-06.1

Actual results:
Prompt messages don't exist some message like this: "Messages from Welcome file" yet. 

I have checked "https://github.com/openshift/enterprise-server/pull/219/files" and checked Files changed, whitespace on default exists. If remove whitespace on default, Modidying configure text file for gear shell message is valid. I will wait for next merge. Sorry.

Comment 8 Nan Wei 2014-02-07 07:42:20 UTC

because my ose env is updated before, so generate new file: /etc/openshift/node.conf.rpmnew. I will verify it as follow.

openshift enterprise puddle: 2014-02-06.1

1. make sure to add following line into /etc/openshift/node.conf file
MOTD_FILE="/etc/openshift/welcome.rhcsh"
2. Create file with test strings and add Modidying configure content.
cat /etc/openshift/welcome.rhcsh
Messages from Welcome file.
3. Restart "mcollective" service
4. Create an app
5. SSH login to this app and check the shell messages

Actual results:
There exists modidying configure text file for gear shell message.

Comment 10 errata-xmlrpc 2014-02-25 15:42:47 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2014-0209.html