Bug 1046132
| Summary: | rhsm-icon pops up at annoying times | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 6 | Reporter: | J.C. Molet <jmolet> |
| Component: | subscription-manager | Assignee: | vritant <vrjain> |
| Status: | CLOSED ERRATA | QA Contact: | Shwetha Kallesh <skallesh> |
| Severity: | high | Docs Contact: | |
| Priority: | high | ||
| Version: | 6.6 | CC: | alikins, awood, bcourt, bkearney, csnyder, dgoodwin, qianzhan, skallesh, vrjain, wpoteat |
| Target Milestone: | rc | Keywords: | Triaged |
| Target Release: | 6.7 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-05-10 20:35:32 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1209535 | ||
|
Description
J.C. Molet
2013-12-23 19:20:22 UTC
I suspect not only is the icon not checking if the gui is running, but starting the gui is triggering the icon to pop up. Not sure what the best way to prevent that is. dbus-fu of some sort I suppose... Moving bugs from 7.0 to 7.1 as of commit: eaae6e0fae36dece8c985fe6904e560a882289c6 Rhsm-icon now tracks the time and content of the last displayed status. The icon will no longer pop up with the same message repeatedly with in the length of time set by the -c option (defaults to one day). However, the icon will still display with the gui on screen. This has the effect of making the icon less annoying but still useful. As such I believe this to be a solution to this bug. Acking 7.1 Upon further review (and outside complaints) this once every 24 hour solution isn't sufficient, as people are now saying the icon never pops up. I suggest we revert this change in master and talk with project managers/UI people/customers what behavior they actually want - which I would imagine lies somewhere between popping up for every single event and once a day. A hard wait doesn't seem to be sufficient and the solution probably needs some higher level of logic when to appear. Please revert the commit in comment 4 until we have a better solution. I have reverted the change and submitted a PR. Deferring to 6.7. Something definitely needs to be done. Adding devel ack. When testing with RHEL-6.7-20150401.0 and SAM-1.4.1-RHEL-6-20141113.0, I met this issue: [root@dhcp-128-51 ~]# subscription-manager version server type: Red Hat Subscription Management subscription management server: 1.4.3.28-1.el6sam_splice-Headpin subscription management rules: Unknown subscription-manager: 1.14.1-1.el6 python-rhsm: 1.14.1-1.el6 Steps: 1. Auto-attach and close subscription-manager-gui. 2. Remove all subscriptions in CLI, and the rhsm-icon prompts. 3. When clicking the 'Manage My Subscriptions' button, the gui is opened, but the rhsm-icon prompts again. In my opinion, the solution is to make a change in rhsm_icon.c to detect if the GUI is running via the com.redhat.SubscriptionManagerGUI bus. I think that approach should be feasible. (In reply to Alex Wood from comment #13) > In my opinion, the solution is to make a change in rhsm_icon.c to detect if > the GUI is running via the com.redhat.SubscriptionManagerGUI bus. I think > that approach should be feasible. rhsm_icon.c is run by a process ( rhsmd ) owned by a non-root user, while Subscription Manager GUI, at least as of today, is run by root. this makes that approach in-feasible The proposed fix does NOT meet the requirement of never displaying the pop up icon when subscription manager GUI is already running - that is not trivially feasible and is probably a WONTFIX. However, the fix ensures that RHSM icon will pop up only when there is a change in status, and only once for every status change, for example upon registration, un-registration, etc. Prior to this fix, there was a pop up every time the GUI was started, so from that perspective RHSM Icon behavior should be far less annoying now. Marking verified as rhsm-icon pops up only when there is a change in status when GUI is open and only once and last for about half a minute or probably less than that. [root@hp-dl320egen8-01 ~]# subscription-manager version server type: Red Hat Subscription Management subscription management server: 0.9.51.14-1 subscription management rules: 5.15.1 subscription-manager: 1.16.8-1.el6 python-rhsm: 1.16.6-1.el6 Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHBA-2016-0797.html |