Bug 1046421

Summary: Add vmpool prestarted vms is possible also even before vms are actually created.
Product: Red Hat Enterprise Virtualization Manager Reporter: Ilanit Stein <istein>
Component: ovirt-engineAssignee: Shmuel Melamud <smelamud>
Status: CLOSED WORKSFORME QA Contact: Ilanit Stein <istein>
Severity: medium Docs Contact:
Priority: medium    
Version: 3.3.0CC: istein, lpeer, michal.skrivanek, ofrenkel, rbalakri, Rhev-m-bugs, yeylon
Target Milestone: ---   
Target Release: 3.6.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: virt
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-09-20 13:25:36 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
engine log none

Description Ilanit Stein 2013-12-25 08:17:05 UTC 
Description of problem:

Shortly after creating a vmpool, before VMs creation is over, it is possible to edit vmpool, and mark VMs, as "prestarted".
As a result, the VMs are not started, with error in in engine.log:
"No Vms avaialable for prestarting"

From engine.log:

2013-12-24 11:35:39,788 INFO  [org.ovirt.engine.core.bll.VmPoolMonitor] (DefaultQuartzScheduler_Worker-7) VmPool 8bdea682-f449-458e-9993-d3d0305a9fc3 is missing 3 prestarted Vms, attempting to prestart 3 Vms

2013-12-24 11:35:39,790 INFO  [org.ovirt.engine.core.bll.VmPoolMonitor] (DefaultQuartzScheduler_Worker-7) No Vms avaialable for prestarting

2013-12-24 11:35:40,059 INFO  [org.ovirt.engine.core.bll.AsyncTaskManager] (DefaultQuartzScheduler_Worker-18) Polling and updating Async Tasks: 3 tasks, 3 tasks to poll now

Version-Release number of selected component (if applicable):
is28.1

How reproducible:
Always
Comment 1 Ilanit Stein 2013-12-25 08:17:48 UTC 
Created attachment 841407 [details]
engine log
Comment 2 Omer Frenkel 2013-12-30 13:23:28 UTC 
but afterwards, when pool is added, the vms are started automatically, right?
if so, i dont think its a bug,
its ok for prestarted job to fail start vms if there aren't any available at some point, as long as it keep trying and succeed when its possible.
Comment 3 Ilanit Stein 2013-12-30 15:05:02 UTC 
when pool is added, the VMs are not started. There is no retry to start the VMs in the pool.
Comment 4 Michal Skrivanek 2014-08-22 13:01:51 UTC 
this bug won't fit into 3.5 release and is being deferred to a later release. If you deeply care about this bug and deserves to be re-evaluated please let me know
Comment 5 Shmuel Melamud 2015-09-20 13:25:36 UTC 
Since introduction of VM_POOL lock in UpdateVmPoolWithVmsCommand and AddVmCommand it's not possible to edit VM pool parameters before completion of all AddVm commands.