Bug 1046679

Summary:	[dwh] upgrade backs up the database only after changing ownership of objects
Product:	Red Hat Enterprise Virtualization Manager	Reporter:	Yedidyah Bar David <didi>
Component:	ovirt-engine-dwh	Assignee:	Yedidyah Bar David <didi>
Status:	CLOSED ERRATA	QA Contact:	Jiri Belka <jbelka>
Severity:	high	Docs Contact:
Priority:	high
Version:	3.3.0	CC:	acathrow, iheim, jbelka, oschreib, pstehlik, Rhev-m-bugs, yeylon, ylavi
Target Milestone:	---	Keywords:	Triaged
Target Release:	3.3.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	integration
Fixed In Version:	IS30 - rhevm-dwh-3.3.0-27.el6ev.src.rpm	Doc Type:	Bug Fix
Doc Text:	Previously, upgrading from 3.2 to 3.3 only backed up the database after changing ownership of all objects. If failure occurred before the ownership was updated, no backup will be created, or the restoration will be performed from a different backup. Now, the backup is performed before any changes are made to the database, and all ownership changes are run in a single psql command.	Story Points:	---
Clone Of:
Clones:	1047117 (view as bug list)		Environment:
Last Closed:	2014-01-21 15:05:45 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1056111

Description Yedidyah Bar David 2013-12-26 14:06:32 UTC

Description of problem:

Upgrade from 3.2 does:
1. create a database user 'engine_history'
2. Update ownership of all objects to this user
3. backup
4. update the schema to 3.3

This means that if we fail during 1 or 2, we have no backup, and if we fail during 4 we restore from a backup that is different from what we started with.

We should backup as soon as possible, then start doing other things.

Comment 2 Jiri Belka 2014-01-16 11:28:23 UTC

ok is32.2.

backup before `rhevm-dwh-setup' and one created by upgrade itself is equal.

# /bin/su -l postgres -c "PGPASSWORD=123456 /usr/bin/pg_dump -C -E UTF8 -w --disable-dollar-quoting --disable-triggers --format=p -Fc ovirt_engine_history" > ovirt_engine_history
# rhevm-dwh-setup
...snip...
# ls -l /root/ovirt_engine_history /var/lib/ovirt-engine/backups/ovirt-engine-history.backup.2014_01_16_12_25_56
-rw-r--r--. 1 root root 750422 Jan 16 12:24 /root/ovirt_engine_history
-rw-r--r--. 1 root root 750422 Jan 16 12:25 /var/lib/ovirt-engine/backups/ovirt-engine-history.backup.2014_01_16_12_25_56

Comment 4 errata-xmlrpc 2014-01-21 15:05:45 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2014-0036.html