Bug 1046807

Taken.

Ken, sorry for taking so long. I'm on a journey abroad and have limited internet access. Will review your gems ASAP once I get a decent connection.

Apart from the warning about the incoherent-version-in-changelog, spec looks good. 

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "Unknown or generated". 8 files have unknown license. Detailed output of
     licensecheck in /home/axil/review/1046807-rubygem-activerecord-nulldb-
     adapter/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
[-]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Ruby:
[x]: Platform dependent files must all go under %{gem_extdir_mri}, platform
     independent under %{gem_dir}.
[x]: Gem package must not define a non-gem subpackage
[x]: Macro %{gem_extdir} is deprecated.
[x]: Gem package is named rubygem-%{gem_name}
[x]: Package contains BuildRequires: rubygems-devel.
[x]: Gem package must define %{gem_name} macro.
[x]: Pure Ruby package must be built as noarch
[x]: Package does not contain Requires: ruby(abi).
[x]: Package contains Requires: ruby(release).

===== SHOULD items =====

Generic:
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[ ]: Package should compile and build into binary rpms on all supported
     architectures.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

Ruby:
[x]: Gem should use %gem_install macro.
[x]: Specfile should use macros from rubygem-devel package.
     Note: The specfile doesn't use these macros: %{gem_spec}, %exclude
     %{gem_cache}
[x]: Gem package should exclude cached Gem.
[x]: Test suite of the library should be run.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: rubygem-activerecord-nulldb-adapter-0.2.3-1.20131226gitffc7dae.fc21.noarch.rpm
          rubygem-activerecord-nulldb-adapter-doc-0.2.3-1.20131226gitffc7dae.fc21.noarch.rpm
          rubygem-activerecord-nulldb-adapter-0.2.3-1.20131226gitffc7dae.fc21.src.rpm
rubygem-activerecord-nulldb-adapter.noarch: W: spelling-error %description -l en_US backend -> backed, back end, back-end
rubygem-activerecord-nulldb-adapter.noarch: W: incoherent-version-in-changelog 0.2.3-1 ['0.2.3-1.20131226gitffc7dae.fc21', '0.2.3-1.20131226gitffc7dae']
rubygem-activerecord-nulldb-adapter.src: W: spelling-error %description -l en_US backend -> backed, back end, back-end
3 packages and 0 specfiles checked; 0 errors, 3 warnings.




Rpmlint (installed packages)
----------------------------
# rpmlint rubygem-activerecord-nulldb-adapter rubygem-activere 
cord-nulldb-adapter-doc
rubygem-activerecord-nulldb-adapter.noarch: W: spelling-error %description -l en_US backend -> backed, back end, back-end
rubygem-activerecord-nulldb-adapter.noarch: W: incoherent-version-in-changelog 0.2.3-1 ['0.2.3-1.20131226gitffc7dae.fc21', '0.2.3-1.20131226gitffc7dae']
2 packages and 0 specfiles checked; 0 errors, 2 warnings.
# echo 'rpmlint-done:'



Requires
--------
rubygem-activerecord-nulldb-adapter (rpmlib, GLIBC filtered):
    ruby(release)
    ruby(rubygems)
    rubygem(activerecord)

rubygem-activerecord-nulldb-adapter-doc (rpmlib, GLIBC filtered):
    rubygem-activerecord-nulldb-adapter



Provides
--------
rubygem-activerecord-nulldb-adapter:
    rubygem(activerecord-nulldb-adapter)
    rubygem-activerecord-nulldb-adapter

rubygem-activerecord-nulldb-adapter-doc:
    rubygem-activerecord-nulldb-adapter-doc



Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1046807
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Ruby, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

Thank you very much for the review! (And I apologize for the delay in responding.)

Upstream has finally released a new version to rubygems.org, so I've updated my package for this new release:
http://fedorapeople.org/cgit/ktdreyer/public_git/rubygem-activerecord-nulldb-adapter.git/commit/?id=ea9e25d117a2193345ab7adb17bc6aac8cdfe02d

That update has removed the rpmlint warning about the version in the changelog.

New Package SCM Request
=======================
Package Name: rubygem-activerecord-nulldb-adapter
Short Description: The Null Object pattern as applied to ActiveRecord database adapters
Owners: ktdreyer
Branches: f20

Git done (by process-git-requests).

Built for Rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=6496628

Closing. Thanks again.