Bug 1046813

Summary:	Review Request: rubygem-cocaine - A small library for doing (command) lines
Product:	[Fedora] Fedora	Reporter:	Ken Dreyer <ktdreyer>
Component:	Package Review	Assignee:	Mamoru TASAKA <mtasaka>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review
Target Milestone:	---	Flags:	mtasaka: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-02-03 09:18:55 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Ken Dreyer 2013-12-27 00:01:32 UTC

Spec URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-cocaine.spec
SRPM URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-cocaine-0.5.3-1.fc21.src.rpm
Description: A small library for doing (command) lines
Fedora Account System Username: ktdreyer

F21 scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6334917

Comment 1 Mamoru TASAKA 2014-01-01 15:54:48 UTC

Taking.

I would appreciate it if you would review my review request (bug 1047655)

Comment 2 Mamoru TASAKA 2014-01-03 15:31:52 UTC

Okay, simple package and clean.
One thing:

* Please write your real name on all history in %changelog

- spec file clean
- builds fine
- rebuilt binary rpm clean
- can be installed
- An example explained in README.md works, and at least the
  following works:

$ ruby -e "require 'cocaine/version' ; puts Cocaine::VERSION"
0.5.3

-------------------------------------------------------------
     This package (rubygem-cocaine) is APPROVED by
     mtasaka
-------------------------------------------------------------

Comment 3 Ken Dreyer 2014-01-04 06:53:53 UTC

Thanks very much mtasaka for the review!

New Package SCM Request
=======================
Package Name: rubygem-cocaine
Short Description: A small library for doing (command) lines
Owners: ktdreyer
Branches: f20

Comment 4 Ken Dreyer 2014-01-04 06:55:24 UTC

(In reply to Mamoru TASAKA from comment #2)
> One thing:
> 
> * Please write your real name on all history in %changelog

Great catch - I will fix before importing.

Comment 5 Gwyn Ciesla 2014-01-06 13:38:23 UTC

Git done (by process-git-requests).

Comment 6 Mamoru TASAKA 2014-02-03 09:18:55 UTC

Closing as this package is already imported.

Comment 7 Ken Dreyer 2014-02-05 01:27:07 UTC

Sorry I missed closing this one, and thanks for taking care of it.