Bug 1046991
Summary: | [abrt] mate-notification-daemon: g_return_if_fail_warning(): mate-notification-daemon killed by SIGTRAP | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Ankur Sinha (FranciscoD) <sanjay.ankur> | ||||||
Component: | hamster-time-tracker | Assignee: | Ankur Sinha (FranciscoD) <sanjay.ankur> | ||||||
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
Severity: | unspecified | Docs Contact: | |||||||
Priority: | unspecified | ||||||||
Version: | 20 | CC: | dan.mashal, fedora, jin, rdieter, rh, sanjay.ankur, stefano | ||||||
Target Milestone: | --- | ||||||||
Target Release: | --- | ||||||||
Hardware: | x86_64 | ||||||||
OS: | Unspecified | ||||||||
URL: | https://retrace.fedoraproject.org/faf/reports/bthash/fa35b025253f2bfc0950fce217320b15f0215e9e | ||||||||
Whiteboard: | abrt_hash:599890361b17bba984aec4f3401b90f3ea98ccd0 | ||||||||
Fixed In Version: | hamster-time-tracker-1.03.3-6.fc19 | Doc Type: | Bug Fix | ||||||
Doc Text: | Story Points: | --- | |||||||
Clone Of: | 1046716 | Environment: | |||||||
Last Closed: | 2013-12-31 19:00:56 UTC | Type: | --- | ||||||
Regression: | --- | Mount Type: | --- | ||||||
Documentation: | --- | CRM: | |||||||
Verified Versions: | Category: | --- | |||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||
Embargoed: | |||||||||
Bug Depends On: | 1046716 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Ankur Sinha (FranciscoD)
2013-12-28 00:33:26 UTC
Working on this now. I've patched the required files and done scratch builds here: f20: http://koji.fedoraproject.org/koji/taskinfo?taskID=6337796 rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=6337798 Can you please confirm if this fixes the issue for you? I don't run MATE and therefore can't test it myself. I don't want to push an update until it receives some sort of testing. Thanks, Warm regards, Ankur Created attachment 842529 [details] Patch for notification fixes. Changelog: * Sat Dec 28 2013 Ankur Sinha <ankursinha AT fedoraproject DOT org> 1.03.3-5 - Add patch for notification fix - https://bugzilla.redhat.com/show_bug.cgi?id=1046991 - https://github.com/projecthamster/hamster/pull/127 - https://github.com/projecthamster/hamster/pull/117 Just tried on f20: Crashes mate-notification-daemon with hamster-time-tracker-1.03.3-4.fc20 from updates-testing Does not crash mate-notification-daemon with hamster-time-tracker-1.03.3-5.fc20 from koji, but also does NOT display any notifications at all. You included code that also enables the transient notifications feature besides fixing this bug, but did not include all relevant changes, see https://github.com/pkerling/hamster/commit/c9fbb4c691d5482c0d678b4a47711b5f32b45640 The self._last_notification initialization in the beginning is missing. Revert the code concerning transient notifications, or include the missing line - imho more desirable as long as the author releases no new hamster version :( Then everything should work fine. Okay, further regressions: Even with including the missing line, the notification is displayed only one time. After that, mate-notification-daemon exits, but the patched hamster version tries to reuse the dbus connection to the daemon (there was a typo in the code before the patch preventing this from happening) and the Notify call fails. The follow_name_owner_changes property should be set on the dbus proxy object to always call the current notification daemon even if it disappears or changes. I've updated the pull request at https://github.com/projecthamster/hamster/pull/127 Created attachment 842883 [details] Updated patch Build with updated patch: F20: http://koji.fedoraproject.org/koji/taskinfo?taskID=6339544 rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=6339575 How do these fare? Thanks for testing these out. Warm regards, Ankur I don't use hamster normaly in mate, so i'm not shure if i use the right test case. I set an notification in hamster for every 3 minutes and it works well with latest build. The patched mate-notification-daemon doesn't crash anymore :) Tested today in my usual scenario, no crashes anymore, notifications were displayed correctly. Thank you! hamster-time-tracker-1.03.3-5.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/FEDORA-2013-23482/hamster-time-tracker-1.03.3-5.fc20 hamster-time-tracker-1.03.3-6.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/hamster-time-tracker-1.03.3-6.fc19 Here's another works for me. Thank you! Package hamster-time-tracker-1.03.3-6.fc20: * should fix your issue, * was pushed to the Fedora 20 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing hamster-time-tracker-1.03.3-6.fc20' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2013-23482/hamster-time-tracker-1.03.3-6.fc20 then log in and leave karma (feedback). hamster-time-tracker-1.03.3-6.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. hamster-time-tracker-1.03.3-6.fc19 has been pushed to the Fedora 19 stable repository. |