Bug 1047601
| Summary: | Review Request: php-phpseclib-crypt-blowfish - Pure-PHP implementation of Blowfish | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Adam Williamson <awilliam> | ||||||
| Component: | Package Review | Assignee: | Remi Collet <fedora> | ||||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | rawhide | CC: | fedora, package-review, shawn | ||||||
| Target Milestone: | --- | Flags: | fedora:
fedora-review+
gwync: fedora-cvs+ |
||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2014-01-14 21:47:46 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | 1047596 | ||||||||
| Bug Blocks: | 1047611 | ||||||||
| Attachments: |
|
||||||||
|
Description
Adam Williamson
2014-01-01 03:13:01 UTC
Quick note about the renaming: the prefered way to alter pear installation is to change do this in %prep and fixing the package.xml, so the file will be installed as wanted. Any change after "pear install" breaks the pear metadata : "pear list-files" will be inconsistent with "rpm -ql". Updated: https://www.happyassassin.net/reviews/php-phpseclib-crypt-blowfish/php-phpseclib-crypt-blowfish.spec https://www.happyassassin.net/reviews/php-phpseclib-crypt-blowfish/php-phpseclib-crypt-blowfish-0.3.5-2.fc21.src.rpm please check if I got the renaming right! Thanks. For now build fails. ERROR: bad md5sum for file /dev/shm/extras/BUILDROOT/php-phpseclib-crypt-blowfish-0.3.5-2.fc19.remi.x86_64/usr/share/pear/Crypt/Blowfish-phpseclib.php sed -i -e 's,Blowfish.php,Blowfish-phpseclib.php,g' package.xml => OK. sed -i -e 's,Blowfish.php,Blowfish-phpseclib.php,g' ...Blowfish.php => KO If you change the content of a file, you need to clear the md5sum in the package.xml else the pear install fails. Also need to be fixed: php-phpseclib-crypt-blowfish.src: W: invalid-url URL: http://phpseclib.sourceforge.net/package/Crypt_Blowfish HTTP Error 404: Not Found Updated: https://www.happyassassin.net/reviews/php-phpseclib-crypt-blowfish/php-phpseclib-crypt-blowfish.spec https://www.happyassassin.net/reviews/php-phpseclib-crypt-blowfish/php-phpseclib- crypt-blowfish-0.3.5-3.fc21.src.rpm Created attachment 848052 [details]
phpci.log
Created attachment 848054 [details]
review.txt
Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30
Command line :/usr/bin/fedora-review -b 1047610
[!]: Requires correct, justified where necessary.
From package.xml, option so package choice
php-mcrypt
From code, used in Crypt_Blowfish::setPawword()
php-pear(phpseclib.sourceforge.net/Crypt_Hash)
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
=> License text is included in the single source header
[x]: Package does not own files or directories owned by other packages.
Ok, but if you add require on Crypt_Hash, you have to drop the ownership of
/usr/share/pear/Crypt
Updated: https://www.happyassassin.net/reviews/php-phpseclib-crypt-blowfish/php-phpseclib-crypt-blowfish.spec https://www.happyassassin.net/reviews/php-phpseclib-crypt-blowfish/php-phpseclib- crypt-blowfish-0.3.5-4.fc21.src.rpm [x]: Requires correct, justified where necessary. [x]: Package does not own files or directories owned by other packages. == APPROVED == New Package SCM Request ======================= Package Name: php-phpseclib-crypt-blowfish Short Description: Pure-PHP implementation of Blowfish Owners: adamwill Branches: f20 el6 InitialCC: Git done (by process-git-requests). Building for Rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=6405986 Package Change Request ====================== Package Name: php-phpseclib-net-ssh2 New Branches: f19 epel7 correction: Package Change Request ====================== Package Name: php-phpseclib-crypt-blowfish New Branches: f19 epel7 No owners specified. Package Change Request ====================== Package Name: php-phpseclib-crypt-blowfish New Branches: f19 epel7 Owners: adamwill Git done (by process-git-requests). |