Bug 1047788 (Naftawayh)

Koji Task: http://koji.fedoraproject.org/koji/taskinfo?taskID=6347785

- Fix license line.
- Fix %%prep section.

=====================================

Spec URL: http://ojuba.org/oji/SPECS/python-naftawayh.spec
SRPM URL: http://ojuba.org/oji/SRPMS/python-naftawayh-0.2-2.fc20.src.rpm

I’ll take a look.

Sorry, I think someone else should do the review.  There doesn’t seem to be any English documentation whatsoever, so as I don’t know Arabic, I can’t really check if the package is working.

I can give you some hints though:

It would be good if you could ask upstream to provide at least some rough documentation in English (a README file maybe), and also to include the license in a COPYING file (currently the only way to find out the license is the tag in the setup.py file, which isn’t optimal. I don’t know if it states the license on the website because it’s Arabic only).

You can skip the Group:-tag in the spec file.

Otherwise the package looks okay.

Review:

+ package built fine in mock rawhide(x86_64)

+ rpmlint on generated rpms gave output
python-naftawayh.noarch: I: enchant-dictionary-not-found ar
python-naftawayh.noarch: W: spelling-error %description -l en_US stopwords -> stop words, stop-words, Stoppard
python-naftawayh.noarch: W: no-documentation
python-naftawayh.src: W: spelling-error %description -l en_US stopwords -> stop words, stop-words, Stoppard
2 packages and 0 specfiles checked; 0 errors, 3 warnings.


+ Source verified with upstream as (sha256sum)
srpm tarball: 862c8e2ddcd09bfd55f9218e31998a759afc507b4f26549a835809a8eb3893bb
upstream tarball : 862c8e2ddcd09bfd55f9218e31998a759afc507b4f26549a835809a8eb3893bb

+ License is just "GPL+" as per PKG-INFO  

suggestions:

1) Email to upstream author and get clarification on what is the license for this python module. When you get reply you can include that reply as a LICENSE file as Source1: in spec and add it to %doc

2) I failed to understand the meaning of following line
#Site of files just for including:

instead of this you can include like "Remove the python shebang"

3) you need to follow https://fedoraproject.org/wiki/Packaging:Python guidelines

Add in %prep after setup macro line
rm -rf *.egg-info

this is to make sure you will not install directly egg info file that upstream if providing and instead you are installing egg info that gets created in %build section

4) As per python guidelines your %install section should use
%{__python2} setup.py install --skip-build --root=%{buildroot}


5) your %files section should look like this
%files -n python-%{module_name}
%doc PKG-INFO
%{python2_sitelib}/%{modname}/
%{python2_sitelib}/%{distname}-%{version}-py2.*.egg-info


6) License tag can be just "GPL+" as there is no mention of any GPL version information but good to ask upstream. 

7) Group tag is optional so you can remove it for fedora releases.

Done:

Spec: http://ojuba.org/test/python-naftawayh.spec
Srpm: http://ojuba.org/test/python-naftawayh-0.2-3.oj35.src.rpm

1) fix the rpmlint messages
python-naftawayh.noarch: I: enchant-dictionary-not-found ar
python-naftawayh.noarch: W: spelling-error %description -l en_US stopwords -> stop words, stop-words, Stoppard
python-naftawayh.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python-naftawayh/PKG-INFO
python-naftawayh.src: W: spelling-error %description -l en_US stopwords -> stop words, stop-words, Stoppard
python-naftawayh.src:13: W: mixed-use-of-spaces-and-tabs (spaces: line 13, tab: line 4)
2 packages and 0 specfiles checked; 0 errors, 4 warnings.

=> fix the wrong-file-end-of-line-encoding and mixed-use-of-spaces-and-tabs warnings.

2) When you add license text as GPLv1 and use tag GPL+ then its contradiction. Because GPL+ mean technically licensed under *any* version of the GPL.

If upstream is saying its GPLv1 then ask upstream to add it in upstream code and release new version or as I said either keep license as "GPL+" and drop Source1 or if upstream can clarify it as a GPLv1 then attach its email reply or any other static reference on the internet (say like you got a reply on upstream project website) that you can include in spec file.

I called him not by email, and he mean GPLv1.
All Fixed:

Spec: http://ojuba.org/test/python-naftawayh.spec
Srpm: http://ojuba.org/test/python-naftawayh-0.2-4.oj35.src.rpm

just a single rpmlint warning remains
python-naftawayh.src:13: W: mixed-use-of-spaces-and-tabs (spaces: line 13, tab: line 4)

you can fix this when you import this package.

APPROVED.

Ok, Thank You.

New Package SCM Request
=======================
Package Name: python-naftawayh
Short Description: Arabic word tagger
Owners: moceap
Branches: f19 f20 f21 epel7

Git done (by process-git-requests).

python-naftawayh-0.2-4.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/python-naftawayh-0.2-4.el7

python-naftawayh-0.2-4.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/python-naftawayh-0.2-4.fc19

python-naftawayh-0.2-4.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/python-naftawayh-0.2-4.fc20

python-naftawayh-0.2-4.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/python-naftawayh-0.2-4.fc21

python-naftawayh-0.2-4.el7 has been pushed to the Fedora EPEL 7 testing repository.

python-naftawayh-0.2-4.fc19 has been pushed to the Fedora 19 stable repository.

python-naftawayh-0.2-4.fc20 has been pushed to the Fedora 20 stable repository.

python-naftawayh-0.2-4.fc21 has been pushed to the Fedora 21 stable repository.

python-naftawayh-0.2-4.el7 has been pushed to the Fedora EPEL 7 stable repository.