Bug 1047851

Summary: Review Request: netty4 - An asynchronous event-driven network application framework and tools for Java
Product: [Fedora] Fedora Reporter: Marek Goldmann <mgoldman>
Component: Package ReviewAssignee: gil cattaneo <puntogil>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: package-review, puntogil
Target Milestone: ---Flags: puntogil: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: netty4-4.0.14-1.fc20 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-01-08 13:22:18 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
licensecheck none

Description Marek Goldmann 2014-01-02 11:40:56 UTC 
Spec URL: http://goldmann.fedorapeople.org/package_review/netty4/1/netty4.spec
SRPM URL: http://goldmann.fedorapeople.org/package_review/netty4/1/netty4-4.0.14-1.fc20.src.rpm
Fedora Account System Username: goldmann

Description:

Netty is a NIO client server framework which enables quick and easy
development of network applications such as protocol servers and
clients. It greatly simplifies and streamlines network programming
such as TCP and UDP socket server.

'Quick and easy' doesn't mean that a resulting application will suffer
from a maintainability or a performance issue. Netty has been designed
carefully with the experiences earned from the implementation of a lot
of protocols such as FTP, SMTP, HTTP, and various binary and
text-based legacy protocols. As a result, Netty has succeeded to find
a way to achieve ease of development, performance, stability, and
flexibility without a compromise.

Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6348172

Please note that this is a compat package for netty. This package will be used only in Fedora 20, in Rawhide a newer versions the netty package will be updated to version 4.
Comment 1 gil cattaneo 2014-01-02 12:11:24 UTC 
Please, fix directories without known owners: /usr/share/java/netty4
Comment 2 gil cattaneo 2014-01-02 14:36:01 UTC 
Created attachment 844577 [details]
licensecheck
Comment 3 gil cattaneo 2014-01-02 14:38:39 UTC 
ISSUES:
[!]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "Apache (v2.0)", "BSD (3 clause)", "MIT/X11 (BSD like)", "Unknown or
     generated". 963 files have unknown license. Detailed output of
     licensecheck in /home/gil/1047851-netty4/licensecheck.txt
    License field should be: ASL 2.0 or BSD

[!]: Package contains no bundled libraries without FPC exception.
 * Written by Robert Harder and released to the public domain, as explained at
 * http://creativecommons.org/licenses/publicdomain
netty-netty-4.0.14.Final/codec/src/main/java/io/netty/handler/codec/base64/Base64.java
netty-netty-4.0.14.Final/codec/src/main/java/io/netty/handler/codec/base64/Base64Dialect.java
    License field should be: ASL 2.0 or BSD or Public Domain
    (maybe base64coder package?)

 * Adaptation of http://bjoern.hoehrmann.de/utf-8/decoder/dfa/
 *
 * Copyright (c) 2008-2009 Bjoern Hoehrmann <bjoern>
  ...
netty-netty-4.0.14.Final/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/UTF8Exception.java
netty-netty-4.0.14.Final/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/UTF8Output.java

// Copyright (c) 2011, Joe Walnes and contributors
netty-netty-4.0.14.Final/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocket07FrameDecoder.java
netty-netty-4.0.14.Final/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocket07FrameEncoder.java
netty-netty-4.0.14.Final/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocket08FrameDecoder.java
netty-netty-4.0.14.Final/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocket08FrameEncoder.java
netty-netty-4.0.14.Final/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocket13FrameDecoder.java
netty-netty-4.0.14.Final/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocket13FrameEncoder.java

 * Written by Doug Lea with assistance from members of JCP JSR-166
 * Expert Group and released to the public domain, as explained at
 * http://creativecommons.org/publicdomain/zero/1.0/
netty-netty-4.0.14.Final/common/src/main/java/io/netty/util/internal/chmv8/ConcurrentHashMapV8.java
netty-netty-4.0.14.Final/common/src/main/java/io/netty/util/internal/chmv8/CountedCompleter.java
netty-netty-4.0.14.Final/common/src/main/java/io/netty/util/internal/chmv8/ForkJoinPool.java
netty-netty-4.0.14.Final/common/src/main/java/io/netty/util/internal/chmv8/ForkJoinTask.java
netty-netty-4.0.14.Final/common/src/main/java/io/netty/util/internal/chmv8/ForkJoinWorkerThread.java
netty-netty-4.0.14.Final/common/src/main/java/io/netty/util/internal/chmv8/LongAdder.java
netty-netty-4.0.14.Final/common/src/main/java/io/netty/util/internal/chmv8/Striped64.java
netty-netty-4.0.14.Final/common/src/main/java/io/netty/util/internal/ThreadLocalRandom.java

 * Copyright (c) 2004-2011 QOS.ch
netty-netty-4.0.14.Final/common/src/main/java/io/netty/util/internal/logging/CommonsLogger.java
netty-netty-4.0.14.Final/common/src/main/java/io/netty/util/internal/logging/FormattingTuple.java
netty-netty-4.0.14.Final/common/src/main/java/io/netty/util/internal/logging/InternalLogger.java
netty-netty-4.0.14.Final/common/src/main/java/io/netty/util/internal/logging/JdkLogger.java
netty-netty-4.0.14.Final/common/src/main/java/io/netty/util/internal/logging/Log4JLogger.java
netty-netty-4.0.14.Final/common/src/main/java/io/netty/util/internal/logging/MessageFormatter.java

//The MIT License
//
//Copyright (c) 2009 Carl Bystršm
netty-netty-4.0.14.Final/example/src/main/java/io/netty/example/http/websocketx/client/WebSocketClient.java
netty-netty-4.0.14.Final/example/src/main/java/io/netty/example/http/websocketx/client/WebSocketClientHandler.java

Part of Google Caliper project under ASL 2.0 License
netty-netty-4.0.14.Final/microbench/src/test/java/com/google/caliper/StandardVm.java



[!]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/share/java/netty4
[!]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/java/netty4
    Please, use %dir %{_javadir}/%{name} in the main package
[!]: If tests are skipped during package build explain why it was needed in a
     comment
     Note: Tests seem to be skipped. Verify there is a commment giving a
     reason for this
    Please, add comment
 

     
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[!]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "Apache (v2.0)", "BSD (3 clause)", "MIT/X11 (BSD like)", "Unknown or
     generated". 963 files have unknown license. Detailed output of
     licensecheck in /home/gil/1047851-netty4/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/share/java/netty4
[!]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/java/netty4
[!]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[?]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Java:
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
     Note: Maven packages do not need to (Build)Require jpackage-utils. It is
     pulled in by maven-local
[x]: Javadoc documentation files are generated and included in -javadoc
     subpackage
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
[x]: Bundled jar/class files should be removed before build

Maven:
[x]: If package contains pom.xml files install it (including depmaps) even
     when building with ant
[!]: If tests are skipped during package build explain why it was needed in a
     comment
     Note: Tests seem to be skipped. Verify there is a commment giving a
     reason for this
[x]: Pom files have correct Maven mapping
[x]: Maven packages should use new style packaging
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DOES NOT have Requires(post) and Requires(postun) on jpackage-
     utils for %update_maven_depmap macro
[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     netty4-javadoc
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

Java:
[x]: Package uses upstream build method (ant/maven/etc.)
[x]: Packages are noarch unless they use JNI

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: netty4-4.0.14-1.fc21.noarch.rpm
          netty4-javadoc-4.0.14-1.fc21.noarch.rpm
          netty4-4.0.14-1.fc21.src.rpm
netty4.noarch: W: spelling-error %description -l en_US Netty -> Petty, Getty, Betty
netty4.noarch: W: invalid-url URL: https://netty.io/ <urlopen error timed out>
netty4-javadoc.noarch: W: invalid-url URL: https://netty.io/ <urlopen error timed out>
netty4.src: W: spelling-error %description -l en_US Netty -> Petty, Getty, Betty
netty4.src: W: invalid-url URL: https://netty.io/ <urlopen error timed out>
3 packages and 0 specfiles checked; 0 errors, 5 warnings.




Rpmlint (installed packages)
----------------------------
# rpmlint netty4 netty4-javadoc
netty4.noarch: W: spelling-error %description -l en_US Netty -> Petty, Getty, Betty
netty4.noarch: W: invalid-url URL: https://netty.io/ <urlopen error timed out>
netty4-javadoc.noarch: W: invalid-url URL: https://netty.io/ <urlopen error timed out>
2 packages and 0 specfiles checked; 0 errors, 3 warnings.
# echo 'rpmlint-done:'



Requires
--------
netty4 (rpmlib, GLIBC filtered):
    java
    jpackage-utils
    mvn(com.google.protobuf:protobuf-java)
    mvn(com.jcraft:jzlib)
    mvn(commons-logging:commons-logging)
    mvn(log4j:log4j)
    mvn(org.javassist:javassist)
    mvn(org.jboss.marshalling:jboss-marshalling)
    mvn(org.slf4j:slf4j-api)

netty4-javadoc (rpmlib, GLIBC filtered):
    jpackage-utils



Provides
--------
netty4:
    mvn(io.netty:netty-buffer:4)
    mvn(io.netty:netty-buffer:4.0.14)
    mvn(io.netty:netty-buffer:4.0.14.Final)
    mvn(io.netty:netty-codec-http:4)
    mvn(io.netty:netty-codec-http:4.0.14)
    mvn(io.netty:netty-codec-http:4.0.14.Final)
    mvn(io.netty:netty-codec-socks:4)
    mvn(io.netty:netty-codec-socks:4.0.14)
    mvn(io.netty:netty-codec-socks:4.0.14.Final)
    mvn(io.netty:netty-codec:4)
    mvn(io.netty:netty-codec:4.0.14)
    mvn(io.netty:netty-codec:4.0.14.Final)
    mvn(io.netty:netty-common:4)
    mvn(io.netty:netty-common:4.0.14)
    mvn(io.netty:netty-common:4.0.14.Final)
    mvn(io.netty:netty-handler:4)
    mvn(io.netty:netty-handler:4.0.14)
    mvn(io.netty:netty-handler:4.0.14.Final)
    mvn(io.netty:netty-parent)
    mvn(io.netty:netty-parent:pom:4)
    mvn(io.netty:netty-parent:pom:4.0.14)
    mvn(io.netty:netty-parent:pom:4.0.14.Final)
    mvn(io.netty:netty-transport-sctp:4)
    mvn(io.netty:netty-transport-sctp:4.0.14)
    mvn(io.netty:netty-transport-sctp:4.0.14.Final)
    mvn(io.netty:netty-transport:4)
    mvn(io.netty:netty-transport:4.0.14)
    mvn(io.netty:netty-transport:4.0.14.Final)
    netty4
    osgi(io.netty.buffer)
    osgi(io.netty.codec)
    osgi(io.netty.codec-http)
    osgi(io.netty.codec-socks)
    osgi(io.netty.common)
    osgi(io.netty.handler)
    osgi(io.netty.transport)
    osgi(io.netty.transport-sctp)

netty4-javadoc:
    netty4-javadoc



Source checksums
----------------
https://github.com/netty/netty/archive/netty-4.0.14.Final.tar.gz :
  CHECKSUM(SHA256) this package     : 4e4b7e9b644082eaf54ae7427417be5c1b8a85b32fa32e6cd13012ec265e4c2b
  CHECKSUM(SHA256) upstream package : 4e4b7e9b644082eaf54ae7427417be5c1b8a85b32fa32e6cd13012ec265e4c2b


Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30
Command line :/usr/bin/fedora-review -b 1047851 -m fedora-rawhide-i386
Buildroot used: fedora-rawhide-i386
Active plugins: Generic, Shell-api, Java
Disabled plugins: C/C++, Python, SugarActivity, Perl, R, PHP, Ruby
Disabled flags: EPEL5, EXARCH, DISTTAG

Please fix listed issues before import
Comment 4 Marek Goldmann 2014-01-02 18:01:52 UTC 
Thanks! I'll fix it at import time!

New Package SCM Request
=======================
Package Name: netty4
Short Description: An asynchronous event-driven network application framework and tools for Java
Owners: goldmann
Branches: f20
Comment 5 Gwyn Ciesla 2014-01-02 18:12:51 UTC 
Git done (by process-git-requests).