Bug 1048548
| Summary: | dump spits out "DUMP: mount: bad UUID" when dumping a ext4 filesystem | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Michael Carney <mwc> | ||||
| Component: | dump | Assignee: | Josef Ridky <jridky> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | low | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 24 | CC: | j, phracek | ||||
| Target Milestone: | --- | Keywords: | Reopened | ||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | dump-0.4-0.28.b45.fc24 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2016-08-10 23:23:53 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Michael Carney
2014-01-05 02:30:20 UTC
Still happens in F21. This message is a reminder that Fedora 20 is nearing its end of life. Approximately 4 (four) weeks from now Fedora will stop maintaining and issuing updates for Fedora 20. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '20'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 20 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. Still happens in F22. Fedora 20 changed to end-of-life (EOL) status on 2015-06-23. Fedora 20 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed. Again, still happens in F22. Would you be able to send me a step for reproducing? I will contact upstream with a patch If I am able to solve it. I took a look at the code -- here's the problem:
dump parses /etc/fstab, and if it encounters a UUID spec for block device, it validates this by checking that the UUID spec is 36 chars long, and made up of '-' and hexidecimal chars.
The problem occurs because /boot/efi is a vfat filesystem, so its UUID is limited to 9 chars:
378> grep UUID /etc/fstab
UUID=744e55f6-6e46-41f4-8940-4941061bb76b /boot ext4 defaults 1 2
UUID=7F88-54FB /boot/efi vfat umask=0077,shortname=winnt 0 0
379>
or
523# lsblk -af /dev/sda1
NAME FSTYPE LABEL UUID MOUNTPOINT
sda1 vfat F22-bootefi 7F88-54FB /boot/efi
524#
Thus the sda1 UUID spec fails dump's UUID validation, (bylabel.c in compat/lib)
it spits out the 'bad UUID' message.
The real *BUG* is:
dump should be ignoring all FS in /etc/fstab that do not have a FStype of ext{2,3,4}. It can't dump those other FS anyway.
Workaround: change /boot/efi block device spec from UUID to LABEL. Note that anaconda produces the fstab originally.
After some further dump code review, a surprising discovery: dump never validates the fstype (mnt_type). It just drives on to ext2fs_open() and fails there. Validating the mntent produced from command line and/or fstab and tossing non-ext2/3/4 entries early on would be nicer, I'd think. Sorry wrong Bugzilla switching back to NEW. This package has changed ownership in the Fedora Package Database. Reassigning to the new owner of this component. Fedora 22 changed to end-of-life (EOL) status on 2016-07-19. Fedora 22 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed. Oh come on. I've already fixed the bug for you -- a year ago. Just implement the changes I suggested. Jeez. Hi, I discussed with upstream, how to solve this issue. Result of the discussion is, that dump support only ext2/3/4 file systems, so FAT/VFAT file systems are unsupported. That is the reason, why is error message shown. Upstream is not going to correct this behaviour of dump. And from dump's man page: "It might be considered a bug that this version of dump can only handle ext2/3/4 file systems. Specifically, it does not work with FAT file systems." Because of this fact, I am closing this bug as NOTABUG. You don't understand what's happening with this bug. *NO ONE* is trying to dump a FAT filesystem using dump(8). dump(8) processes *EVERY* entry in /etc/fstab whenever it is invoked, thus will *ALWAYS* spit out this message anytime a UUID FAT entry is encountered -- which is going to be all the time if anaconda creates the fstab. Here's my fstab with the anaconda entry commented out and a LABEL entry added to avoid this bug. #UUID=769B-5090 /boot/efi vfat umask=0077,shortname=winnt 0 2 LABEL=F24-bootefi /boot/efi vfat umask=0077,shortname=winnt 0 2 I already root-caused and suggested fixes for this bug. Do you want me to submit the patch too?? Sigh.. Created attachment 1184397 [details]
Patch for this bug
This patch fixes this problem, and also fixes a latent I noticed while fixing this bug.
Your patch has been forwarded to upstream. Thank you, Josef. Just curious -- what's the upstream for dump(8)? Thanks. Hi Michael, the upstream website is https://sourceforge.net/projects/dump/. I've just uploaded new release of dump into Fedora rawhide (#1361495) now is needed to wait for enough karma points in Bodhi service, before it will be published in Fedora 24. This update contains patch you attached in this bugzilla. I will close this bug when the update will be public for Fedora 24 users. dump-0.4-0.1.b45.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-d154617aae dump-0.4-0.1.b45.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-d154617aae I downloaded and built the upstream version (dump-0.4b45) and ran it on my Fedora 24 system. It immediately crashes. I submitted a bug with the upstream project for this problem: https://sourceforge.net/p/dump/bugs/167/ dump-0.4-0.28.b45.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. |