Bug 1048617
| Summary: | lz4-r110-1 not built with $RPM_OPT_FLAGS | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ville Skyttä <ville.skytta> | ||||
| Component: | lz4 | Assignee: | pjp <pj.pandit> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | rawhide | CC: | pj.pandit | ||||
| Target Milestone: | --- | Keywords: | Patch | ||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | lz4-r116-1.fc20 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2014-04-29 05:20:33 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 496968 | ||||||
| Attachments: |
|
||||||
Hello Ville,
Thanks so much for the patch. It'll help if you send the Makefile patch to the upstream developer. I've made the relevant changes to the spec file to export CFLAGS="$RPM_OPT_FLAGS" before make %{?_smp_mflags}.
Thank you.
(In reply to pjp from comment #1) > It'll help if you send the Makefile patch to the upstream developer. As noted in the patch I attached here, already done. https://code.google.com/p/lz4/issues/detail?id=106 > I've made the relevant changes to the spec file to > export CFLAGS="$RPM_OPT_FLAGS" before make %{?_smp_mflags}. I suggest also applying the actual lz4-cflags.patch, otherwise the specfile modifications make no difference. Note that Bugzilla fails to show the embedded lz4-cflags.patch in some of its patch views, but it is visible e.g. here: https://bugzilla.redhat.com/attachment.cgi?id=845835 (The easiest thing for you would have been to just "git am" that one...) (In reply to Ville Skyttä from comment #2) > As noted in the patch I attached here, already done. > https://code.google.com/p/lz4/issues/detail?id=106 Strange! He says it was merged in r111, but r114 Makefile still has CFLAGS+= -I. -std=c99 -O3 -Wall -W -Wundef -DLZ4_VERSION=\"$(RELEASE)\" Maybe the change was reverted in subsequent releases. > I suggest also applying the actual lz4-cflags.patch, otherwise the specfile > modifications make no difference. Note that Bugzilla fails to show the > embedded lz4-cflags.patch in some of its patch views, but it is visible e.g. > here: > https://bugzilla.redhat.com/attachment.cgi?id=845835 Yes, I did see the attached patch. If it is merged upstream, we don't need to apply lz4-cflags.patch in the spec file. (In reply to pjp from comment #3) > (In reply to Ville Skyttä from comment #2) > > As noted in the patch I attached here, already done. > > https://code.google.com/p/lz4/issues/detail?id=106 > > Strange! He says it was merged in r111, but r114 Makefile still has > > CFLAGS+= -I. -std=c99 -O3 -Wall -W -Wundef -DLZ4_VERSION=\"$(RELEASE)\" But that's fine. Note the plus in +=, it's just an alternative (possibly better) way of accomplishing the same thing that was in my original patch. (In reply to Ville Skyttä from comment #4) > But that's fine. Note the plus in +=, it's just an alternative (possibly > better) way of accomplishing the same thing that was in my original patch. Ah yep. I missed your second comment there. Thank you. lz4-r116-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/lz4-r116-1.fc19 lz4-r116-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/lz4-r116-1.fc20 Package lz4-r116-1.fc20: * should fix your issue, * was pushed to the Fedora 20 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing lz4-r116-1.fc20' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2014-5128/lz4-r116-1.fc20 then log in and leave karma (feedback). lz4-r116-1.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report. lz4-r116-1.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. |
Created attachment 845835 [details] Build with $RPM_OPT_FLAGS Fix attached, let me know if you'd like me to push and build this for devel.