Bug 1048992

Summary:	Met "NoMethodError" when creating valid/invalid domain from /console/domains/new page.
Product:	OKD	Reporter:	Luke Meyer <lmeyer>
Component:	Management Console	Assignee:	Jordan Liggitt <jliggitt>
Status:	CLOSED CURRENTRELEASE	QA Contact:	libra bugs <libra-bugs>
Severity:	high	Docs Contact:	Jordan Liggitt <jliggitt>
Priority:	medium
Version:	2.x	CC:	isaac.christoffersen, jialiu, jkeck, jliggitt, kh411dz, tfeng, yujzhang
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1017656	Environment:
Last Closed:	2014-01-30 00:47:10 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1017656

Description Luke Meyer 2014-01-06 17:27:48 UTC

+++ This bug was initially created as a clone of Bug #1017656 +++

Description of problem:

Tried to create multipul domains from console, but met "NoMethodError" as following:

2013-10-10 02:33:49.897 [INFO ] Started POST "/console/domains" for 127.0.0.1 at 2013-10-10 02:33:49 -0700 (pid:10951)
2013-10-10 02:33:49.899 [INFO ] Processing by DomainsController#create as HTML (pid:10951)
2013-10-10 02:33:49.899 [INFO ] Parameters: {"utf8"=>"✓", "authenticity_token"=>"OEjsvBy8QlsEezBIxBAOyPxvaElhPrmIm1dbiHOJHhY=", "then"=>"", "domain_param"=>"", "domain"=>{"name"=>"sasdfa"}} (pid:10951)
2013-10-10 02:33:49.941 [INFO ] Completed 500 Internal Server Error in 42ms (pid:10951)
2013-10-10 02:33:49.948 [FATAL] NoMethodError (undefined method `remote_request?' for #<DomainsController:0x0000000411d920>):
  openshift-origin-console (1.15.6) app/controllers/console_controller.rb:27:in `valid_referrer'
  openshift-origin-console (1.15.6) app/controllers/domains_controller.rb:22:in `create'
  actionpack (3.2.8) lib/action_controller/metal/implicit_render.rb:4:in `send_action'
  actionpack (3.2.8) lib/abstract_controller/base.rb:167:in `process_action'
  actionpack (3.2.8) lib/action_controller/metal/rendering.rb:10:in `process_action'
  actionpack (3.2.8) lib/abstract_controller/callbacks.rb:18:in `block in process_action'
  activesupport (3.2.8) lib/active_support/callbacks.rb:428:in `block (3 levels) in _run__328336666741373877__process_action__3805827379399542533__callbacks'
  activesupport (3.2.8) lib/active_support/callbacks.rb:215:in `block in _conditional_callback_around_93'
  activesupport (3.2.8) lib/active_support/callbacks.rb:326:in `around'
  activesupport (3.2.8) lib/active_support/callbacks.rb:310:in `_callback_around_31'

Multi domains can be create successfully using rhc, this issue just exists on console.

Version-Release number of selected component (if applicable):
2.0/2013-10-08.1 puddle

How reproducible:
always

Steps to Reproduce:
1.Set MAX_DOMAINS_PER_USER="3" in file
2.Try do create the second domain from console/domains/new page
3.

Actual results:

Failed to create more than 1 domain and met "NoMethodError". Full log is as attachment.

Expected results:

Multi domains should be created successfully from console.

Additional info:

Comment 2 Clayton Coleman 2014-01-06 17:42:05 UTC

Console needs to define remote_request?

Comment 3 Clayton Coleman 2014-01-06 17:48:15 UTC

(that's not a question)

Comment 5 Jordan Liggitt 2014-01-07 18:16:01 UTC

Fixed in
https://github.com/openshift/li/pull/2262
https://github.com/openshift/origin-server/pull/4427

Comment 6 openshift-github-bot 2014-01-08 10:32:31 UTC

Commit pushed to master at https://github.com/openshift/origin-server

https://github.com/openshift/origin-server/commit/38400e09a99089f28bddb17d4af38a4769491349
Fix bug 1048992: Define remote_request? in console controller

Comment 7 Yujie Zhang 2014-01-09 03:41:24 UTC

Tested on devenv_4198, it can work correctly when creating valid/invalid domain using from /domains/new page, so verify this bug, thanks.

Comment 8 Jordan Liggitt 2014-06-06 17:47:03 UTC

*** Bug 1104943 has been marked as a duplicate of this bug. ***