Bug 1049107

Summary: NetworkManager does not compile due to stale patches
Product: [Fedora] Fedora Reporter: Scott Shambarger <scott-fedora>
Component: NetworkManagerAssignee: Dan Williams <dcbw>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 20CC: dcbw
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-04-04 22:09:29 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Patch to fix NetworkManager compile none

Description Scott Shambarger 2014-01-07 03:11:13 UTC
Description of problem:
rpmbuild -bb NetworkManager.spec fails with fatal compile errors using gcc 4.8.2

Version-Release number of selected component (if applicable):
NetworkManager-0.9.9.0-22.git20131003.fc20
gcc-4.8.2-7.fc20

How reproducible:
Always

Steps to Reproduce:
1. Install SRPM for NetworkManager
2. Attempt to build binary packages: rpmbuild -bb NetworkManager.spec

Actual results:
Build fails with "all warnings being treated as errors"

Expected results:
Binary packages should be produced.

Additional info:
Example compile error:
nm-remote-settings.c: In function 'nm_remote_settings_load_connections':
nm-remote-settings.c:667:551: error: return makes integer from pointer without a cast [-Werror]
  g_return_val_if_fail (NM_IS_REMOTE_SETTINGS (settings), NULL);
                                                                       ^
nm-remote-settings.c:668:262: error: return makes integer from pointer without a cast [-Werror]
  g_return_val_if_fail (filenames != NULL, NULL);
                      ^
cc1: all warnings being treated as errors
make[4]: *** [libnm_glib_la-nm-remote-settings.lo] Error 1

Comment 1 Scott Shambarger 2014-01-07 03:16:16 UTC
Created attachment 846408 [details]
Patch to fix NetworkManager compile

Comment 2 Scott Shambarger 2014-01-07 03:17:04 UTC
I fixed the compile errors and created a patch that can be applied by the specfile to allow compilation to complete.

Comment 3 Scott Shambarger 2014-04-04 22:09:29 UTC
This appears fixed in the latest builds (0.9.9.0-33.git20131003)... closing.