Bug 1049368

Summary: Project editor silently overwrites
Product: [Retired] JBoss BRMS Platform 6 Reporter: Zuzana Krejčová <zkrejcov>
Component: Business CentralAssignee: Alexandre Porcelli <porcelli>
Status: CLOSED CURRENTRELEASE QA Contact: Zuzana Krejčová <zkrejcov>
Severity: high Docs Contact:
Priority: high    
Version: 6.0.0CC: etirelli, lpetrovi, porcelli, rrajasek, rzhang
Target Milestone: CR1   
Target Release: 6.0.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-08-06 20:17:59 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 999950    

Description Zuzana Krejčová 2014-01-07 13:36:57 UTC 
Description of problem:
The project editor still has that 'last save wins' behaviour. When two user change something in the Project editor, the second save overwrites the first without any warning or notification.

In one out of many attempts, I got some error pop-up (upon saving) with the option to Reopen or Cancel, but choosing Reopen did nothing with the Project editor. I haven't been able to get this pop-up ever since.


Version-Release number of selected component (if applicable):
BPMS 6.0 ER7


Steps to Reproduce:
1. Users u1 and u2 both open the Project editor for the same project.
2. User u1 changes the project name, saves.
3. User u2 changes the project description, saves.


Actual results:
The second save is successful, no warning or error, first save is overwritten.


Expected results:
Conflict warning, pop-up informing the second user that the file was changed, offering options to Force save, Reopen or Cancel, as with the other editors.
Comment 1 manstis 2014-01-08 16:02:07 UTC 
Sorry Toni, looks like concurrency support in the Project Editor is broken. Perhaps ask Alexandre to cast an eye over it if you're uncertain.
Comment 2 Alexandre Porcelli 2014-01-10 17:45:06 UTC 
Fix pushed to master and product branch of uberfire and kie-wb-common repositories:

(0.3.x) http://github.com/droolsjbpm/uberfire/commit/e62c9d122
(master) http://github.com/droolsjbpm/uberfire/commit/e0ea4c034

(6.0.x) https://github.com/droolsjbpm/kie-wb-common/commit/e54a4f94b
(6.0.x) https://github.com/droolsjbpm/kie-wb-common/commit/f918517bb
(master) https://github.com/droolsjbpm/kie-wb-common/commit/55304bf72
(master) http://github.com/droolsjbpm/kie-wb-common/commit/0ccd9ba8d
Comment 3 Alexandre Porcelli 2014-01-16 13:04:05 UTC 
One additional fix on guvnor repository in order to avoid unncessary dot files:

(6.0.x) http://github.com/droolsjbpm/guvnor/commit/7a42d37a3
(master) http://github.com/droolsjbpm/guvnor/commit/bcf1c1396