Bug 1049475
| Summary: | RHEVM sends to XPI SPICE plugin always SPICE proxy even one unchecks this options in Console Options | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 6 | Reporter: | Jiri Belka <jbelka> | ||||||
| Component: | spice-xpi | Assignee: | Christophe Fergeau <cfergeau> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | SPICE QE bug list <spice-qe-bugs> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | 6.6 | CC: | astepano, cfergeau, dblechte, iheim, jbelka, lpeer, mavital, michal.skrivanek, rbalakri, Rhev-m-bugs, sherold, tjelinek, tpelka, vehrlich, yeylon | ||||||
| Target Milestone: | pre-dev-freeze | Keywords: | Reopened | ||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | spice | ||||||||
| Fixed In Version: | spice-xpi-2.7-27.el6 | Doc Type: | Bug Fix | ||||||
| Doc Text: |
* Previously, after enabling a proxy for a SPICE connection opened through the spice-xpi plug-in, the only way the user could unset the proxy was to close or reopen the web page. This update modifies spice-xpi to unset the SPICE_PROXY environment variable when the proxy is unset. As a result, unsetting a proxy for a SPICE connection works as expected. (BZ#1049475)
|
Story Points: | --- | ||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2015-07-22 07:28:18 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
Jiri Belka
2014-01-07 15:32:50 UTC
Created attachment 846737 [details]
various logs...
I found the reproducer is a little bit trickier: 1. Launch browser and log into User Portal. 2. Open VM Console options, uncheck the SPICE proxy & save. 3. Open VM console -> VM console is opened this time! 4. Open VM Console options, check the SPICE proxy, save and try to open VM console again -> error "Unable to connect to the graphic server (null)". 5. Repeat steps 2 and 3. -> from this time the error is always returned. In the very same way this bug affects also RHEVM 3.3 (rhevm-3.3.0-0.43.el6ev.noarch - is30). use case doesn't sound interesting enough for 3.5 moreover can't reproduce on dev setup yet care to re-try? we couldn't reproduce and I'm not aware of any complaints from teh field…would close otherwise I can still reproduce, proxy is not "reset" if it is unchecked in Console Options for browser plugin (xpi). ovirt-engine-backend-3.5.0-0.0.master.20140804172041.git23b558e.el6.noarch ovirt-engine-webadmin-portal-3.5.0-0.0.master.20140804172041.git23b558e.el6.noarch You should probably ask GSS who uses proxy and let them check. we didn't reproduce back then, nor now. if you happen to reproduce please specify exact steps and make sure it reproduces on another setup too i can reproduce exactly as written in #2. rhevm-webadmin-portal-3.5.0-0.30.el6ev.noarch firefox-31.2.0-3.el6_6.x86_64 OK, finally reproduced and it seems as an issue in spice-xpi. @Christophe: Hi, it seems that when enabling the spice proxy in spice-xpi there is no way to disable it again - only restarting the browser. It reproduces on: spice-xpi-2.7-25.el6.x86_64 virt-viewer-0.6.0-11.el6.x86_64 firefox-31.1.0-5.el6_5.x86_64 all are the default versions on RHEL 6.6 please note it does not reproduce on Fedora 20 (spice-xpi-2.8.90-1.fc20.x86_64, virt-viewer-0.6.0-1.fc20.x86_64) I was able to reproduce it both using oVirt and using the test page available here: https://teuf.fedorapeople.org/plugins/test.html The steps for test page: - fill in the host/port - connect - it will work - enable spice proxy and enter an incorrect value - connect - it will fail to connect since the proxy is not correct - disable the spice proxy again and connect - it will fail with the same error as when the proxy is enabled after restarting the browser the spice proxy is disabled again and it is possible to connect again. Is this a know issue? Since it seems to be fixed in more recent versions. Thanx Created attachment 1002406 [details] Unset SPICE_PROXY env var when proxy is not set This does not seem to be fixed upstream, but is working because upstream no longer looks at the SPICE_PROXY environment variable (?) This patch fixes the issue for me (RHEL6 scratch build at https://brewweb.devel.redhat.com/taskinfo?taskID=8855582 ), I'll need to send a proper patch upstream hi, I have tried the https://brewweb.devel.redhat.com/taskinfo?taskID=8855582 with my userportal and it works well - thanx! Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHBA-2015-1393.html |