Bug 1049549

Found issues:

1) the LICENSE file is missing in the result packages

2) main description: missing dot at the end :-)

3) the find command could be better written (cosmetic):

 find %{buildroot} -name '*.la' -delete

4) obsolete m4 macros

  AC_PROG_LIBTOOL found in: openexr-2.1.0/configure.ac:30
  AM_CONFIG_HEADER found in: openexr-2.1.0/configure.ac:14


Only the first one is required. :-)

Spec URL: http://smani.fedorapeople.org/review/mingw-OpenEXR.spec
SRPM URL: http://smani.fedorapeople.org/review/mingw-OpenEXR-2.1.0-2.fc21.src.rpm

* Tue Jan 14 2014 Sandro Mani <manisandro> - 2.1.0-2
- Add LICENSE to doc
- Add patch to replace obsolete configure.ac macros

I'm sorry, I overlooked one more check:

[!]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/i686-w64-mingw32/sys-
     root/mingw/include/OpenEXR(mingw32-OpenEXR, mingw32-ilmbase),
     /usr/x86_64-w64-mingw32/sys-root/mingw/include/OpenEXR(mingw64-OpenEXR,
     mingw64-ilmbase)

Because mingw32/64-OpenEXR already depends on mingw32/64-ilmbase which provide the directories, they can removed from the listing in the packages:

%dir %{mingw64_includedir}/OpenEXR
%dir %{mingw32_includedir}/OpenEXR

Full report:

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "BSD (3 clause)", "BSD (2 clause)", "Unknown or generated". 4 files have
     unknown license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
[!]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/i686-w64-mingw32/sys-
     root/mingw/include/OpenEXR(mingw32-OpenEXR, mingw32-ilmbase),
     /usr/x86_64-w64-mingw32/sys-root/mingw/include/OpenEXR(mingw64-OpenEXR,
     mingw64-ilmbase)
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 2 files.
[!]: Package complies to the Packaging Guidelines
     It's the mentioned directory confict */include/OpenEXR.
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Uses parallel make %{?_smp_mflags} macro.
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Package should not use obsolete m4 macros
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: mingw32-OpenEXR-2.1.0-2.fc21.noarch.rpm
          mingw32-OpenEXR-static-2.1.0-2.fc21.noarch.rpm
          mingw32-OpenEXR-tools-2.1.0-2.fc21.noarch.rpm
          mingw64-OpenEXR-2.1.0-2.fc21.noarch.rpm
          mingw64-OpenEXR-static-2.1.0-2.fc21.noarch.rpm
          mingw64-OpenEXR-tools-2.1.0-2.fc21.noarch.rpm
          mingw-OpenEXR-2.1.0-2.fc21.src.rpm
mingw32-OpenEXR-static.noarch: W: no-documentation
mingw32-OpenEXR-tools.noarch: W: no-documentation
mingw64-OpenEXR-static.noarch: W: no-documentation
mingw64-OpenEXR-tools.noarch: W: no-documentation
mingw-OpenEXR.src: W: file-size-mismatch openexr-2.1.0.tar.gz = 13680959, http://download.savannah.nongnu.org/releases/openexr/openexr-2.1.0.tar.gz = 13680816
7 packages and 0 specfiles checked; 0 errors, 5 warnings.




Rpmlint (installed packages)
----------------------------
# rpmlint mingw64-OpenEXR-tools mingw32-OpenEXR-tools mingw32-OpenEXR mingw64-OpenEXR-static mingw64-OpenEXR mingw32-OpenEXR-st 
atic
mingw64-OpenEXR-tools.noarch: W: no-documentation
mingw32-OpenEXR-tools.noarch: W: no-documentation
mingw64-OpenEXR-static.noarch: W: no-documentation
mingw32-OpenEXR-static.noarch: W: no-documentation
6 packages and 0 specfiles checked; 0 errors, 4 warnings.
# echo 'rpmlint-done:'



Requires
--------
mingw64-OpenEXR-tools (rpmlib, GLIBC filtered):
    mingw64(kernel32.dll)
    mingw64(libgcc_s_seh-1.dll)
    mingw64(libhalf-11.dll)
    mingw64(libiex-2_1-11.dll)
    mingw64(libilmimf-imf_2_1-21.dll)
    mingw64(libstdc++-6.dll)
    mingw64(msvcrt.dll)
    mingw64-OpenEXR
    mingw64-crt
    mingw64-filesystem

mingw32-OpenEXR-tools (rpmlib, GLIBC filtered):
    mingw32(kernel32.dll)
    mingw32(libgcc_s_sjlj-1.dll)
    mingw32(libhalf-11.dll)
    mingw32(libiex-2_1-11.dll)
    mingw32(libilmimf-imf_2_1-21.dll)
    mingw32(libstdc++-6.dll)
    mingw32(msvcrt.dll)
    mingw32-OpenEXR
    mingw32-crt
    mingw32-filesystem

mingw32-OpenEXR (rpmlib, GLIBC filtered):
    mingw32(kernel32.dll)
    mingw32(libgcc_s_sjlj-1.dll)
    mingw32(libhalf-11.dll)
    mingw32(libiex-2_1-11.dll)
    mingw32(libilmthread-2_1-11.dll)
    mingw32(libstdc++-6.dll)
    mingw32(msvcrt.dll)
    mingw32(user32.dll)
    mingw32(zlib1.dll)
    mingw32-crt
    mingw32-filesystem
    mingw32-pkg-config

mingw64-OpenEXR-static (rpmlib, GLIBC filtered):
    mingw64-OpenEXR

mingw64-OpenEXR (rpmlib, GLIBC filtered):
    mingw64(kernel32.dll)
    mingw64(libgcc_s_seh-1.dll)
    mingw64(libhalf-11.dll)
    mingw64(libiex-2_1-11.dll)
    mingw64(libilmthread-2_1-11.dll)
    mingw64(libstdc++-6.dll)
    mingw64(msvcrt.dll)
    mingw64(user32.dll)
    mingw64(zlib1.dll)
    mingw64-crt
    mingw64-filesystem
    mingw64-pkg-config

mingw32-OpenEXR-static (rpmlib, GLIBC filtered):
    mingw32-OpenEXR



Provides
--------
mingw64-OpenEXR-tools:
    mingw64-OpenEXR-tools

mingw32-OpenEXR-tools:
    mingw32-OpenEXR-tools

mingw32-OpenEXR:
    mingw32(libilmimf-imf_2_1-21.dll)
    mingw32-OpenEXR

mingw64-OpenEXR-static:
    mingw64-OpenEXR-static

mingw64-OpenEXR:
    mingw64(libilmimf-imf_2_1-21.dll)
    mingw64-OpenEXR

mingw32-OpenEXR-static:
    mingw32-OpenEXR-static



Source checksums
----------------
http://download.savannah.nongnu.org/releases/openexr/openexr-2.1.0.tar.gz :
  CHECKSUM(SHA256) this package     : a2bc21dea9dc4d472a8faa77e52eb627ea321c7ee4abab3d6d1a634c379b630b
  CHECKSUM(SHA256) upstream package : 54486b454073c1dcb5ae9892cf0f730ffefe62f38176325281505093fd218a14
diff -r also reports differences


Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13
Command line :/usr/bin/fedora-review -b 1049549 -m fedora-rawhide-x86_64 -L /home/valtri/fedora-scm/REPO
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

Built with local dependencies:
    /home/valtri/fedora-scm/REPO/mingw-ilmbase-2.1.0-1.fc21.src.rpm
    /home/valtri/fedora-scm/REPO/mingw32-ilmbase-debuginfo-2.1.0-1.fc21.noarch.rpm
    /home/valtri/fedora-scm/REPO/mingw64-ilmbase-static-2.1.0-1.fc21.noarch.rpm
    /home/valtri/fedora-scm/REPO/mingw64-ilmbase-2.1.0-1.fc21.noarch.rpm
    /home/valtri/fedora-scm/REPO/mingw32-ilmbase-static-2.1.0-1.fc21.noarch.rpm
    /home/valtri/fedora-scm/REPO/mingw32-ilmbase-2.1.0-1.fc21.noarch.rpm
    /home/valtri/fedora-scm/REPO/mingw64-ilmbase-debuginfo-2.1.0-1.fc21.noarch.rpm

======

Package APPROVED! The directories can be removed from the listing post-review.

Thanks!

New Package SCM Request
=======================
Package Name: mingw-OpenEXR
Short Description: MinGW Windows OpenEXR library
Owners: smani
Branches: f19 f20
InitialCC:

Git done (by process-git-requests).

mingw-OpenEXR-2.1.0-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/mingw-OpenEXR-2.1.0-2.fc20

mingw-OpenEXR-2.1.0-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/mingw-OpenEXR-2.1.0-2.fc19

mingw-OpenEXR-2.1.0-2.fc20 has been pushed to the Fedora 20 testing repository.

mingw-OpenEXR-2.1.0-2.fc19 has been pushed to the Fedora 19 stable repository.

mingw-OpenEXR-2.1.0-2.fc20 has been pushed to the Fedora 20 stable repository.