Bug 1049741

Summary:	"Share this link" for creating new application includes suffix of manifest file in default domain name
Product:	OpenShift Container Platform	Reporter:	Tian Feng <tfeng>
Component:	Management Console	Assignee:	Brenton Leanhardt <bleanhar>
Status:	CLOSED ERRATA	QA Contact:	libra bugs <libra-bugs>
Severity:	low	Docs Contact:
Priority:	low
Version:	2.0.0	CC:	adellape, bleanhar, gideon, gpei, jliggitt, jolamb, pruan, xtian, yujzhang
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	rubygem-openshift-origin-console-1.17.6.5-1.el6op, openshift-origin-console-1.15.1.2-2.el6op	Doc Type:	Bug Fix
Doc Text:	When users clicked “Share this link” while creating a new application with a custom cartridge manifest in the Management Console, a name in the “Public URL” field was generated that incorrectly included the suffix from the URL or path of the manifest. This issue has been fixed so that suggested names are generated without these suffixes.	Story Points:	---
Clone Of:	1039591	Environment:
Last Closed:	2014-01-28 16:39:33 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1039591
Bug Blocks:

Description Tian Feng 2014-01-08 06:18:07 UTC

+++ This bug was initially created as a clone of Bug #1039591 +++

The version is puddle[2.0.1/2014-01-07.2]

Description of problem:

"Share this link" for creating new applications includes the suffix of the manifest file in the default URL.


How reproducible:

Always


Steps to Reproduce:
1. Click the "Add application..." button in the web console.
2. Enter the URL to a manifest e.g. https://raw.github.com/accursoft/Haskell-Cloud/master/.openshift/manifests/network.yml.
2. Click "Next"
3. Click "Share this link"

Actual results:

The "Public URL" field has defaulted to networkyml.


Expected results:

It should be empty or network.

--- Additional comment from Jordan Liggitt on 2013-12-10 11:21:13 EST ---

Will merge in https://github.com/openshift/origin-server/pull/4304

--- Additional comment from Jordan Liggitt on 2013-12-10 11:22:06 EST ---

Will suggest names from custom cart manifest hashes (http://foo.bar#custom_name) or name params (http://foo.bar?name=custom_name), but not from the manifest url or path

--- Additional comment from openshift-github-bot on 2013-12-11 12:22:16 EST ---

Commit pushed to master at https://github.com/openshift/origin-server

https://github.com/openshift/origin-server/commit/7928aac8bb4dbdb123cd457442f803471a2fcc99
Fix bug 1039591: Don't use url basename as suggested app name

--- Additional comment from Yujie Zhang on 2013-12-12 00:44:29 EST ---

Tested on devenv_4125, the suggested app name is not "manifestyml" now after clicking the “share this link” link, so verify this bug, thanks.

Comment 2 Brenton Leanhardt 2014-01-14 14:55:02 UTC

Upstream:

commit 7928aac8bb4dbdb123cd457442f803471a2fcc99
Author: liggitt <jliggitt>
Date:   Tue Dec 10 10:49:23 2013 -0500

    Fix bug 1039591: Don't use url basename as suggested app name

PR: https://github.com/openshift/enterprise-server/pull/196

Comment 4 Tian Feng 2014-01-15 02:48:37 UTC

Test on puddle [2.0.2/2014-01-14]
Create an app via community url and then click "Share this link" on creating app page. The direct page won't use manifest as default app name. So verify this bug. Thanks!

Comment 6 errata-xmlrpc 2014-01-28 16:39:33 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2014-0102.html