Bug 1051865

Summary:	gNFS sets ACL mask wrongly in GETACL
Product:	[Community] GlusterFS	Reporter:	santosh pradhan <spradhan>
Component:	nfs	Assignee:	Niels de Vos <ndevos>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs, gluster-bugs, ndevos, vagarwal
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.6.0beta1	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-11-11 08:26:50 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description santosh pradhan 2014-01-12 10:46:58 UTC

Description of problem:


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. Mount the vol with NFS protocol
2. Create a file with touch command and do a getfacl on that file
3. Capture n/w packets and see verify the ACL masks being communicated between client and Gluster NFS server

Actual results:
Even if the file is a regular file (NFS client sends the mask as 3, Gluster NFS server always sends back mask as 15.

Expected results:
They should be same.

Additional info:

Comment 1 Anand Avati 2014-01-12 10:51:56 UTC

REVIEW: http://review.gluster.org/6683 (gNFS: Server sets ACL mask wrongly in GETACL reply) posted (#1) for review on master by Santosh Pradhan (spradhan)

Comment 3 Anand Avati 2014-01-13 07:48:24 UTC

COMMIT: http://review.gluster.org/6683 committed in master by Vijay Bellur (vbellur) 
------
commit 5a26daaea96aa3f7855b8d75b6568449f5466cc2
Author: Santosh Kumar Pradhan <spradhan>
Date:   Fri Jan 10 11:57:05 2014 +0530

    gNFS: Server sets ACL mask wrongly in GETACL reply
    
    FIX:
    1. Set the ACL mask what was requested by client
    2. Validate the ACL mask in SETACL routine
    
    Change-Id: Icb8576a8fe2684e0beaf94e8db6a92bc70bbfe7f
    BUG: 1051865
    Signed-off-by: Santosh Kumar Pradhan <spradhan>
    Reviewed-on: http://review.gluster.org/6683
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 6 Niels de Vos 2014-09-22 12:34:53 UTC

A beta release for GlusterFS 3.6.0 has been released. Please verify if the release solves this bug report for you. In case the glusterfs-3.6.0beta1 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED.

Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-September/018836.html
[2] http://supercolony.gluster.org/pipermail/gluster-users/

Comment 7 Niels de Vos 2014-11-11 08:26:50 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.1, please reopen this bug report.

glusterfs-3.6.1 has been announced [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019410.html
[2] http://supercolony.gluster.org/mailman/listinfo/gluster-users