Bug 1051886
| Summary: | Compile drivers with Visual Studio 2013 | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | Yvugenfi <yvugenfi> |
| Component: | virtio-win | Assignee: | Yvugenfi <yvugenfi> |
| Status: | CLOSED ERRATA | QA Contact: | Virtualization Bugs <virt-bugs> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 7.0 | CC: | bcao, juzhang, knoel, mdeng, michen, rbalakri, virt-maint, vrozenfe, yvugenfi |
| Target Milestone: | rc | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | virtio-win-prewhql-0.1-87 | Doc Type: | Bug Fix |
| Doc Text: |
Cause:
In previous version the part of virtio-win drivers were build with VS2012
Consequence:
Since Microsoft released a new version on Visual Studio, designed to work with the latest Windows Driver Kit (WDK) 8.1 we have to update our build system to use VS2013 instead of VS2012.
Fix:
Update project files as well as build scripts to use VS2013.
Result:
Now virtio-win build system uses VS2013 instead of VS2012 in order to produce virtio-win drivers.
|
Story Points: | --- |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-03-05 05:33:34 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Yvugenfi@redhat.com
2014-01-12 14:19:28 UTC
I saw <MinimumRequiredVersion>6.0</MinimumRequiredVersion> was added as a fix But I have an question about the file in Line #471 and line ##364 I saw them are same .<ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Vista Release|Win32'"> ) Why add <MinimumRequiredVersion>6.0</MinimumRequiredVersion> under the ItemDefinitionGroup under line #471 instead of #364? Thanks, Mike The file is not edited manually. This is how Visual Studio decided to change it. I am puzzled why all this section on line 364 exists. (In reply to Yan Vugenfirer from comment #8) > The file is not edited manually. This is how Visual Studio decided to change > it. I am puzzled why all this section on line 364 exists. Looks the section of #364 and #471 are dup . BTW .I saw 'rem call ..\tools\callVisualStudio.bat' in buildall.bat ,while the 'tools' should be replace to 'Tools' as there is no 'tools' folder (but looks windows is not sensitive to the characters case .) I check the buildall.bat and callVisualStudio.bat ,I can not find a way to prove it is compiled by vs 2013 Any idea how to verify it, thanks , Mike When the compilation runs, you can check devenv.exe process and verify its location. It should belong to VS2013. I tried using BuildAll.bat for both mm79 and mm 99 on win8.1 guest with *VS2012* installed , Both of the two builds can be compiled successfully and use the devenv belongs to vs2012 Any ideas about it ? the scripts can be used on vs2012 as well ? Thanks, Mike Inside of tools directory you have "callVisualStudio.bat" and "getVisualStudioCmdLine.vbs" - they should call correct VS according to the parameters passed from "buildall.bat": "call ..\tools\callVisualStudio.bat 12" - is VS2013. "call ..\tools\callVisualStudio.bat 11" - is VS2012. Best regards, Yan. (In reply to Yan Vugenfirer from comment #12) > Inside of tools directory you have "callVisualStudio.bat" and > "getVisualStudioCmdLine.vbs" - they should call correct VS according to the > parameters passed from "buildall.bat": > > "call ..\tools\callVisualStudio.bat 12" - is VS2013. > "call ..\tools\callVisualStudio.bat 11" - is VS2012. > Code check for buildall.bat in commit 1fe66b4c1ccc0ee0826330b778848a9fea700a5e ,it shows "call ..\tools\callVisualStudio.bat 11" Verified this issue on virtio-win-prewhql-87 src code , it shows "call ..\tools\callVisualStudio.bat 12" Based on above ,this issue has been fixed ald , Move status to verified Mike Move status to verified according to comment #13 This comment is used for testing python-bugzilla This status is changed by the scripts , change the status to Verified again Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHBA-2015-0289.html |