Bug 1051896

+++ This bug was initially created as a clone of Bug #1039631 +++

Description of problem:
When send invalid argument to setfacl, it should return EINVAL. But in glusterfs, it return 0.


Version-Release number of selected component (if applicable):
The gluster server:
1, build two gluster servers(ser0 and ser1) by use rhel-x86_64-server-6-rhs-2.1 channel in RHEL-6.4.
2, create bricks on ser0 and ser1, the bricks dir created on xfs filesystem.
3, create a gv0 volume by the above bricks, and start it.
----
[root@dhcp12-143 ~]# gluster volume info
 
Volume Name: gv0
Type: Distribute
Volume ID: 1a960657-bff3-43f2-b1a3-c6baf41d88ca
Status: Started
Number of Bricks: 2
Transport-type: tcp
Bricks:
Brick1: 10.66.86.68:/data/gluster/brick
Brick2: 10.66.12.143:/data/gluster/brick
----




How reproducible:
I find this problem by run posix compliance test,you can get the upstream source by:
git clone git://git.code.sf.net/p/ntfs-3g/pjd-fstest

Then mount the glusterfs by run:
mount -t glusterfs 10.66.86.68:/gv0 /mnt -o attribute-timeout=0,entry-timeout=0,acl

Then run the posix test:
prove ntfs-3g-pjd-fstest/tests/xacl/06.t

The failure messages:
ntfs-3g-pjd-fstest/tests/xacl/06.t (Wstat: 0 Tests: 42 Failed: 1)
  Failed test:  15

This mean this line run failed:
expect EINVAL setfacl ${d0}/${n1} m 'u::r,u::w,g::r--,o::r--'

There is no setfacl system call in linux, in posix compliance test the setfacl test is acl_set_file() test. Please refer to do_setfacl() function in ntfs-3g-pjd-fstest/fstest.c.

If you just use the setfacl command, you can't trigger this problem. So for test simply, I write a simple program which use acl_set_file() function.
If you don't want to use posix compliance test, you can use the program(setfacl_test.c) which I submit it in the attachment.

You can do the test like below:

Steps to Reproduce:
1. mount -t glusterfs 10.66.86.68:/gv0 /mnt -o attribute-timeout=0,acl

If you want to use the posix test:
2. cd /mnt; git clone git://git.code.sf.net/p/ntfs-3g/pjd-fstest
3. cd ntfs-3g-pjd-fstest/; make (maybe you need some build dependent packages)
4. prove ntfs-3g-pjd-fstest/tests/xacl/06.t

If you want to use the program which I submit to the attachment:
2. cd /mnt; wget the program
3. gcc -o setfacl_test setfacl_test -lacl (maybe you need libacl-devel and libacl packages)
4. touch foo
5. ./setfacl foo m 'u::r,u::w,g::r--,o::r--'
6. echo $?


Actual results:
If you use posix test:
Step#4 will get:
ntfs-3g-pjd-fstest/tests/xacl/06.t (Wstat: 0 Tests: 42 Failed: 1)
  Failed test:  15

If you use my program to test:
Step#5 will get nothing
Step#6 will get 0.



Expected results:
If you use posix test:
Step#4 will get:
ntfs-3g-pjd-fstest/tests/xacl/06.t .. ok     
All tests successful.

If you use my program to test:
Step#5 will get "do_setfacl failed: Invalid request code"
Step#6 will get 200. (I get 200 When I test, maybe different kernel will get different number for EINVAL, but it never be 0).



Additional info:

The xfs test successed.

--- Additional comment from Zorro Lang on 2013-12-09 11:31:03 EST ---

Notice that this bug can't be tested by setfacl command, you need to use acl_set_file function. So you can use posix-compliance-test or use the attachment "set acl test program".