Bug 1052859

Summary: Annoying dependency on Test::More
Product: [Fedora] Fedora Reporter: Mathieu Bridon <bochecha>
Component: perl-PlackAssignee: Ralf Corsepius <rc040203>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: perl-devel, rc040203
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: perl-Plack-1.0030-3.fc19 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-01-22 23:01:24 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Mathieu Bridon 2014-01-14 09:10:30 UTC
Description of problem:
The perl-Plack package requires Test::More.

Looking at the source code:

  $ grep -rI 'Test::More' .
  ./Makefile.PL:build_requires 'Test::More', 0.88;
  ./lib/Plack/Test/Suite.pm:use Test::More;
  ./lib/Plack/Test/Suite.pm:  use Test::More;
  ...

If I get this right, Plack::Test::Suite is not necessary to run a Plack web application, so perhaps it could be split into a subpackage?

Version-Release number of selected component (if applicable):
This applies to all branches of Fedora, not just Rawhide.

Comment 1 Ralf Corsepius 2014-01-14 11:12:55 UTC
Thanks for the report - I am inclined to agree and will look into it.

Comment 2 Fedora Update System 2014-01-15 14:36:43 UTC
perl-Plack-1.0030-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/perl-Plack-1.0030-2.fc20

Comment 3 Fedora Update System 2014-01-15 14:36:54 UTC
perl-Plack-1.0030-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/perl-Plack-1.0030-2.fc19

Comment 4 Ralf Corsepius 2014-01-15 14:48:52 UTC
I've split put all of */Plack/Test* into a separate perl-Plack-Test subpackage. It's not quite what you initially asked for, but as a side-effect also resolves your issue.

Comment 5 Mathieu Bridon 2014-01-15 16:07:53 UTC
Ah, I might not have been clear then, because looking at:
http://pkgs.fedoraproject.org/cgit/perl-Plack.git/commit/?id=0ff72a2e42d227cf1b935f40cd5cfa3d99bc2190

This is exactly what I expected. :)

Thanks a lot for doing this so quickly Ralf!

Comment 6 Fedora Update System 2014-01-16 06:59:09 UTC
Package perl-Plack-1.0030-2.fc19:
* should fix your issue,
* was pushed to the Fedora 19 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing perl-Plack-1.0030-2.fc19'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-0893/perl-Plack-1.0030-2.fc19
then log in and leave karma (feedback).

Comment 7 Mathieu Bridon 2014-01-16 08:14:14 UTC
So, in your git commit, I see:

   # Don't package
  +%exclude %{perl_vendorlib}/auto/share/dist/Plack/#foo

Unfortunately, because you don't also exclude this file from the Test subpackage, then it ends up packaged in there:

  $ rpm -qlp http://kojipkgs.fedoraproject.rg/packages/perl-Plack/1.0030/2.fc21/noarch/perl-Plack-Test-1.0030-2.fc21.noarch.rpm | grep foo
  /usr/share/perl5/vendor_perl/auto/share/dist/Plack/#foo

It probably doesn't matter much, but should it be excluded in both then?

Comment 8 Ralf Corsepius 2014-01-16 08:41:55 UTC
(In reply to Mathieu Bridon from comment #7)

> It probably doesn't matter much, but should it be excluded in both then?
Yep, this is a mistake.

It had been excluded before and intended not to package it at all.

Comment 9 Fedora Update System 2014-01-16 13:23:18 UTC
perl-Plack-1.0030-3.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/perl-Plack-1.0030-3.fc19

Comment 10 Fedora Update System 2014-01-16 13:23:26 UTC
perl-Plack-1.0030-3.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/perl-Plack-1.0030-3.fc20

Comment 11 Fedora Update System 2014-01-22 23:01:24 UTC
perl-Plack-1.0030-3.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 12 Fedora Update System 2014-01-25 02:26:29 UTC
perl-Plack-1.0030-3.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.