Bug 1052936

Summary: Unable to complete install: 'internal error Missing source path attribute for char device'
Product: [Fedora] Fedora Reporter: Netbulae <info>
Component: virt-managerAssignee: Cole Robinson <crobinso>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: unspecified    
Version: 20CC: acathrow, berrange, crobinso, e.minguez, jdenemar, trailtotale, virt-maint
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: virt-manager-1.0.0-3.fc20 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-03-04 06:45:52 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Netbulae 2014-01-14 13:03:04 UTC
Description of problem:
I create a new VM in virt-manager

Version-Release number of selected component (if applicable):
Server:
Centos 6.5
libvirt-0.10.2-29.el6_5.2.x86_64

Client:
Fedora 20
virt-manager-0.10.0-5.git1ffcc0cc.fc20.noarch

How reproducible:
Everytime

Steps to Reproduce:
1. Create VM with virt-manager
2. Customize install and choose virtio
3. Start install and libvirtd crashes

Actual results:
Unable to complete install: 'internal error Missing source path attribute for char device'

Traceback (most recent call last):
  File "/usr/share/virt-manager/virtManager/asyncjob.py", line 91, in cb_wrapper
    callback(asyncjob, *args, **kwargs)
  File "/usr/share/virt-manager/virtManager/create.py", line 1959, in do_install
    guest.start_install(meter=meter)
  File "/usr/share/virt-manager/virtinst/guest.py", line 389, in start_install
    noboot)
  File "/usr/share/virt-manager/virtinst/guest.py", line 454, in _create_guest
    dom = self.conn.createLinux(start_xml or final_xml, 0)
  File "/usr/lib64/python2.7/site-packages/libvirt.py", line 2897, in createLinux
    if ret is None:raise libvirtError('virDomainCreateLinux() failed', conn=self)
libvirtError: internal error Missing source path attribute for char device



Expected results:


Additional info:

Comment 1 Netbulae 2014-01-14 13:15:50 UTC
After removing the device "Channel qemu-ga" I got the install working.

Comment 3 Jiri Denemark 2014-01-15 12:44:35 UTC
While new virt-manager takes advantage of libvirt not requiring source path attribute for char devices, libvirt in RHEL is older and still requires the source path to be used. It was made optional upstream by commit v1.0.5-3-g297c99a, that is, it is present since libvirt-1.0.6. As a workaround, create a VM without qemu-ga channel and add it manually including the source path using virsh edit.

Comment 4 Jiri Denemark 2014-01-15 13:08:28 UTC
That said, it's a client's fault to provide an XML configuration that is not supported by older libvirt. Unfortunately, this is not something that virt-manager can easily probe for. A possible solution for virt-manager is to always provide source path for qemu-ga channels even though newer libvirt does not need it or declare qemu-ga channel to be supported only with libvirt-1.0.6 and newer.

Comment 5 Cole Robinson 2014-01-17 23:57:49 UTC
Fixed upstream by:

commit e7ed161f5aff09f48c5d0bab14f6116a8174d231
Author: Cole Robinson <crobinso>
Date:   Tue Nov 19 17:00:39 2013 -0500

    support: Use libvirt daemon version correctly
    
    It should be the reference version for all libvirt checks if it exists.
    
    Fixes AUTOSOCKET check for a remote RHEL6 hypervisor for example.

Comment 6 Fedora Update System 2014-02-15 00:56:11 UTC
virt-manager-1.0.0-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/virt-manager-1.0.0-1.fc20

Comment 7 Fedora Update System 2014-02-18 23:02:50 UTC
virt-manager-1.0.0-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/virt-manager-1.0.0-2.fc20

Comment 8 Fedora Update System 2014-02-22 00:37:59 UTC
Package virt-manager-1.0.0-2.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing virt-manager-1.0.0-2.fc20'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-2789/virt-manager-1.0.0-2.fc20
then log in and leave karma (feedback).

Comment 9 Netbulae 2014-02-26 09:44:12 UTC
Works like a charm, thanks!

Comment 10 Fedora Update System 2014-02-28 18:24:24 UTC
virt-manager-1.0.0-3.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/virt-manager-1.0.0-3.fc20

Comment 11 Fedora Update System 2014-03-04 06:45:52 UTC
virt-manager-1.0.0-3.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.