Bug 1054422

Summary: provide astyle shared library
Product: [Fedora] Fedora Reporter: Dan Horák <dan>
Component: astyleAssignee: Thomas Spura <tomspur>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: dan, metherid, mtasaka, tomspur
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: astyle-2.04-3.fc21 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 1050825 Environment:
Last Closed: 2014-04-12 11:38:02 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1050825    
Attachments:
Description Flags
starting point for building astyle shared library none

Description Dan Horák 2014-01-16 19:15:11 UTC 
+++ This bug was initially created as a clone of Bug #1050825 +++

Description of problem:

astyle is available as a separate package in Fedora but Code::Blocks appears to bundle its own copy.  please unbundle and depend on the astyle package instead.

--- Additional comment from Dan Horák on 2014-01-09 04:15:45 EST ---

While the bundled astyle code is likely even not forked, there is no standlone astyle library that could be used for C::B.

--- Additional comment from Rahul Sundaram on 2014-01-09 04:22:58 EST ---

I am not sure about the veracity of that assertion given that there is a standalone astyle package in Fedora but in any case, if you need an exception to the fedora packaging guidelines, you need to file a ticket with FPC.  I have done so now

https://fedorahosted.org/fpc/ticket/380

--- Additional comment from Dominik 'Rathann' Mierzejewski on 2014-01-16 13:32:57 EST ---

(In reply to Dan Horák from comment #1)
> While the bundled astyle code is likely even not forked, there is no
> standlone astyle library that could be used for C::B.

I'm sorry, but this is simply wrong. astyle upstream explicitly supports building a shared library, so it's a bug in astyle package that it doesn't provide it.

http://astyle.sourceforge.net/install.html#_GCC_Compiler

Please open a bug against astyle and block on it instead of closing.

--- Additional comment from Dominik 'Rathann' Mierzejewski on 2014-01-16 13:35:17 EST ---

Here's a proof-of-concept patch against current rawhide astyle.spec. The shared library needs to have its SONAME set before being consumable properly, but that's an issue for astyle upstream.
Comment 1 Dan Horák 2014-01-16 20:42:45 UTC 
Created attachment 851260 [details]
starting point for building astyle shared library

cloned from https://bugzilla.redhat.com/attachment.cgi?id=851219 (bug 1050825)
Comment 2 Thomas Spura 2014-01-17 09:16:39 UTC 
I made local modifications and am having a look at the astyle library.

I'd like to wait a few days for a response of astyle's upstream before adding a SONAME library by myself:
https://sourceforge.net/p/astyle/bugs/264/
Comment 3 Thomas Spura 2014-01-27 13:25:45 UTC 
Built in rawhide:
http://koji.fedoraproject.org/koji/taskinfo?taskID=6458240

Please try it and let me know, if it works and for which branches you need an astyle shared library.
Comment 4 Dan Horák 2014-03-20 11:46:14 UTC 
I'm working on it, seems C::B guys forked the library a bit (as usually :-().