Bug 1054479

Summary:	virt-login-shell busted after fix for CVE-2013-4400
Product:	[Fedora] Fedora	Reporter:	Cole Robinson <crobinso>
Component:	libvirt	Assignee:	Libvirt Maintainers <libvirt-maint>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	20	CC:	berrange, clalancette, itamar, jforbes, jyang, laine, libvirt-maint, veillard, virt-maint
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	libvirt-1.1.3.3-1.fc20	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-01-21 05:56:02 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Cole Robinson 2014-01-16 22:13:57 UTC

From bug #1025685:

virt-login-shell broke after

commit b7fcc799ad5d8f3e55b89b94e599903e3c092467
Author: Daniel P. Berrange <berrange>
Date:   Wed Oct 9 15:14:34 2013 +0100

    Close all non-stdio FDs in virt-login-shell (CVE-2013-4400)
    
    We don't want to inherit any FDs in the new namespace
    except for the stdio FDs. Explicitly close them all,
    just in case some do not have the close-on-exec flag
    set.
    
    Signed-off-by: Daniel P. Berrange <berrange>

because that accidentally closed all the namespace fds such that the program always fails.



I believe this was fixed by;

commit 3d007cb5f892bb9fd3f6efac6dc89a8e00e94922
Author: Eric Blake <eblake>
Date:   Mon Dec 23 10:15:48 2013 -0700

    virt-login-shell: fix regressions in behavior

Comment 1 Fedora Update System 2014-01-17 14:04:54 UTC

libvirt-1.1.3.3-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/libvirt-1.1.3.3-1.fc20

Comment 2 Fedora Update System 2014-01-18 04:22:22 UTC

Package libvirt-1.1.3.3-1.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing libvirt-1.1.3.3-1.fc20'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-1042/libvirt-1.1.3.3-1.fc20
then log in and leave karma (feedback).

Comment 3 Fedora Update System 2014-01-21 05:56:02 UTC

libvirt-1.1.3.3-1.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.