Bug 1054695

Summary: (6.4.0) Cli gui is having AS7 icon
Product: [JBoss] JBoss Enterprise Application Platform 6 Reporter: Petr Kremensky <pkremens>
Component: CLIAssignee: Panagiotis Sotiropoulos <psotirop>
Status: CLOSED CURRENTRELEASE QA Contact: Nikoleta Hlavickova <nziakova>
Severity: low Docs Contact:
Priority: unspecified    
Version: 6.2.0CC: bbaranow, brian.stansberry, kkhan, psotirop, rsvoboda
Target Milestone: DR5   
Target Release: EAP 6.4.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1142291 (view as bug list) Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1065955, 1142291    
Attachments:
Description Flags
Proposed image in PR none

Description Petr Kremensky 2014-01-17 10:00:08 UTC 
Description of problem:
 CLI running in gui mode has icon taken from AS7

Version-Release number of selected component (if applicable):
 EAP 6.2.0.GA

How reproducible:
 Always

Steps to Reproduce:
 1. Start eap
 2. Run: ./jboss-cli.sh --gui
 3. Check some task bar of your system

Actual results:
 Icon of running cli is taken from AS7.

Expected results:
 There should be some EAP related icon.

Additional info:
 Please choose more specific component if needed as there is no Branding one.
Comment 1 Alexey Loubyansky 2014-02-24 12:39:57 UTC 
Not sure how to fix it better: having two different icons for wildfly and eap or having a single common one. I guess, I'd prefer having a common one.
Comment 2 Rostislav Svoboda 2014-03-05 08:33:47 UTC 
Hi Alexey.

I think two different icons will be needed. Default for project, another for EAP.
You can check product.conf file, in WF there is no such file, it's only in products as far I know. The same system (product.conf file) is used by webconsole to switch branding.

[rsvoboda@steve 630DR1]$ cat jboss-eap-6.3/bin/product.conf 
# JBoss product branding configuration
slot=eap
Comment 5 Brian Stansberry 2014-09-16 13:42:09 UTC 
The CLI has no access to product.conf as it's a remote tool. IMO this should just be a different file in the EAP source vs upstream source and we fix it again for EAP 7 when we rebase EAP from WildFly.
Comment 8 Panagiotis Sotiropoulos 2014-10-01 15:38:20 UTC 
PR sent: https://github.com/jbossas/jboss-eap/pull/1750
Comment 9 Kabir Khan 2014-10-01 20:46:14 UTC 
Created attachment 943200 [details]
Proposed image in PR

This is the image that is proposed in https://github.com/jbossas/jboss-eap/pull/1750
Comment 10 Petr Kremensky 2014-10-17 14:16:26 UTC 
@Kabir,
I see that image used in https://github.com/jbossas/jboss-eap/pull/1750 (and also in https://github.com/jbossas/jboss-eap/pull/1748 - BZ1142291) is not the one from attachment 943200 [details], it is this one instead https://github.com/panossot/jboss-eap/blob/8cb70bb475d96ef0ee730d63f302f23879bd07c5/cli/src/main/resources/icon/Shadowman_RGB_64x64.png
Comment 11 Kabir Khan 2014-10-17 14:32:27 UTC 
Petr,

https://github.com/jbossas/jboss-eap/blob/6.x/cli/src/main/resources/icon/Shadowman_RGB_64x64.png uses the correct image. Catherine Robson supplied the Shadowman_RGB_64x64.png image used in the 6.x branch's PR https://github.com/jbossas/jboss-eap/pull/1750 (originally it had the image in https://bugzilla.redhat.com/attachment.cgi?id=943200, I used used it to upload the image for Dion since I did not know her email address). So 6.x is fine.

So, the 6.3.x PR https://github.com/jbossas/jboss-eap/pull/1748 used the wrong image, and should use the same as in 6.x.
Comment 12 Petr Kremensky 2014-10-17 14:54:11 UTC 
Now I am confused even more :), but from what you say I assume that the shadowman icon is the correct one.

Verified on EAP 6.4.0.DR5.