Bug 1054905

Summary: Add data on WHQL drivers
Product: Red Hat Enterprise Linux 8 Reporter: Zeeshan Ali <zeenix>
Component: virtio-winAssignee: Fabiano Fidêncio <fidencio>
virtio-win sub component: distribution QA Contact: lijin <lijin>
Status: CLOSED ERRATA Docs Contact:
Severity: unspecified    
Priority: unspecified CC: ailan, cfergeau, ddepaula, fidencio, lijin, mclasen, ptoscano, tpelka, vbenes, vbudikov, vrozenfe
Version: 8.1Flags: pm-rhel: mirror+
Target Milestone: rc   
Target Release: 8.1   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: virtio-win-1.9.14-1.el8 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-11-04 04:17:35 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1032520    
Bug Blocks:    

Description Zeeshan Ali 2014-01-17 17:59:51 UTC
Once virtio-win package provides unpacked driver files, we should provide data on them.

See bug#1032520 and especially this comment for details:

https://bugzilla.redhat.com/show_bug.cgi?id=1032520#c14

Comment 2 RHEL Program Management 2014-03-22 06:11:57 UTC
This request was not resolved in time for the current release.
Red Hat invites you to ask your support representative to
propose this request, if still desired, for consideration in
the next release of Red Hat Enterprise Linux.

Comment 8 Fabiano Fidêncio 2020-05-30 09:31:23 UTC
I'm moving this one to virtio-win as the data must come from them.
osinfo-db and libosinfo will be prepared for dealing with the info.

I'm keeping this assigned to me as I plan to submit the patches for this soon.

Comment 11 Danilo de Paula 2020-06-23 20:15:49 UTC
Dropping my NEED_INFO as Vadim is taking care of this now.

Comment 15 lijin 2020-06-29 01:07:45 UTC
Check with latest virtio-win-1.9.12-1.el8.noarch(rhel8.2.1 package)
tree -f | grep virtio-win-pre-installable-drivers-win
|           |   `-- ./osinfo-db/os/microsoft.com/win-10.d/virtio-win-pre-installable-drivers-win-10.xml
|           |   `-- ./osinfo-db/os/microsoft.com/win-7.d/virtio-win-pre-installable-drivers-win-7.xml
|           |   `-- ./osinfo-db/os/microsoft.com/win-8.1.d/virtio-win-pre-installable-drivers-win-8.1.xml
|               `-- ./osinfo-db/os/microsoft.com/win-8.d/virtio-win-pre-installable-drivers-win-8.xml


Can we set this bug as verified?

And do you want to target it for rhel8.2.1 instead of rhel8.3.0?

Comment 17 Fabiano Fidêncio 2020-07-01 14:19:07 UTC
(In reply to lijin from comment #15)
> Check with latest virtio-win-1.9.12-1.el8.noarch(rhel8.2.1 package)
> tree -f | grep virtio-win-pre-installable-drivers-win
> |           |   `--
> ./osinfo-db/os/microsoft.com/win-10.d/virtio-win-pre-installable-drivers-win-
> 10.xml
> |           |   `--
> ./osinfo-db/os/microsoft.com/win-7.d/virtio-win-pre-installable-drivers-win-
> 7.xml
> |           |   `--
> ./osinfo-db/os/microsoft.com/win-8.1.d/virtio-win-pre-installable-drivers-
> win-8.1.xml
> |               `--
> ./osinfo-db/os/microsoft.com/win-8.d/virtio-win-pre-installable-drivers-win-
> 8.xml
> 
> 
> Can we set this bug as verified?

That should be good enough to be mark as verified.

Comment 25 lijin 2020-07-06 03:18:10 UTC
Change status to verified according to comment#15, comment#16, comment#17

Comment 44 Vadim Rozenfeld 2020-09-07 03:43:48 UTC
Just created and added new virtio-win rpm 
https://brewweb.engineering.redhat.com/brew/buildinfo?buildID=1311227
to virtio-win 8.3.0 errata https://errata.devel.redhat.com/advisory/58297

Please give it a try and let me know if it works as expected.

Best regards,
Vadim.

Comment 45 lijin 2020-09-07 05:33:22 UTC
Following is the result with virtio-win-1.9.13-1.el8.noarch, I will set this bz as verified if Fabian has no objection.

[root@dell-per730-08 share]# tree -f | grep virtio-win-pre-installable-drivers-win
|           |   `-- ./osinfo-db/os/microsoft.com/win-10.d/virtio-win-pre-installable-drivers-win-10.xml
|           |   `-- ./osinfo-db/os/microsoft.com/win-7.d/virtio-win-pre-installable-drivers-win-7.xml
|           |   `-- ./osinfo-db/os/microsoft.com/win-8.1.d/virtio-win-pre-installable-drivers-win-8.1.xml
|               `-- ./osinfo-db/os/microsoft.com/win-8.d/virtio-win-pre-installable-drivers-win-8.xml

Comment 46 Fabiano Fidêncio 2020-09-07 07:06:16 UTC
(In reply to lijin from comment #45)
> Following is the result with virtio-win-1.9.13-1.el8.noarch, I will set this
> bz as verified if Fabian has no objection.
> 
> [root@dell-per730-08 share]# tree -f | grep
> virtio-win-pre-installable-drivers-win
> |           |   `--
> ./osinfo-db/os/microsoft.com/win-10.d/virtio-win-pre-installable-drivers-win-
> 10.xml
> |           |   `--
> ./osinfo-db/os/microsoft.com/win-7.d/virtio-win-pre-installable-drivers-win-
> 7.xml
> |           |   `--
> ./osinfo-db/os/microsoft.com/win-8.1.d/virtio-win-pre-installable-drivers-
> win-8.1.xml
> |               `--
> ./osinfo-db/os/microsoft.com/win-8.d/virtio-win-pre-installable-drivers-win-
> 8.xml

It cannot be marked as VERIFIED as it does not include https://github.com/virtio-win/virtio-win-pkg-scripts/pull/33, which is needed for osinfo-db.

Comment 47 Fabiano Fidêncio 2020-09-07 07:20:12 UTC
(In reply to Fabiano Fidêncio from comment #46)
> (In reply to lijin from comment #45)
> > Following is the result with virtio-win-1.9.13-1.el8.noarch, I will set this
> > bz as verified if Fabian has no objection.
> > 
> > [root@dell-per730-08 share]# tree -f | grep
> > virtio-win-pre-installable-drivers-win
> > |           |   `--
> > ./osinfo-db/os/microsoft.com/win-10.d/virtio-win-pre-installable-drivers-win-
> > 10.xml
> > |           |   `--
> > ./osinfo-db/os/microsoft.com/win-7.d/virtio-win-pre-installable-drivers-win-
> > 7.xml
> > |           |   `--
> > ./osinfo-db/os/microsoft.com/win-8.1.d/virtio-win-pre-installable-drivers-
> > win-8.1.xml
> > |               `--
> > ./osinfo-db/os/microsoft.com/win-8.d/virtio-win-pre-installable-drivers-win-
> > 8.xml
> 
> It cannot be marked as VERIFIED as it does not include
> https://github.com/virtio-win/virtio-win-pkg-scripts/pull/33, which is
> needed for osinfo-db.

Also, qxldod files are not present in expected location. Considering this is intentional, I've opened the following PR:
https://github.com/virtio-win/virtio-win-pkg-scripts/pull/34

Comment 48 Fabiano Fidêncio 2020-09-07 07:33:48 UTC
Also, I've provided a patch changing the data osinfo-db for the w8, w8.1, and w10 so it uses the vfio files as virtiofs instead of 9p.
Please, check: https://github.com/virtio-win/virtio-win-pkg-scripts/pull/35

Comment 50 Vadim Rozenfeld 2020-09-07 07:53:44 UTC
(In reply to Fabiano Fidêncio from comment #46)
> (In reply to lijin from comment #45)
> > Following is the result with virtio-win-1.9.13-1.el8.noarch, I will set this
> > bz as verified if Fabian has no objection.
> > 
> > [root@dell-per730-08 share]# tree -f | grep
> > virtio-win-pre-installable-drivers-win
> > |           |   `--
> > ./osinfo-db/os/microsoft.com/win-10.d/virtio-win-pre-installable-drivers-win-
> > 10.xml
> > |           |   `--
> > ./osinfo-db/os/microsoft.com/win-7.d/virtio-win-pre-installable-drivers-win-
> > 7.xml
> > |           |   `--
> > ./osinfo-db/os/microsoft.com/win-8.1.d/virtio-win-pre-installable-drivers-
> > win-8.1.xml
> > |               `--
> > ./osinfo-db/os/microsoft.com/win-8.d/virtio-win-pre-installable-drivers-win-
> > 8.xml
> 
> It cannot be marked as VERIFIED as it does not include
> https://github.com/virtio-win/virtio-win-pkg-scripts/pull/33, which is
> needed for osinfo-db.

My bad. Will include it to the next build later this week.

Comment 51 Vadim Rozenfeld 2020-09-07 07:57:00 UTC
(In reply to Fabiano Fidêncio from comment #47)
> (In reply to Fabiano Fidêncio from comment #46)
> > (In reply to lijin from comment #45)
> > > Following is the result with virtio-win-1.9.13-1.el8.noarch, I will set this
> > > bz as verified if Fabian has no objection.
> > > 
> > > [root@dell-per730-08 share]# tree -f | grep
> > > virtio-win-pre-installable-drivers-win
> > > |           |   `--
> > > ./osinfo-db/os/microsoft.com/win-10.d/virtio-win-pre-installable-drivers-win-
> > > 10.xml
> > > |           |   `--
> > > ./osinfo-db/os/microsoft.com/win-7.d/virtio-win-pre-installable-drivers-win-
> > > 7.xml
> > > |           |   `--
> > > ./osinfo-db/os/microsoft.com/win-8.1.d/virtio-win-pre-installable-drivers-
> > > win-8.1.xml
> > > |               `--
> > > ./osinfo-db/os/microsoft.com/win-8.d/virtio-win-pre-installable-drivers-win-
> > > 8.xml
> > 
> > It cannot be marked as VERIFIED as it does not include
> > https://github.com/virtio-win/virtio-win-pkg-scripts/pull/33, which is
> > needed for osinfo-db.
> 
> Also, qxldod files are not present in expected location. Considering this is
> intentional, I've opened the following PR:
> https://github.com/virtio-win/virtio-win-pkg-scripts/pull/34

I think Win10 qxldod binaries can be included into iso. Let me check it.

Comment 52 Vadim Rozenfeld 2020-09-07 08:04:33 UTC
(In reply to Fabiano Fidêncio from comment #48)
> Also, I've provided a patch changing the data osinfo-db for the w8, w8.1,
> and w10 so it uses the vfio files as virtiofs instead of 9p.
> Please, check: https://github.com/virtio-win/virtio-win-pkg-scripts/pull/35

Yep, you are right, 

      <device id="http://pcisig.com/pci/1af4/1009"/>
      <device id="http://pcisig.com/pci/1af4/1049"/>

need to be replaced with 

       <device id="http://pcisig.com/pci/1af4/105a"/>

I will make sure that it will be fixed in next rpm build.

Best,
Vadim.

Comment 55 lijin 2020-09-14 06:25:45 UTC
Check on latest virtio-win-1.9.14-0.el8.noarch

https://github.com/virtio-win/virtio-win-pkg-scripts/pull/33, https://github.com/virtio-win/virtio-win-pkg-scripts/pull/34 and https://github.com/virtio-win/virtio-win-pkg-scripts/pull/35 are included.

1. files are under /usr/share/osinfo
[root@dell-per730-08 share]#  tree -f | grep virtio-win-pre-installable-drivers-win
|   |   |   |   `-- ./osinfo/os/microsoft.com/win-10.d/virtio-win-pre-installable-drivers-win-10.xml
|   |   |   |   `-- ./osinfo/os/microsoft.com/win-7.d/virtio-win-pre-installable-drivers-win-7.xml
|   |   |   |   `-- ./osinfo/os/microsoft.com/win-8.1.d/virtio-win-pre-installable-drivers-win-8.1.xml
|   |   |   |   `-- ./osinfo/os/microsoft.com/win-8.d/virtio-win-pre-installable-drivers-win-8.xml


2.the location in w7 xml is NOT correct: the location should be file:///usr/share/virtio-win/drivers/by-os/amd64/w7/ instead of file:///usr/share/virtio-win/driver/by-os/amd64/w7/

[root@dell-per730-08 share]# cat  ./osinfo/os/microsoft.com/win-7.d/virtio-win-pre-installable-drivers-win-7.xml
...
<driver signed="true" pre-installable="true" location="file:///usr/share/virtio-win/driver/by-os/amd64/w7/" arch="x86_64">

Vadim,

Could you help to have a check?

Thanks

Comment 56 Fabiano Fidêncio 2020-09-14 06:46:39 UTC
(In reply to lijin from comment #55)
> Check on latest virtio-win-1.9.14-0.el8.noarch
> 
> https://github.com/virtio-win/virtio-win-pkg-scripts/pull/33,
> https://github.com/virtio-win/virtio-win-pkg-scripts/pull/34 and
> https://github.com/virtio-win/virtio-win-pkg-scripts/pull/35 are included.
> 
> 1. files are under /usr/share/osinfo
> [root@dell-per730-08 share]#  tree -f | grep
> virtio-win-pre-installable-drivers-win
> |   |   |   |   `--
> ./osinfo/os/microsoft.com/win-10.d/virtio-win-pre-installable-drivers-win-10.
> xml
> |   |   |   |   `--
> ./osinfo/os/microsoft.com/win-7.d/virtio-win-pre-installable-drivers-win-7.
> xml
> |   |   |   |   `--
> ./osinfo/os/microsoft.com/win-8.1.d/virtio-win-pre-installable-drivers-win-8.
> 1.xml
> |   |   |   |   `--
> ./osinfo/os/microsoft.com/win-8.d/virtio-win-pre-installable-drivers-win-8.
> xml

This part is correct.

> 
> 
> 2.the location in w7 xml is NOT correct: the location should be
> file:///usr/share/virtio-win/drivers/by-os/amd64/w7/ instead of
> file:///usr/share/virtio-win/driver/by-os/amd64/w7/
> 
> [root@dell-per730-08 share]# cat 
> ./osinfo/os/microsoft.com/win-7.d/virtio-win-pre-installable-drivers-win-7.
> xml
> ...
> <driver signed="true" pre-installable="true"
> location="file:///usr/share/virtio-win/driver/by-os/amd64/w7/" arch="x86_64">
> 
> Vadim,
> 
> Could you help to have a check?

I'm not Vadim, but I can confirm the second part is wrong and it's my fault.
I'm sorry, it was a typo from my side and I've opened a pull-request fixing it: https://github.com/virtio-win/virtio-win-pkg-scripts/pull/36

Comment 57 Vadim Rozenfeld 2020-09-14 07:56:59 UTC
(In reply to Fabiano Fidêncio from comment #56)
> (In reply to lijin from comment #55)
> > Check on latest virtio-win-1.9.14-0.el8.noarch
> > 
> > https://github.com/virtio-win/virtio-win-pkg-scripts/pull/33,
> > https://github.com/virtio-win/virtio-win-pkg-scripts/pull/34 and
> > https://github.com/virtio-win/virtio-win-pkg-scripts/pull/35 are included.
> > 
> > 1. files are under /usr/share/osinfo
> > [root@dell-per730-08 share]#  tree -f | grep
> > virtio-win-pre-installable-drivers-win
> > |   |   |   |   `--
> > ./osinfo/os/microsoft.com/win-10.d/virtio-win-pre-installable-drivers-win-10.
> > xml
> > |   |   |   |   `--
> > ./osinfo/os/microsoft.com/win-7.d/virtio-win-pre-installable-drivers-win-7.
> > xml
> > |   |   |   |   `--
> > ./osinfo/os/microsoft.com/win-8.1.d/virtio-win-pre-installable-drivers-win-8.
> > 1.xml
> > |   |   |   |   `--
> > ./osinfo/os/microsoft.com/win-8.d/virtio-win-pre-installable-drivers-win-8.
> > xml
> 
> This part is correct.
> 
> > 
> > 
> > 2.the location in w7 xml is NOT correct: the location should be
> > file:///usr/share/virtio-win/drivers/by-os/amd64/w7/ instead of
> > file:///usr/share/virtio-win/driver/by-os/amd64/w7/
> > 
> > [root@dell-per730-08 share]# cat 
> > ./osinfo/os/microsoft.com/win-7.d/virtio-win-pre-installable-drivers-win-7.
> > xml
> > ...
> > <driver signed="true" pre-installable="true"
> > location="file:///usr/share/virtio-win/driver/by-os/amd64/w7/" arch="x86_64">
> > 
> > Vadim,
> > 
> > Could you help to have a check?
> 
> I'm not Vadim, but I can confirm the second part is wrong and it's my fault.
> I'm sorry, it was a typo from my side and I've opened a pull-request fixing
> it: https://github.com/virtio-win/virtio-win-pkg-scripts/pull/36

That's fine. Will be included into next rpm build.

Comment 61 lijin 2020-09-18 01:26:09 UTC
Check with virtio-win-1.9.14-1.el8.noarch, all issues are resolved.
So set status to verified.

Comment 66 errata-xmlrpc 2020-11-04 04:17:35 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (virtio-win bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2020:4840