Bug 1055403

Summary: [engine-backend] Attaching a disk as active to a running VM (hotplug), is not blocked for an IDE disk interface
Product: [Retired] oVirt Reporter: Elad <ebenahar>
Component: ovirt-engine-coreAssignee: Daniel Erez <derez>
Status: CLOSED CURRENTRELEASE QA Contact: Aharon Canan <acanan>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 3.4CC: acanan, acathrow, amureini, derez, gklein, iheim, lpeer, Rhev-m-bugs, scohen, tnisan, yeylon
Target Milestone: ---   
Target Release: 3.4.0   
Hardware: x86_64   
OS: Unspecified   
Whiteboard: storage
Fixed In Version: ovirt-3.4.0-beta2 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-03-31 12:33:29 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
engine.log and screenshot
none
logs none

Description Elad 2014-01-20 07:48:18 UTC
Created attachment 852641 [details]
engine.log and screenshot

Description of problem:
Engine does not block user from adding a disk with IDE interface, as active, to a running VM. 

Version-Release number of selected component (if applicable):
ovirt-3.4.0-alpha1
ovirt-engine-3.4.0-0.2.master.20140106180914.el6.noarch

How reproducible:
Always

Steps to Reproduce:
1. create a VM and install OS (RHEL6.X/Win7/Win8/WinServer2008)
2. attach a second disk, with IDE interface, to the VM (while the VM is in 'Up' state


Actual results:
Engine allows user to hotplug an IDE disk.
The operation fails with:

2014-01-20 09:42:48,488 WARN  [org.ovirt.engine.core.bll.HotPlugDiskToVmCommand] (org.ovirt.thread.pool-6-thread-44) [50371da] CanDoAction of action HotPlugDiskToVm failed. Reasons:VAR__ACTION__HOT_PLUG,VAR__TYPE__VM_DISK,ACTION_TYPE_FAILED_GUEST_OS_VERSION_IS_NOT_SUPPORTED

Expected results:
Engine should block user from adding a disk with unsupported disk inteface type as active to a running VM. 

Additional info:
engine.log and screenshot

Comment 1 Sandro Bonazzola 2014-02-07 11:20:25 UTC
Fixes should be in ovirt-3.4.0-beta2. Assignee please check.

Comment 2 Leonid Natapov 2014-02-16 11:40:44 UTC
3.4.0-0.7.beta2.el6. fixed.

Comment 3 Aharon Canan 2014-03-06 09:25:27 UTC
Adding IDE as active to running VM is still an option
the disk will be created but will be deactivated

We need to block the option, 
as right now we are able to ask it to be active, and doing it without activation, only creation.

Comment 4 Aharon Canan 2014-03-06 09:25:55 UTC
Created attachment 871281 [details]
logs

Comment 5 Sandro Bonazzola 2014-03-31 12:33:29 UTC
this is an automated message: moving to Closed CURRENT RELEASE since oVirt 3.4.0 has been released