Bug 1055441

Summary: [NetworkLabels] Host nics labels are being deleted when setup networks api is called
Product: [Retired] oVirt Reporter: Moti Asayag <masayag>
Component: ovirt-engine-apiAssignee: Moti Asayag <masayag>
Status: CLOSED CURRENTRELEASE QA Contact: Martin Pavlik <mpavlik>
Severity: high Docs Contact:
Priority: high    
Version: 3.4CC: acathrow, gklein, iheim, mpavlik, myakove, yeylon
Target Milestone: ---Keywords: Triaged
Target Release: 3.4.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: network
Fixed In Version: ovirt-3.4.0-beta2 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-03-31 12:27:35 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1024889    

Description Moti Asayag 2014-01-20 09:32:17 UTC
Description of problem:
The network labels on nic level are being added via the api:
/api/hosts/{host:id}/nics/{nic:id}/labels

When a setup networks command is sent via:
/api/hosts/{host:id}/nics/setupnetworks

The former labels are being removed from the nics.

How reproducible:
always

Steps to Reproduce:
1. Label a nic (via UI or REST)
2. POST a /api/hosts/{host:id}/nics/setupnetworks 

Actual results:
All the labels are being cleared from the host's nics.

Expected results:
The labels should be preserved

Additional info:
The setup networks api doesn't use the patch mechanism to preserve any interface property that wasn't sent by the user. Instead, it creates a new interface entity and set only the provided nic attributes.
There should be a 'labels only' patch to preserve the nic labels.

Comment 1 Martin Pavlik 2014-02-17 14:58:54 UTC
works with  oVirt Engine Version: 3.4.0-0.7.beta2.el6

Comment 2 Sandro Bonazzola 2014-03-31 12:27:35 UTC
this is an automated message: moving to Closed CURRENT RELEASE since oVirt 3.4.0 has been released