Bug 1056191

Summary: kernel-PAE-modules-extra no longer provides kernel-modules-extra
Product: [Fedora] Fedora Reporter: Bruno Wolff III <bruno>
Component: gfs2-utilsAssignee: Steve Whitehouse <swhiteho>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: adas, agk, anprice, bmarzins, bruno, fdinitto, rpeterso, swhiteho
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-05-15 12:55:33 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1058331    
Attachments:
Description Flags
Patch to switch to using Requires on individual kernel modules none

Description Bruno Wolff III 2014-01-21 16:33:33 UTC 
Description of problem:
kernel-PAE-modules-extra no longer provides kernel-modules-extra, so that if you are using a PAE kernel, dlm will pull in non-PAE kernel packages.

Depending on the intent of requiring kernel-modules-extra, requiring installonlypkg(kernel-module) may be a suitable replacement.

Version-Release number of selected component (if applicable):
gfs2-utils-0:3.1.6-5.fc21.i686
Comment 1 Bruno Wolff III 2014-01-27 15:01:37 UTC 
installonlypkg(kernel-module) is not suitable as a requires replacement. We should wait for the *.ko autoprovides feature to make changes.
Comment 2 Bruno Wolff III 2014-05-14 15:20:07 UTC 
Auto provides for kernel modules has been enabled in kernel-3.15.0-0.rc5.git2.8.fc21, which should show up in tomorrow's rawhide barring unexpected issues.
You can now use contructs like kmod(joydev.ko) to make sure the joystick driver is installed, instead of requiring kernel-modules-extra. This also makes packages proofed against modules moving between kernel-modules and kernel-modules-extra.
Comment 3 Josh Boyer 2014-05-14 18:24:45 UTC 
Created attachment 895577 [details]
Patch to switch to using Requires on individual kernel modules

The attached patch switches gfs2-utils from using a Requires on kernel-modules-extra to using a requires on the individual kernel modules now that bug 1058331 is in rawhide.

Please review and let me know if it's OK to commit and build.
Comment 4 Andrew Price 2014-05-14 18:41:11 UTC 
(In reply to Josh Boyer from comment #3)
> Created attachment 895577 [details]
> Patch to switch to using Requires on individual kernel modules
> 
> The attached patch switches gfs2-utils from using a Requires on
> kernel-modules-extra to using a requires on the individual kernel modules
> now that bug 1058331 is in rawhide.
> 
> Please review and let me know if it's OK to commit and build.

It looks good but it will also need a "Requires: kmod(dlm.ko)" inside the same conditionals as the kmod(gfs2.ko) requirement. So:

  -%{?fedora:Requires: kernel-modules-extra}
  +%{?fedora:Requires: kmod(gfs2.ko) kmod(dlm.ko)}

Feel free to commit and build after adding that. And thanks!
Comment 5 Josh Boyer 2014-05-15 12:52:20 UTC 
(In reply to Andrew Price from comment #4)
> (In reply to Josh Boyer from comment #3)
> > Created attachment 895577 [details]
> > Patch to switch to using Requires on individual kernel modules
> > 
> > The attached patch switches gfs2-utils from using a Requires on
> > kernel-modules-extra to using a requires on the individual kernel modules
> > now that bug 1058331 is in rawhide.
> > 
> > Please review and let me know if it's OK to commit and build.
> 
> It looks good but it will also need a "Requires: kmod(dlm.ko)" inside the
> same conditionals as the kmod(gfs2.ko) requirement. So:
> 
>   -%{?fedora:Requires: kernel-modules-extra}
>   +%{?fedora:Requires: kmod(gfs2.ko) kmod(dlm.ko)}
> 
> Feel free to commit and build after adding that. And thanks!

OK, will do.  Thanks for the review.
Comment 6 Josh Boyer 2014-05-15 12:55:33 UTC 
Pushed and building now.  Thanks again.