Bug 1056335

Thanks to Gil for contributing an Ant-based build for Scalacheck, which is enabled by default in this new package:

Spec URL: http://freevariable.com/scalacheck/scalacheck.spec
SRPM URL: http://freevariable.com/scalacheck/scalacheck-1.11.3-1.fc19.src.rpm

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- This seems like a Java package, please install fedora-review-plugin-java to
  get additional checks


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. No licenses
     found. Please check the source files for licenses manually.
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Java:
[x]: Bundled jar/class files should be removed before build

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in scalacheck-
     javadoc
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: scalacheck-1.11.3-1.fc21.noarch.rpm
          scalacheck-javadoc-1.11.3-1.fc21.noarch.rpm
          scalacheck-1.11.3-1.fc21.src.rpm
scalacheck.noarch: W: summary-not-capitalized C property-based testing for Scala
scalacheck.noarch: W: spelling-error %description -l en_US runtime -> run time, run-time, rudiment
scalacheck.noarch: W: spelling-error %description -l en_US sbt -> tbs, st, set
scalacheck.src: W: summary-not-capitalized C property-based testing for Scala
scalacheck.src: W: spelling-error %description -l en_US runtime -> run time, run-time, rudiment
scalacheck.src: W: spelling-error %description -l en_US sbt -> tbs, st, set
scalacheck.src:118: W: macro-in-comment %check
scalacheck.src:19: W: mixed-use-of-spaces-and-tabs (spaces: line 7, tab: line 19)
3 packages and 0 specfiles checked; 0 errors, 8 warnings.




Rpmlint (installed packages)
----------------------------
# rpmlint scalacheck scalacheck-javadoc
scalacheck.noarch: W: summary-not-capitalized C property-based testing for Scala
scalacheck.noarch: W: spelling-error %description -l en_US runtime -> run time, run-time, rudiment
scalacheck.noarch: W: spelling-error %description -l en_US sbt -> tbs, st, set
2 packages and 0 specfiles checked; 0 errors, 3 warnings.
# echo 'rpmlint-done:'



Requires
--------
scalacheck (rpmlib, GLIBC filtered):
    javapackages-tools
    jpackage-utils
    scala

scalacheck-javadoc (rpmlib, GLIBC filtered):
    jpackage-utils



Provides
--------
scalacheck:
    mvn(org.scalacheck:scalacheck_2.10)
    scalacheck

scalacheck-javadoc:
    scalacheck-javadoc



Source checksums
----------------
https://github.com/rickynils/scalacheck/archive/1.11.3.tar.gz :
  CHECKSUM(SHA256) this package     : 8f9bfa2313a520ee4da889f2a611cf67d958f4cd8b27d748cf3fcd5584892cf4
  CHECKSUM(SHA256) upstream package : 8f9bfa2313a520ee4da889f2a611cf67d958f4cd8b27d748cf3fcd5584892cf4
http://repo1.maven.org/maven2/org/scalacheck/scalacheck_2.10/1.11.3/scalacheck_2.10-1.11.3.pom :
  CHECKSUM(SHA256) this package     : 17eb97e5b9b12592d20bc78f761c008aa2037c4f27966805c2e4735fd0e8d145
  CHECKSUM(SHA256) upstream package : 17eb97e5b9b12592d20bc78f761c008aa2037c4f27966805c2e4735fd0e8d145


Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13
Command line :/usr/bin/fedora-review -b 1056335 -m fedora-rawhide-i386
Buildroot used: fedora-rawhide-i386
Active plugins: Generic, Shell-api, Java
Disabled plugins: C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

some issues
%package javadoc
please remove (unnecessary)
Group:          Documentation
Summary:        Javadoc for %{name}
please remove (unnecessary)
BuildArch:	noarch

please, can you fix some warnings?

summary-not-capitalized
spelling-error
macro-in-comment
mixed-use-of-spaces-and-tabs

approved

New Package SCM Request
=======================
Package Name: scalacheck
Short Description: property-based testing for Scala
Owners: willb
Branches: f20

Git done (by process-git-requests).

scalacheck-1.11.3-3.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/scalacheck-1.11.3-3.fc20

scalacheck-1.11.3-3.fc20 has been pushed to the Fedora 20 testing repository.

scalacheck-1.11.3-3.fc20 has been pushed to the Fedora 20 stable repository.