Bug 1056810

Summary: [abrt] NetworkManager-ssh: strcmp(): nm-ssh-auth-dialog killed by SIGSEGV
Product: [Fedora] Fedora Reporter: Justin Pearce <whitefox>
Component: NetworkManager-sshAssignee: Dan Fruehauf <malkodan>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 20CC: echevemaster, malkodan, psimerda
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Unspecified   
URL: https://retrace.fedoraproject.org/faf/reports/bthash/0704ea448f562699f3b6e11fad96e4bccf200e78
Whiteboard: abrt_hash:dd1ee037dbc34843bad82180c0b84bf26eac6e96
Fixed In Version: NetworkManager-ssh-0.9.2-0.2.20140209git46247c2.fc20 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-03-15 15:05:26 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
File: backtrace
none
File: cgroup
none
File: core_backtrace
none
File: dso_list
none
File: environ
none
File: exploitable
none
File: limits
none
File: maps
none
File: open_fds
none
File: proc_pid_status
none
File: var_log_messages none

Description Justin Pearce 2014-01-23 00:20:21 UTC 
Description of problem:
Initiated VPN connection from Gnome 3 top right corner menu (not sure of the technical name). The program appears to attempt to connect and then the crash notification appears.

Version-Release number of selected component:
NetworkManager-ssh-0.9.1-0.5.20130706git6bf4649.fc20

Additional info:
reporter:       libreport-2.1.11
backtrace_rating: 4
cmdline:        /usr/libexec/nm-ssh-auth-dialog -u 61fa52da-a2b9-4b3e-bf9f-eb4092a4ad79 -n 'ArcAngel SSH' -s org.freedesktop.NetworkManager.ssh -i
crash_function: strcmp
executable:     /usr/libexec/nm-ssh-auth-dialog
kernel:         3.12.8-300.fc20.x86_64
runlevel:       N 5
type:           CCpp
uid:            1000

Truncated backtrace:
Thread no. 1 (1 frames)
 #0 strcmp at /lib64/libc.so.6
Comment 1 Justin Pearce 2014-01-23 00:20:29 UTC 
Created attachment 854128 [details]
File: backtrace
Comment 2 Justin Pearce 2014-01-23 00:20:31 UTC 
Created attachment 854129 [details]
File: cgroup
Comment 3 Justin Pearce 2014-01-23 00:20:36 UTC 
Created attachment 854130 [details]
File: core_backtrace
Comment 4 Justin Pearce 2014-01-23 00:20:38 UTC 
Created attachment 854131 [details]
File: dso_list
Comment 5 Justin Pearce 2014-01-23 00:20:40 UTC 
Created attachment 854132 [details]
File: environ
Comment 6 Justin Pearce 2014-01-23 00:20:42 UTC 
Created attachment 854133 [details]
File: exploitable
Comment 7 Justin Pearce 2014-01-23 00:20:43 UTC 
Created attachment 854134 [details]
File: limits
Comment 8 Justin Pearce 2014-01-23 00:20:45 UTC 
Created attachment 854135 [details]
File: maps
Comment 9 Justin Pearce 2014-01-23 00:20:47 UTC 
Created attachment 854136 [details]
File: open_fds
Comment 10 Justin Pearce 2014-01-23 00:20:49 UTC 
Created attachment 854137 [details]
File: proc_pid_status
Comment 11 Justin Pearce 2014-01-23 00:20:52 UTC 
Created attachment 854138 [details]
File: var_log_messages
Comment 12 Dan Fruehauf 2014-01-23 00:27:29 UTC 
That's pretty severe. Thanks for reporting, I'll look at it soon. I have a good idea where it's coming from.
Comment 13 Dan Fruehauf 2014-01-26 11:59:28 UTC 
Upstream issue:
https://github.com/danfruehauf/NetworkManager-ssh/issues/25

Regardless of whether I can reproduce this or not, I'm just going to replace all strcmp with strncmp.
Comment 14 Dan Fruehauf 2014-01-26 13:20:15 UTC 
Hi Justin,

I'm interested in the NM configuration you've been using, you should be able to find it at:
/etc/NetworkManager/system-connections/

Please conceal any passwords in it if you have any. I was not able to reproduce the problem just yet...
Comment 15 Justin Pearce 2014-01-26 22:33:39 UTC 
Configuration is as follows:
=========================================

[connection]
id=ArcAngel SSH
uuid=61fa52da-a2b9-4b3e-bf9f-eb4092a4ad79
type=vpn
autoconnect=false

[vpn]
service-type=org.freedesktop.NetworkManager.ssh
local-ip=10.11.12.1
extra-opts=-o ServerAliveInterval=10 -o TCPKeepAlive=yes
remote=arcangel.example.tld #Masked
netmask=255.255.255.252
auth-type=ssh-agent
remote-ip=192.168.1.102

[vpn-secrets]
ssh-auth-sock=/run/user/1000/keyring-kjBb04/ssh

[ipv6]
method=auto

[ipv4]
method=auto

=========================================

Hope this helps.
Comment 16 Dan Fruehauf 2014-01-26 23:27:26 UTC 
Unfortunately I couldn't reproduce the problem, however I understood why the crash could happen.

Either way, when choosing remote and local IPs, you must make sure they are in the same network, such that 10.11.12.1/255.255.255.252 and 192.168.1.102/255.255.255.252 are on the same network. Otherwise things wouldn't work.

Is it still BTW constantly crashing for you?
Comment 17 Justin Pearce 2014-01-27 00:23:57 UTC 
I am not seeing the catastrophic crash I experienced earlier.
Comment 18 Fedora Update System 2014-02-09 11:28:41 UTC 
NetworkManager-ssh-0.9.2-0.2.20140209git46247c2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/NetworkManager-ssh-0.9.2-0.2.20140209git46247c2.fc20
Comment 19 Fedora Update System 2014-02-10 03:13:50 UTC 
Package NetworkManager-ssh-0.9.2-0.2.20140209git46247c2.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing NetworkManager-ssh-0.9.2-0.2.20140209git46247c2.fc20'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-2221/NetworkManager-ssh-0.9.2-0.2.20140209git46247c2.fc20
then log in and leave karma (feedback).
Comment 20 Fedora Update System 2014-03-15 15:05:26 UTC 
NetworkManager-ssh-0.9.2-0.2.20140209git46247c2.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.