Bug 1056965
| Summary: | OSInfo file lacks validation for legal values | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Retired] oVirt | Reporter: | Eli Mesika <emesika> | ||||
| Component: | ovirt-engine-core | Assignee: | Roy Golan <rgolan> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | bugs <bugs> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 3.4 | CC: | gklein, iheim, michal.skrivanek, ofrenkel, rbalakri, rgolan, yeylon | ||||
| Target Milestone: | --- | ||||||
| Target Release: | 3.5.1 | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | virt | ||||||
| Fixed In Version: | ovirt-3.5.1_rc1 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2015-01-21 16:02:35 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | Virt | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 1093002 | ||||||
| Attachments: |
|
||||||
Setting target release to current version for consideration and review. please do not push non-RFE bugs to an undefined target release to make sure bugs are reviewed for relevancy, fix, closure, etc. IMHO on validation problem we should stop starting engine. It's basic config and if misconfigured we shouldn't risk wrong behavior This is an automated message. Re-targeting all non-blocker bugs still open on 3.4.0 to 3.4.1. Roy, do we want this in ovirt 3.5.1 (current target)? if so, backports are missing.. if not, please re-target to 3.6 (In reply to Omer Frenkel from comment #4) > Roy, do we want this in ovirt 3.5.1 (current target)? > if so, backports are missing.. > if not, please re-target to 3.6 done This is an automated message: This bug should be fixed in oVirt 3.5.1 RC1, moving to QA oVirt 3.5.1 has been released. If problems still persist, please make note of it in this bug report. |
Created attachment 854262 [details] Engine log Description of problem: OSInfo file luck validation for legal values For example changing the following os.windows_8.devices.display.protocols.value = vnc/cirrus to os.windows_8.devices.display.protocols.value = aaa/bbb Throws the following exception 2014-01-23 10:52:13,079 ERROR [org.ovirt.engine.core.bll.OsRepositoryQuery] (ajp--127.0.0.1-8702-2) Query OsRepositoryQuery failed. Exception message is No enum constant org.ovirt.engine.core.common.businessentities.DisplayType.aaa : java.lang.IllegalArgumentException: No enum constant org.ovirt.engine.core.common.businessentities.DisplayType.aaa: java.lang.IllegalArgumentException: No enum constant org.ovirt.engine.core.common.businessentities.DisplayType.aaa Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1.Open the osinfo file 2.change os.windows_8.devices.display.protocols.value = vnc/cirrus to os.windows_8.devices.display.protocols.value = aaa/bbb 3.restart ovirt-engine service 4.try to create a new VM Actual results: An exception is thrown , most fields in the New VM dialog displayed with blank data Expected results: Basic validation should be performed in order to handle illegal data properly Additional info: This is general for the whole osinfo file settings , the display value that was changed is just an example but this will occur with other entries as well