Bug 1057096

Summary: Python binding regression: stream send and sendAll fail
Product: [Community] Virtualization Tools Reporter: Robie Basak <robie.basak>
Component: libvirt-pythonAssignee: Libvirt Maintainers <libvirt-maint>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: unspecifiedCC: berrange, crobinso, rbalakri
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-03-20 16:20:22 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Fix caller to match callee prototype none

Description Robie Basak 2014-01-23 12:58:11 UTC
Created attachment 854371 [details]
Fix caller to match callee prototype

I don't see a libvirt-python component, so filing this under libvirt.

Description of problem:


Version-Release number of selected component (if applicable):

git master: de8361627c4f3fa2a1f8dd164ef80c5f0a6a17f6

How reproducible:

100%

Steps to Reproduce:

0. Assuming you start with a volume pool defined called 'default' with no volumes defined in it.

1. virsh vol-create-as default foo 1048576 --format raw

2. In Python:

conn = libvirt.open('qemu:///system')
pool = libvirt_conn.storagePoolLookupByName('default')
vol = pool.storageVolLookupByName('foo')
stream = conn.newStream(0)
vol.upload(stream, 0, 1048576, 0)
stream.send('A' * 65536)

Actual results:

libvirt.libvirtError: virStreamSend() failed

Expected results:

Silent success.

Additional info:

Impact: stops the Python binding from being able to upload volumes to libvirt completely.

Regression caused by commit d40861. Patch attached.

Comment 2 Daniel Berrangé 2014-01-23 15:38:47 UTC
Changing component, since bz admins have created libvirt-python now