Bug 1058082

Summary: [abrt] gnome-boxes: boxes_installer_media_get_decoded_udev_property(): gnome-boxes killed by SIGABRT
Product: [Fedora] Fedora Reporter: Joachim Frieben <jfrieben>
Component: gnome-boxesAssignee: Christophe Fergeau <cfergeau>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 20CC: cfergeau, ignatenko, jfrieben, marcandre.lureau, virt-maint, zeenix
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Unspecified   
URL: https://retrace.fedoraproject.org/faf/reports/bthash/3e702aba2c4f1d68bfc781612d8fbc43e7a7ce23
Whiteboard: abrt_hash:35f9d3e5df1472247f79b55afcef488e719119bf
Fixed In Version: gnome-boxes-3.10.2-3.fc20 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1075580 (view as bug list) Environment:
Last Closed: 2014-03-26 05:31:59 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
File: backtrace
none
File: cgroup
none
File: core_backtrace
none
File: dso_list
none
File: environ
none
File: limits
none
File: maps
none
File: open_fds
none
File: proc_pid_status
none
File: var_log_messages
none
Output of 'udevadm info --query=property /dev/sdb'
none
Output of 'udevadm info --query=property /dev/mmcblk0p1'
none
Source selection of GNOME Boxes
none
udevadm info --query=property /dev/sdb none

Description Joachim Frieben 2014-01-26 22:10:46 UTC
Version-Release number of selected component:
gnome-boxes-3.11.4-1.fc21

Additional info:
reporter:       libreport-2.1.11
backtrace_rating: 4
cmdline:        gnome-boxes
crash_function: boxes_installer_media_get_decoded_udev_property
executable:     /usr/bin/gnome-boxes
kernel:         3.13.0-1.fc21.x86_64
runlevel:       N 5
type:           CCpp
uid:            1001

Truncated backtrace:
Thread no. 1 (10 frames)
 #5 boxes_installer_media_get_decoded_udev_property at installer-media.c:3017
 #6 boxes_installer_media_get_decoded_udev_properties_for_media at /home/zeenix/checkout/gnome/gnome-boxes/src/installer-media.vala:224
 #7 boxes_installer_media_get_media_info_from_device_co at /home/zeenix/checkout/gnome/gnome-boxes/src/installer-media.vala:207
 #8 boxes_installer_media_get_media_info_from_device at /home/zeenix/checkout/gnome/gnome-boxes/src/installer-media.vala:7
 #9 boxes_installer_media_construct_for_path_co at /home/zeenix/checkout/gnome/gnome-boxes/src/installer-media.vala:69
 #10 g_simple_async_result_complete at gsimpleasyncresult.c:770
 #11 boxes_installer_media_get_device_from_path_co at /home/zeenix/checkout/gnome/gnome-boxes/src/installer-media.vala:185
 #12 g_task_return_now at gtask.c:1109
 #13 complete_in_idle_cb at gtask.c:1118
 #17 g_main_context_iteration at gmain.c:3775

Comment 1 Joachim Frieben 2014-01-26 22:10:52 UTC
Created attachment 855815 [details]
File: backtrace

Comment 2 Joachim Frieben 2014-01-26 22:10:54 UTC
Created attachment 855816 [details]
File: cgroup

Comment 3 Joachim Frieben 2014-01-26 22:10:57 UTC
Created attachment 855817 [details]
File: core_backtrace

Comment 4 Joachim Frieben 2014-01-26 22:11:00 UTC
Created attachment 855818 [details]
File: dso_list

Comment 5 Joachim Frieben 2014-01-26 22:11:02 UTC
Created attachment 855819 [details]
File: environ

Comment 6 Joachim Frieben 2014-01-26 22:11:04 UTC
Created attachment 855820 [details]
File: limits

Comment 7 Joachim Frieben 2014-01-26 22:11:08 UTC
Created attachment 855821 [details]
File: maps

Comment 8 Joachim Frieben 2014-01-26 22:11:10 UTC
Created attachment 855822 [details]
File: open_fds

Comment 9 Joachim Frieben 2014-01-26 22:11:12 UTC
Created attachment 855823 [details]
File: proc_pid_status

Comment 10 Joachim Frieben 2014-01-26 22:11:14 UTC
Created attachment 855824 [details]
File: var_log_messages

Comment 11 Christophe Fergeau 2014-01-27 10:39:02 UTC
This fails on a fortify check in get_decoded_udev_property()

Looking at the code, aren't we going one byte past the end of the string in
if (encoded[i:encoded.length].scanf ("\\x%02x", out x) > 0) {
?

Comment 12 Zeeshan Ali 2014-01-27 13:31:23 UTC
(In reply to Christophe Fergeau from comment #11)
> This fails on a fortify check in get_decoded_udev_property()
> 
> Looking at the code, aren't we going one byte past the end of the string in
> if (encoded[i:encoded.length].scanf ("\\x%02x", out x) > 0) {

No, the M is exclusive in [N:M] syntax: https://wiki.gnome.org/Projects/Vala/Tutorial#Arrays

Comment 13 Igor Gnatenko 2014-02-04 10:55:07 UTC
Got today

Comment 14 Zeeshan Ali 2014-02-12 12:58:41 UTC
Would be much easier to debug this if I could reproduce it so I need some info: Is there any ISOs mounted or USB/ISO device inserted when you reproduce this? If so, can you please provide output of ` udevadm info --query=property DEVICE_PATH` ?

Comment 15 Joachim Frieben 2014-02-12 20:26:55 UTC
Created attachment 862529 [details]
Output of 'udevadm info --query=property /dev/sdb'

Comment 16 Joachim Frieben 2014-02-12 20:32:53 UTC
Created attachment 862530 [details]
Output of 'udevadm info --query=property /dev/mmcblk0p1'

Issue has occurred just half an hour ago for installed packages:

  kernel-3.14.0-0.rc2.git0.2.fc21
  gnome-boxes-3.11.5.1-2.fc21

Two removable devices were atteched to the system: a USB stick listed as /dev/sdb and an SD card listed as /dev/mmcblk0p1.

After removing both of them, gnome-boxes still crashed at start-up. After tunrning the system off and on again, gnome-boxes did not crash anymore regardless of whether any of the two devices was present at boot time after a warm boot of the system or not.

Comment 17 Joachim Frieben 2014-02-13 02:34:40 UTC
Created attachment 862609 [details]
Source selection of GNOME Boxes

Even if gnome-boxes does not crash any more, this observation is of little interest given that the application is now stuck at the source selection stage.

Comment 18 Zeeshan Ali 2014-02-17 14:16:08 UTC
(In reply to Christoph Frieben from comment #17)
> Created attachment 862609 [details]
> Source selection of GNOME Boxes
> 
> Even if gnome-boxes does not crash any more, this observation is of little
> interest given that the application is now stuck at the source selection
> stage.

Its still very relevant and this new issue could be an entirely different bug. Could you please get a backtrace of all threads when its stuck?

Comment 19 Zeeshan Ali 2014-02-17 14:18:51 UTC
(In reply to Zeeshan Ali from comment #18)
> (In reply to Christoph Frieben from comment #17)
> > Created attachment 862609 [details]
> > Source selection of GNOME Boxes
> > 
> > Even if gnome-boxes does not crash any more, this observation is of little
> > interest given that the application is now stuck at the source selection
> > stage.
> 
> Its still very relevant and this new issue could be an entirely different
> bug. Could you please get a backtrace of all threads when its stuck?

Oh nm, I didn't see the screenshot. Its not stuck but rather some important UI components are for some reason not shown. I think I fixed this not so long ago in unstable branch.

Comment 20 Zeeshan Ali 2014-02-17 14:21:36 UTC
(In reply to Zeeshan Ali from comment #19)
> (In reply to Zeeshan Ali from comment #18)
> > (In reply to Christoph Frieben from comment #17)
> > > Created attachment 862609 [details]
> > > Source selection of GNOME Boxes
> > > 
> > > Even if gnome-boxes does not crash any more, this observation is of little
> > > interest given that the application is now stuck at the source selection
> > > stage.
> > 
> > Its still very relevant and this new issue could be an entirely different
> > bug. Could you please get a backtrace of all threads when its stuck?
> 
> Oh nm, I didn't see the screenshot. Its not stuck but rather some important
> UI components are for some reason not shown. I think I fixed this not so
> long ago in unstable branch.

Anyway, its a differen bug so please file it separately.

(In reply to Christoph Frieben from comment #16)
> Created attachment 862530 [details]
> Output of 'udevadm info --query=property /dev/mmcblk0p1'

The output of  /dev/sdb would be more helpful as this device is not a bootable ISO9660 media.

Comment 21 Igor Gnatenko 2014-02-28 08:09:42 UTC
Created attachment 868887 [details]
udevadm info --query=property /dev/sdb

Comment 22 Joachim Frieben 2014-03-02 09:44:47 UTC
Issue still present for gnome-boxes-3.11.90.1-2.fc21 when a bootable CD is inserted in the CDV drive.

Comment 23 Joachim Frieben 2014-03-09 09:39:45 UTC
Issue still present for gnome-boxes-3.11.91-1.fc21 when a bootable CD is inserted in the CDV drive.

Comment 24 Zeeshan Ali 2014-03-12 16:59:01 UTC
Thanks to Christophe, this is fixed in git master and will be fixed for rawhide when next Boxes release hits there (early next week). I'm make this an F20 bug as I'm pushing the fix there right now and F20 being the current stable release is more important IMO.

Comment 25 Fedora Update System 2014-03-13 12:09:04 UTC
gnome-boxes-3.10.2-3.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/gnome-boxes-3.10.2-3.fc20

Comment 26 Fedora Update System 2014-03-15 15:18:08 UTC
Package gnome-boxes-3.10.2-3.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing gnome-boxes-3.10.2-3.fc20'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-3916/gnome-boxes-3.10.2-3.fc20
then log in and leave karma (feedback).

Comment 27 Fedora Update System 2014-03-26 05:31:59 UTC
gnome-boxes-3.10.2-3.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.