Bug 105833

Summary: bad source code
Product: [Retired] Red Hat Linux Reporter: d.binderman
Component: kdeaddonsAssignee: Than Ngo <than>
Status: CLOSED UPSTREAM QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: 9   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2004-06-28 09:14:47 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description d.binderman 2003-09-28 10:52:46 UTC
From Bugzilla Helper:
User-Agent: Mozilla/4.6 [en-gb]C-CCK-MCD NetscapeOnline.co.uk  (Win98; I)

Description of problem:

Hello there,

I just tried to compile package kdeaddons-3.1-4 from
Redhat 9.0 with compiler flag -Wall.

The compiler said

display.c:121: warning: operation on `pdest' may be undefined

The source code is

                            *(pdest++)=*(pdest-1);

This code is undefined.

You would be much better off with

		*pdest = pdest[ -1];
		++pdest;



Version-Release number of selected component (if applicable):


How reproducible:
Always

Steps to Reproduce:
1. compile with compiler flag -Wall
2.
3.
    

Additional info

Comment 1 Than Ngo 2004-04-07 22:04:23 UTC
*** Bug 114745 has been marked as a duplicate of this bug. ***

Comment 2 Than Ngo 2004-06-28 09:14:47 UTC
i have forwarded it to the maintainer. I hope it will be included in
next upstream. Thanks for your report.

Comment 3 David Binderman 2005-02-18 12:38:19 UTC
>I hope it will be included in next upstream

Still broken in February 2005, some 17 months after 
the original report.