Bug 1058534
Summary: | Alert template for Trait Change from older RHQ results in NullPointerException | ||
---|---|---|---|
Product: | [Other] RHQ Project | Reporter: | Elias Ross <genman> |
Component: | Alerts | Assignee: | Jay Shaughnessy <jshaughn> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Mike Foley <mfoley> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | 4.9 | CC: | hrupp |
Target Milestone: | GA | ||
Target Release: | RHQ 4.10 | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2014-04-23 12:29:52 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Elias Ross
2014-01-28 01:37:12 UTC
Actually I'm not really sure the ways to reproduce this issue. It seems to have gone away, so I wonder if there is a race condition someplace. I was observing the following, however. 1) Resource alert definitions created on RHQ 4.5.1 for metric trait change 2) Server updated to 4.9 3) New resources created on 4.9 server/agent. Alert definitions were not copied to these resources. Other alerts were. I'm not sure this is related or not. That line with the NPE looks fishy by itself anyway Boolean results = null; if ((results == null) && (alertConditionValue.equals(providedValue) == false)) { So results is always null and the 1st check makes no sense here. In other CacheElements like the numeric ones, we indeed check for alertConditionValue being null when matches() is called, so there is a possibility that this is the issue here as well. master commit ef19f80122c9f53ba953a8b51030db2e4ae56c27 Author: Jay Shaughnessy <jshaughn> Date: Fri Mar 7 13:34:39 2014 -0500 The "Changes" operator requires slightly different logic as alertConditionValue allows null. Add null handling, also refactor some similarly verbose/confusing code in a few CacheElement classes. And add i-test for this issue. Bulk closing of 4.10 issues. If an issue is not solved for you, please open a new BZ (or clone the existing one) with a version designator of 4.10. |