Bug 1058666

Summary: Enable fusermount by default, make nightly autobuilding work
Product: [Community] GlusterFS Reporter: Niels de Vos <ndevos>
Component: buildAssignee: Niels de Vos <ndevos>
Status: CLOSED DEFERRED QA Contact:
Severity: low Docs Contact:
Priority: low    
Version: 3.3.2CC: bugs, gluster-bugs, kkeithle
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-12-14 19:40:32 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Niels de Vos 2014-01-28 10:20:46 UTC
Description of problem:
Nightly builds for release-3.3 are failing. This is the only release that requires "./configure --enable-fusermount" to be specified before "make dist".

Version-Release number of selected component (if applicable):
3.3

How reproducible:
100%

Steps to Reproduce:
1. ./configure
2. make dist
3. rpmbuild -ta *.tar.gz

Actual results:
Building the RPMs fail with:

config.status: creating contrib/fuse-util/Makefile
config.status: error: cannot find input file: contrib/fuse-util/Makefile.in
RPM build errors:
error: Bad exit status from /var/tmp/rpm-tmp.71415 (%build)
    Bad exit status from /var/tmp/rpm-tmp.71415 (%build)
Child return code was: 1

Expected results:
RPMs get build successfully.

Additional info:
Logs: http://copr-be.cloud.fedoraproject.org/results/devos/glusterfs-3.3/epel-5-x86_64/glusterfs-3.3.20140128.41deb1e-1.autobuild/build.log
COPR: http://copr-fe.cloud.fedoraproject.org/coprs/devos/glusterfs-3.3/builds/
Docs: http://www.gluster.org/community/documentation/index.php/User:Ndevos/NightlyBuilds

Comment 1 Anand Avati 2014-01-28 10:41:54 UTC
REVIEW: http://review.gluster.org/6831 (build: enable fusermount by default) posted (#1) for review on release-3.3 by Niels de Vos (ndevos)

Comment 2 Anand Avati 2014-01-28 10:42:07 UTC
REVIEW: http://review.gluster.org/6832 (build: really disable fusermount if you say so) posted (#1) for review on release-3.3 by Niels de Vos (ndevos)

Comment 3 Anand Avati 2014-03-10 07:33:02 UTC
COMMIT: http://review.gluster.org/6831 committed in release-3.3 by Vijay Bellur (vbellur) 
------
commit 91b02583db1f16b96e005180eee9ffcd0345b7bc
Author: Niels de Vos <ndevos>
Date:   Tue Jan 28 10:59:57 2014 +0100

    build: enable fusermount by default
    
    The fusermount available in gluster is customized to ensure
    mounting with SELinux happens properly, i.e - to have a separate
    thread for fuse_thread_proc which can process getxattr requests
    and in parallel perform sys_mount() in a different thread, thereby
    avoiding a deadlock.
    
    However our build and packaging defaults to not including our
    fusermount. This patch reverses the defaults.
    
    Backport from:
    > Change-Id: I793af4c2f56aeac46efae3db30e7c64ee7c18850
    > BUG: 811217
    > Signed-off-by: Anand Avati <avati>
    > Reviewed-on: http://review.gluster.org/4773
    > Reviewed-by: Jeff Darcy <jdarcy>
    > Tested-by: Gluster Build System <jenkins.com>
    
    Change-Id: If5fb368b6737fe8b6f22d2f2aa0785baa7f96364
    BUG: 1058666
    Signed-off-by: Niels de Vos <ndevos>
    Reviewed-on: http://review.gluster.org/6831
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Justin Clift <justin>
    Tested-by: Justin Clift <justin>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 4 Anand Avati 2014-03-10 07:33:16 UTC
COMMIT: http://review.gluster.org/6832 committed in release-3.3 by Vijay Bellur (vbellur) 
------
commit 59c31ab8f502c8ef2607f7da074f11b98438e2a4
Author: Niels de Vos <ndevos>
Date:   Tue Jan 28 11:00:27 2014 +0100

    build: really disable fusermount if you say so
    
    There is no logic in configure.ac that provides a $disable_fusermount
    variable. So, use the $enable_fusermount variable instead.
    
    Backport from:
    > Follow-up-for: http://review.gluster.org/4773
    > Change-Id: I81cdbd0045409d0036438d542ca6dc1934f784e4
    > BUG: 948205
    > Signed-off-by: Niels de Vos <ndevos>
    > Reviewed-on: http://review.gluster.org/4803
    > Reviewed-by: Kaleb KEITHLEY <kkeithle>
    > Reviewed-by: Sachidananda Urs <sacchi>
    > Tested-by: Gluster Build System <jenkins.com>
    
    Change-Id: Ie5fa36fa6cf40336e75efbf7fd8527c3ff466e4c
    BUG: 1058666
    Signed-off-by: Niels de Vos <ndevos>
    Reviewed-on: http://review.gluster.org/6832
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Justin Clift <justin>
    Tested-by: Justin Clift <justin>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 5 Niels de Vos 2014-11-27 14:54:37 UTC
The version that this bug has been reported against, does not get any updates from the Gluster Community anymore. Please verify if this report is still valid against a current (3.4, 3.5 or 3.6) release and update the version, or close this bug.

If there has been no update before 9 December 2014, this bug will get automatocally closed.