Bug 1058675

I see this fixed for example by a tooltip over the out-of-sync icon, explaining the reasons what exactly is out-of-sync (VLAN, MTU, QoS, etc.).

(In reply to Lior Vernia from comment #1)
> I see this fixed for example by a tooltip over the out-of-sync icon,
> explaining the reasons what exactly is out-of-sync (VLAN, MTU, QoS, etc.).

Lior:

- when will a networking-out-of-sync occur? will it happen, for example, if you will change the Host networking configuration through the GUI, without checking the "Save Networking Configuration" check-box, and then re-boot the host?

- can you please attach a screen-shot showing the out-of-sync icon?

Created attachment 887930 [details]
Network "temp" out-of-sync

Out-of-sync is whenever any network properties reported by a host are inconsistent with those of the corresponding logical network entities, e.g. VLAN, MTU.

It used to be easier to get to such a situation before the multi-host network configuration feature was implemented in oVirt 3.4, one could simply change the MTU of a logical network and all hosts would go out-of-sync (because the update wouldn't propagate to them).

Nowadays, it could happen (I hope this is an exhaustive list):
* As part of the scenario you described.
* If the host is meddled with manually.
* If the host is non-responsive while a logical network is being updated.
* If the host is moved between DCs, where a network exists with the same name but with different properties.

Screenshot is attached, you can see the right-most icon on the network "temp" (it used to be further away from the edge, this is a recent visual regression).

Thanks Lior, another question: Once the network is in an out-of-sync state - can the user do anything about it (save network config? host maintenance->activate?)

There's no problem moving the host between life cycle states (e.g. activate it), it will be fully functional. The only limitation is that it's impossible to modify the networks on the NIC where an out-of-sync network is present - the user must first mark the out-of-sync network to be synchronized (this is done in the edit network dialog inside setup networks).

Einav, now it's your turn to answer questions :) At the moment there appears a single tooltip panel when hovering on a network panel. When the network is out-of-sync, the tooltip explains the icon (see attachment), but there's not much room to describe what exactly the problem (e.g. "on the host MTU=1500 but in the engine MTU=1000").

So, what to do? Add a different tooltip panel specifically for the out-of-sync icon? When thinking about it, of course we also need to keep in mind the future look of Setup Networks and not only the current one, and whether we want to have separate tooltips for different elements on networks, NICs etc.

Created attachment 897511 [details]
Out-of-sync tooltip

(In reply to Lior Vernia from comment #6)
> There's no problem moving the host between life cycle states (e.g. activate
> it), it will be fully functional. The only limitation is that it's
> impossible to modify the networks on the NIC where an out-of-sync network is
> present - the user must first mark the out-of-sync network to be
> synchronized (this is done in the edit network dialog inside setup networks).

Lior, I have one clarification and one suggestion. You mentioned "it's
> impossible to modify the networks on the NIC where an out-of-sync network is
> present" - Soes this mean thia network cannot be dragged to any other NIC in the setup networks dialog?

As for the suggestion, if the action that the user has to take to mark it for sync is buried int he edit dialog for the network, why not just toggle the icon from indicator to button and allow the user to press sync right on the box representing the logical network? Also an additional question is if this check box for sync is marked, when does it actually sync and how does the user know that syncing is complete?

The only thing a user may do with an out-of-sync network, other than synchronize it, is remove it from its NIC. Also, while it remains on the NIC and isn't marked to be synchronized, no other networks can be attached to the NIC.

I like the suggestion, if you think it's preferable then we can turn the icon into a switch button.

The actual synchronization takes place when the Setup Networks command is sent to the host, i.e. when "Ok" is clicked in the big dialog. If the action fails (for whatever reason, not just synchronization) everything is rolled back and an error popup appears, while the dialog remains open.

However, once the synchronize checkbox is checked, other operations are allowed in the same Setup Networks instance, as if the network had already been synchronized.

Also, just to have this documented, the point I raised was discussed with Einav and Malini, and it seems that having a separate tooltip for the out-of-sync icon is a reasonable solution.

It may also be nice, but not necessary, to include another "link" to that info from the general network panel tooltip, where the out-of-sync icon is explained.

out-of-sync icon will pop-up a tool-tip upon hover with out-of-sync reason and a "sync" button. Once the "sync" button is clicked, out-of-sync icon will become an "out-of-sync-but-marked-for-sync" icon; hovering on that will pop-up a tool-tip with the "Marked for Sync" text (can still be along with the reason, if relevant - not critical).

@Lior: Is there a design for this particular request in the new PatternFly-based Setup Host Networks dialog design?

Hi Einav. No, there isn't. It's actually not PatternFly-specific though (it'd be easy to use the same color scheme Greg is implementing) - we just need a good think on how to organize all the tooltips in this dialog, and how data should be displayed in each one.

The dedicated out-of-sync tooltip, for example - should we just say what is out-of-sync, e.g. VLAN, MTU?... Or also for those attributes specify what is configured on the host as opposed to what is configured in the engine? And if so, present it in some table layout (because there could be several attributes that differ at once)? If QoS is out-of-sync - there'll be a lot of numeric values there...

(In reply to Lior Vernia from comment #14)
> Hi Einav. No, there isn't. It's actually not PatternFly-specific though
> (it'd be easy to use the same color scheme Greg is implementing) - we just
> need a good think on how to organize all the tooltips in this dialog, and
> how data should be displayed in each one.
> 
> The dedicated out-of-sync tooltip, for example - should we just say what is
> out-of-sync, e.g. VLAN, MTU?... Or also for those attributes specify what is
> configured on the host as opposed to what is configured in the engine? And
> if so, present it in some table layout (because there could be several
> attributes that differ at once)? If QoS is out-of-sync - there'll be a lot
> of numeric values there...

there are obviously a lot of options, and we will need more information on the possible out-of-sync types and data associated with each one of these types which makes sense to display as part of the tool-tip. 

@Liz - maybe we should create a trello card for this one specifically?
maybe can be assigned directly to Brian, if makes sense (he is the one that worked on the new Setup Host Networks design); in any case, UXD rep will need to work with Lior or Eliraz (BZ assignee) on the exact requirements for the out-of-sync indication for this dialog. 

thanks.

Yes, I've created a trello card to do this design work. I will share a design proposal here when it's finished.

Thanks,
Liz

Verified on - rhevm-3.6.0.1-0.1.el6.noarch

Indication why network is out-of-sync reported in the network's tooltip in the Setup Networks dialog. 
In this tootip will be reported the Property that is out-of-sync and the difference between HOST and DC.

oVirt 3.6.0 has been released on November 4th, 2015 and should fix this issue.
If problems still persist, please open a new BZ and reference this one.