Bug 1058713

Summary: Index may not be added incase of brick crashes
Product: [Community] GlusterFS Reporter: Pranith Kumar K <pkarampu>
Component: coreAssignee: Pranith Kumar K <pkarampu>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: mainlineCC: bugs, gluster-bugs
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: glusterfs-3.6.0beta1 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-11-11 08:27:22 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Pranith Kumar K 2014-01-28 12:17:11 UTC
Description of problem:
    Problem:
    If brick crashes just after performing xattrop before
    reaching index _cbk then the gfid will not be added to/deleted from
    index. If it is not deleted it will be deleted when self-heal is
    triggered. But if the crash happens before the file is added to index,
    user may think the system does not need self-heal even when there is
    this file that needs to be healed.


Version-Release number of selected component (if applicable):


How reproducible:

Actual results:


Expected results:


Additional info:

Comment 1 Anand Avati 2014-01-28 12:18:26 UTC
REVIEW: http://review.gluster.org/6836 (cluster/afr: Add gfid to index in wind un-conditionally) posted (#1) for review on master by Pranith Kumar Karampuri (pkarampu)

Comment 2 Anand Avati 2014-01-29 04:47:22 UTC
REVIEW: http://review.gluster.org/6836 (cluster/afr: Add gfid to index in wind un-conditionally) posted (#2) for review on master by Pranith Kumar Karampuri (pkarampu)

Comment 3 Anand Avati 2014-01-30 03:42:38 UTC
COMMIT: http://review.gluster.org/6836 committed in master by Anand Avati (avati) 
------
commit 922134fdc08afb2810cb0205f26693d36db6fd4e
Author: Pranith Kumar K <pkarampu>
Date:   Tue Jan 28 15:16:59 2014 +0530

    cluster/afr: Add gfid to index in wind un-conditionally
    
    Problem:
    If brick crashes just after performing xattrop before
    reaching index _cbk then the gfid will not be added to/deleted from
    index. If it is not deleted it will be deleted when self-heal is
    triggered. But if the crash happens before the file is added to index,
    user may think the system does not need self-heal even when there is
    this file that needs to be healed.
    
    Fix:
    Add file to index un-conditionally in wind phase. This way the
    file remains in index even when brick process crashes before reaching
    _cbk. This does not affect performance because of caching(check
    _index_action) built into index xlator.
    
    Change-Id: Ie83ac6aa1ac0ff66862e757864865b47ab39404d
    BUG: 1058713
    Signed-off-by: Pranith Kumar K <pkarampu>
    Reviewed-on: http://review.gluster.org/6836
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Anand Avati <avati>

Comment 4 Niels de Vos 2014-09-22 12:35:24 UTC
A beta release for GlusterFS 3.6.0 has been released. Please verify if the release solves this bug report for you. In case the glusterfs-3.6.0beta1 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED.

Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-September/018836.html
[2] http://supercolony.gluster.org/pipermail/gluster-users/

Comment 5 Niels de Vos 2014-11-11 08:27:22 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.1, please reopen this bug report.

glusterfs-3.6.1 has been announced [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019410.html
[2] http://supercolony.gluster.org/mailman/listinfo/gluster-users