Bug 1058747

Summary: Byobu sources $BYOBU_CONFIG_DIR/.tmux.conf twice
Product: [Fedora] Fedora Reporter: Ankur Sinha (FranciscoD) <sanjay.ankur>
Component: byobuAssignee: Jan Klepek <jan.klepek>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 20CC: jan.klepek
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-03-28 19:55:43 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Ankur Sinha (FranciscoD) 2014-01-28 13:21:41 UTC
Description of problem:
Byobu appears to source $BYOBU_CONFIG_DIR/.tmux.conf *twice*

Version-Release number of selected component (if applicable):
byobu-5.69-2.fc20.noarch


How reproducible:
Always

Steps to Reproduce:
1. Write a simple .byobu/.tmux.conf file:

[asinha@ankur-laptop ~]$ cat .byobu/.tmux.conf
new-window -ad -n "ncmpcpp"
new-window -ad -n "irssi"
[asinha@ankur-laptop ~]$ 

2. select tmux as backend
3. run byobu

Actual results:
It starts two sessions (bug filed). The one session that does have these windows has them twice. 

Expected results:
Session should only have them once

Additional info:
I dug in a little. So, byobu's command line with tmux is:

asinha   32124  1.5  0.0  22568  2076 ?        Ss   00:18   0:00 tmux -2 -f /usr/share/byobu/profiles/tmuxrc new-session -n - /usr/bin/byobu-shell

Now, tmuxrc sources the following files:
source-file $HOME/.byobu/color.tmux
source-file $BYOBU_CONFIG_DIR/profile.tmux
source-file $BYOBU_CONFIG_DIR/keybindings.tmux
source-file $BYOBU_CONFIG_DIR/.tmux.conf

Note that it's already sourcing $BYOBU_CONFIG_DIR/.tmux.conf

It also sources $BYOBU_CONFIG_DIR/profile.tmux which has the one line:
source $BYOBU_PREFIX/share/byobu/profiles/tmux

This file, again sources $BYOBU_CONFIG_DIR/.tmux.conf in it's last line:
[asinha@ankur-laptop ~]$ tail -2 /usr/share/byobu/profiles/tmux
# Allow local overrides
source $BYOBU_CONFIG_DIR/.tmux.conf

I think this causes duplication of windows.

Comment 1 Jan Klepek 2014-02-25 18:28:47 UTC
waiting for fix from upstream

Comment 2 Jan Klepek 2014-02-27 12:00:16 UTC
there is patch provided to upstream which will be part of byobu-5.73-3 later this week

Comment 3 Fedora Update System 2014-02-27 18:29:05 UTC
byobu-5.73-3.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/byobu-5.73-3.fc20

Comment 4 Fedora Update System 2014-02-27 18:29:20 UTC
byobu-5.73-3.el5 has been submitted as an update for Fedora EPEL 5.
https://admin.fedoraproject.org/updates/byobu-5.73-3.el5

Comment 5 Fedora Update System 2014-02-27 18:29:36 UTC
byobu-5.73-3.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/byobu-5.73-3.el6

Comment 6 Fedora Update System 2014-02-27 18:29:51 UTC
byobu-5.73-3.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/byobu-5.73-3.fc19

Comment 7 Fedora Update System 2014-02-28 18:08:36 UTC
byobu-5.73-4.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/byobu-5.73-4.fc19

Comment 8 Fedora Update System 2014-02-28 18:09:00 UTC
byobu-5.73-4.el5 has been submitted as an update for Fedora EPEL 5.
https://admin.fedoraproject.org/updates/byobu-5.73-4.el5

Comment 9 Fedora Update System 2014-02-28 18:09:27 UTC
byobu-5.73-4.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/byobu-5.73-4.el6

Comment 10 Fedora Update System 2014-02-28 18:09:54 UTC
byobu-5.73-4.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/byobu-5.73-4.fc20

Comment 11 Fedora Update System 2014-03-15 19:51:24 UTC
byobu-5.73-4.el6 has been pushed to the Fedora EPEL 6 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 12 Fedora Update System 2014-03-15 19:51:48 UTC
byobu-5.73-4.el5 has been pushed to the Fedora EPEL 5 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 13 Fedora Update System 2014-03-17 03:55:30 UTC
byobu-5.73-4.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 14 Fedora Update System 2014-03-17 03:56:23 UTC
byobu-5.73-4.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.