Bug 1058766

Summary: Restore cursor position after changing help line
Product: [Fedora] Fedora Reporter: Dan Winship <danw>
Component: newtAssignee: Miroslav Lichvar <mlichvar>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: mlichvar
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: newt-0.52.17-1.fc21 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-01-29 10:12:25 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
fix none

Description Dan Winship 2014-01-28 13:54:09 UTC 
Created attachment 856604 [details]
fix

If you call newtPushHelpLine() while an entry is focused (eg, to say something like "You must enter a number between 1 and 100"), the visible cursor ends up at the end of the help line instead of in the entry.
Comment 1 Miroslav Lichvar 2014-01-28 18:07:23 UTC 
I'm not sure about that SLsmg_refresh() call. Is it really needed? I think the form should always do that, otherwise it could be drawn before everything is ready and cause some flickering.
Comment 2 Dan Winship 2014-01-28 18:53:47 UTC 
ah, no, it's not necessary. I can just call newtRefresh(). (I was only thinking from the perspective of changing the help line while the form was active, so it seemed weird that it didn't refresh, but clearly if you set a static help line before opening the form then you wouldn't want that.)
Comment 3 Miroslav Lichvar 2014-01-29 10:12:25 UTC 
Ok, I've pushed it without that line. Thanks.

In the next few weeks I'll try to make a new newt release and update it in Fedora too.
Comment 4 Miroslav Lichvar 2014-02-19 17:44:39 UTC 
This and other changes you have made are now in 0.52.17.