Bug 1058867

Summary: Text and buttons on 'reclaim space' version of Installation Options now inconsistent
Product: [Fedora] Fedora Reporter: Adam Williamson <awilliam>
Component: anacondaAssignee: Anaconda Maintenance Team <anaconda-maint-list>
Status: CLOSED EOL QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 26CC: anaconda-maint-list, duffy, g.kaviyarasu, jonathan, jwakely, swadeley, vanmeeuwen+fedora
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: All   
OS: All   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1098321 (view as bug list) Environment:
Last Closed: 2018-05-29 11:55:45 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1014671    
Bug Blocks:    

Description Adam Williamson 2014-01-28 16:33:34 UTC
The revision to the partitioning workflow that was discussed in https://bugzilla.redhat.com/show_bug.cgi?id=1014671 has been implemented in current Rawhide. I love the new version, it's a big improvement.

As it was implemented, an inconsistency has been created. If you leave the Partitioning radio button at 'Automatically configure partitioning.' and click Done, but you don't have sufficient space available for us to do a hands-free autopart, you still see a version of Installation Options. It says this:

"You don't have enough space available to install Fedora. You can shrink or remove existing partitions via our guided reclaim space tool, or you can adjust your partitions on your own in the custom partitioning interface."

but the button that leads to Custom Partitioning was dropped from the dialog as part of the workflow change. The only buttons are "Cancel & add more disks" and "Reclaim space". Mo did not actually envisage this in her mockups.

As discussed in #anaconda today, there are two ways this could possibly be addressed:

1. Tweak the "guide text" and the "Cancel" button label to make it clear to the user that they can cancel out of the dialog to add more disks *or* to switch to custom partitioning.
2. Just restore the "Automatic partitioning" button to the dialog.

Mo was broadly arguing in favour of option 2, and I was broadly in favour of 1 (yes, you read that right :>)

We both agree that there are advantages and disadvantages to either approach. Case 1) keeps the logic flow clean - you choose custom or manual partitioning on the disk selection screen, and all your following choices are made in relation to that choice. This is what I really like about it.

But Mo points out that it makes things harder for a user we're calling the "snoozing partition pokemon", who just clicks through on autopilot until they hit an error condition but *once they hit an error condition*, wants complete control. In case 1), this person has to follow a somewhat unwieldy flow (hit Cancel, change the "Partitioning" choice, hit Done again), and it makes the 'logic' of the Cancel button less clear than it is in the current design (you now have two sensible reasons to cancel - 'add more disks' or 'switch partitioning method').

Case 2) confuses the logic flow a bit more, because you can now change your mind about your partitioning style choice from the IO dialog, even though you already made an explicit choice on the previous screen, and I worry that this will confuse non-pokemons. But it is definitely a better workflow for the "snoozing pokemon". It also has the advantages that it is what was in the mockups, it's something we already had before rather than something new, and it keeps the logic of the Cancel button clear (you'd really only want to Cancel to change disk selection).

Comment 1 Adam Williamson 2014-01-28 16:37:52 UTC
Damn, option 2) should of course read "Just restore the Custom partitioning" button to the dialog.

Comment 2 Adam Williamson 2014-01-28 16:43:10 UTC
For reference, the original post about the re-design is http://www.redhat.com/archives/anaconda-devel-list/2013-October/msg00064.html , and we're in case "RECLAIM DISK SPACE POP-UP" here. The mockup seems to be inaccessible ATM.

Comment 3 Adam Williamson 2014-01-28 17:05:21 UTC
*sigh* "you choose custom or manual partitioning on the disk selection screen" should read:

"you choose automatic or manual partitioning on the disk selection screen"

Comment 4 Adam Williamson 2014-03-04 18:05:05 UTC
This is still valid, as I noticed in doing some screenshots today. The text is completely inaccurate vis a vis the actual available options on the screen. It needs to be resolved one way or the other.

Comment 5 Jaroslav Reznik 2015-03-03 15:25:49 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 22 development cycle.
Changing version to '22'.

More information and reason for this action is here:
https://fedoraproject.org/wiki/Fedora_Program_Management/HouseKeeping/Fedora22

Comment 6 Fedora End Of Life 2016-07-19 19:28:46 UTC
Fedora 22 changed to end-of-life (EOL) status on 2016-07-19. Fedora 22 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.

Comment 7 Adam Williamson 2016-08-19 22:06:39 UTC
This is *still* valid.

Comment 8 Jonathan Wakely 2016-08-24 09:42:16 UTC
(In reply to Adam Williamson from comment #0)
> "You don't have enough space available to install Fedora. You can shrink or
> remove existing partitions via our guided reclaim space tool, or you can
> adjust your partitions on your own in the custom partitioning interface."
> 
> but the button that leads to Custom Partitioning was dropped from the dialog
> as part of the workflow change. The only buttons are "Cancel & add more
> disks" and "Reclaim space". Mo did not actually envisage this in her mockups.
> 
> As discussed in #anaconda today, there are two ways this could possibly be
> addressed:
> 
> 1. Tweak the "guide text" and the "Cancel" button label to make it clear to
> the user that they can cancel out of the dialog to add more disks *or* to
> switch to custom partitioning.

Should option 1 be chosen, changing the label to "Cancel and adjust partitions" seems like a reasonable fix. The guide text effectively says "you can reclaim space, or adjust partitions" and the button labels are "reclaim space" and ... something completely different. "Cancel and adjust partitions" would clearly tie it to the second "adjust your partitions on your own in the custom partitioning interface" clause.

Comment 9 Máirín Duffy 2016-08-25 13:37:44 UTC
I'm still in favor of option 2 but can live with option 1.

Comment 10 Fedora End Of Life 2017-02-28 09:36:25 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 26 development cycle.
Changing version to '26'.

Comment 11 Fedora End Of Life 2018-05-03 08:13:22 UTC
This message is a reminder that Fedora 26 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 26. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '26'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 26 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged  change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.

Comment 12 Fedora End Of Life 2018-05-29 11:55:45 UTC
Fedora 26 changed to end-of-life (EOL) status on 2018-05-29. Fedora 26
is no longer maintained, which means that it will not receive any
further security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.