Bug 1059511

Summary: [GSS] (6.4.x) keepAliveTimeout (org.apache.coyote.http11.DEFAULT_KEEP_ALIVE_TIMEOUT) setting does not take effect
Product: [JBoss] JBoss Enterprise Application Platform 6 Reporter: Masafumi Miura <mmiura>
Component: WebAssignee: Rémy Maucherat <rmaucher>
Status: CLOSED CURRENTRELEASE QA Contact: Michael Cada <mcada>
Severity: urgent Docs Contact:
Priority: unspecified    
Version: 6.2.0CC: jlee, pjelinek, pslavice
Target Milestone: DR5   
Target Release: EAP 6.4.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1138672, 1149776    
Bug Blocks:    
Attachments:
Description Flags
jbossweb-keepalivetimeout.patch mmiura: review?

Description Masafumi Miura 2014-01-30 03:21:15 UTC
### Description of problem:

keepAliveTimeout can be configurable by setting system property org.apache.coyote.http11.DEFAULT_KEEP_ALIVE_TIMEOUT in EAP 6.1.x (JBossWeb 7.2.x). But it does not take effect. 

The setting become effective only if disableUploadTimeout is set to "false". But disableUploadTimeout is not configurable in EAP 6.x and it's "true" by default.

Same issue was reported in the community BZ https://issues.apache.org/bugzilla/show_bug.cgi?id=46666

Please backport http://svn.apache.org/viewvc?view=revision&revision=750909


### Version-Release number of selected component (if applicable):

JBossWeb 7.2.x onwards.

Comment 1 Masafumi Miura 2014-01-30 03:22:51 UTC
Created attachment 857325 [details]
jbossweb-keepalivetimeout.patch

Comment 2 Martin Velas 2014-07-29 11:56:02 UTC
Issue is still valid for the EAP 6.3.0.ER10. Source codes for the JBossWEB 7.4.8 don't contain patch from Comment 11 nor the possibility of setting disableUploadTimeout was added.

Comment 3 Rémy Maucherat 2014-08-26 14:06:53 UTC
Added in web using a new system property (...DEFAULT_DISABLE_UPLOAD_TIMEOUT) in r2495.

Comment 4 Kabir Khan 2014-09-08 11:54:52 UTC
Fixed by component upgrade to JBoss Web 7.5.0.Beta1: https://bugzilla.redhat.com/show_bug.cgi?id=1138672

Comment 6 Rémy Maucherat 2014-09-16 20:27:56 UTC
I don't think this is very useful, so the other flag is used to disable it. The functionality is there if needed.

Comment 7 Pavel Jelinek 2014-10-01 11:16:51 UTC
Regardless of what is the initial value of org.apache.coyote.http11.Http11Processor.disableUploadTimeout what is now really configurable the value is always overwritten by org.apache.coyote.http11.Http11Protocol.Http11ConnectionHandler.createProcessor() calling processor.setDisableUploadTimeout(proto.disableUploadTimeout);
So this fix has no effect on this issue.

Comment 8 Rémy Maucherat 2014-10-01 12:06:16 UTC
Yes, I didn't put it in the right place, sorry. r2512 is the new fix in web.

Comment 9 Kabir Khan 2014-10-08 12:16:28 UTC
Should be fixed by component upgrade to 7.5.0.Beta3 1149776

Comment 10 Pavel Jelinek 2014-10-21 10:04:12 UTC
Verified for EAP 6.4.0.DR5 that -Dorg.apache.coyote.http11.DEFAULT_KEEP_ALIVE_TIMEOUT arg takes affect if -Dorg.apache.coyote.http11.DEFAULT_DISABLE_UPLOAD_TIMEOUT=true is used as well.

Comment 11 Pavel Jelinek 2014-10-21 10:17:38 UTC
Affects https://access.redhat.com/solutions/110003