Bug 1059938

Summary: update_pot ignores translatable strings in <td> elements.
Product: [Community] Publican Reporter: Yuko Katabami <ykatabam>
Component: publicanAssignee: Jeff Fearn 🐞 <jfearn>
Status: CLOSED CURRENTRELEASE QA Contact: Ruediger Landmann <rlandman>
Severity: urgent Docs Contact:
Priority: urgent    
Version: 4.0CC: aigao, hyu, rlandman
Target Milestone: 4.1   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 4.1.0 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-05-05 06:03:15 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
sample xml file
none
sample pot file none

Description Yuko Katabami 2014-01-31 01:30:24 UTC
Created attachment 857677 [details]
sample xml file

Description of problem:
publican update_pot command generates a pot file which does not contain full contents.

Version-Release number of selected component (if applicable): 4.0


How reproducible: I am not sure. This is the first case I encountered.


Steps to Reproduce:
1. Go to a book directory
2. Run "publican update_pot" command
3. Compare the original xml file with the newly generated pot file

Actual results:
The pot file does not include the full contents

Expected results:
It should include all the contents.

Additional info:
sample files attached.

Comment 1 Yuko Katabami 2014-01-31 01:31:06 UTC
Created attachment 857678 [details]
sample pot file

Comment 2 Ruediger Landmann 2014-01-31 04:01:06 UTC
Also, building a translated book ignores msgstrs for the contents of tables, even when available.

Comment 4 Jason McDonald 2014-02-06 03:01:53 UTC
Is this a regression from a previous version of Publican?

Comment 5 Ruediger Landmann 2014-02-06 03:26:48 UTC
No, it's a new flaw.

Curiously, it doesn't affect <informaltable>s

Comment 6 Hao Chang Yu 2014-02-06 08:13:16 UTC
That is because publican is currently ignoring the "<td>" tag in the table. 

An easy workaround of this issue is to substitue the "<td>" html tag to "<entry>" tag.

E.g.

<td>Configuration option=Default value</td>

to

<entry>Configuration option=Default value</entry>

Another solution is to a "<para>" tag inside the "<td>" tag.

Such as,
<td><para>Configuration option=Default value</para></td>


The "<informaltable>"s is not affected because it uses "<para>"s in it.


Thanks.

Regards
Hao

Comment 7 Jeff Fearn 🐞 2014-02-23 23:12:38 UTC
To be more specific, publican does not have any knowledge of the HTML tags included in DocBook. This will have other effects besides not working in translations.

Comment 8 Jeff Fearn 🐞 2014-02-28 01:55:45 UTC
Added TD to translatable block list.

To ssh://git.fedorahosted.org/git/publican.git
   4335d0c..cea60f9  devel -> devel

Comment 9 Jeff Fearn 🐞 2014-05-05 06:03:15 UTC
A fix for this shipped in Publican 4.1.0.