Bug 1059976 (GlusterThinProvisioning)
Summary: | glusterfs backend does not support discard | ||
---|---|---|---|
Product: | [Red Hat Storage] Red Hat Gluster Storage | Reporter: | Nagaprasad Sathyanarayana <nsathyan> |
Component: | glusterfs | Assignee: | Bug Updates Notification Mailing List <rhs-bugs> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | storage-qa-internal <storage-qa-internal> |
Severity: | urgent | Docs Contact: | |
Priority: | urgent | ||
Version: | rhgs-3.0 | CC: | amukherj, areis, dyuan, hhuang, jcody, juzhang, kaushal, knoel, mazhang, michen, nlevinki, nsathyan, pasteur, pbonzini, rbalakri, rcyriac, shyu, smohan, ssaha, vbellur, virt-maint, xuzhang, yanyang |
Target Milestone: | --- | Keywords: | FutureFeature |
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Enhancement | |
Doc Text: | Story Points: | --- | |
Clone Of: | 1055487 | Environment: | |
Last Closed: | 2016-01-05 07:00:07 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 1037503, 1055487, 1103845, 1136534 | ||
Bug Blocks: | 1093069 |
Comment 1
Nagaprasad Sathyanarayana
2014-01-31 06:26:29 UTC
> I strongly suggest we do not wait till 7.1.
I would be very surprised if it were possible to do this in 7.0.
The discard and zerofill APIs are not provided by libgfapi, are they even supported in the backend?
zerofill is new in 3.5. What's progress for this bug? It maybe will block our KVM QE testing for ThinProvisioning with GlusterFS backends in qemu-kvm-rhev7.1, could you help to resolve this bug soon, thanks. Best Regards, sluo This should be fixed by the 3.6 rebase. /usr/include/glusterfs/api/glfs.h includes the relevant functions: int glfs_discard(glfs_fd_t *fd, off_t offset, size_t len) __THROW; int glfs_discard_async (glfs_fd_t *fd, off_t length, size_t lent, glfs_io_cbk fn, void *data) __THROW; int glfs_zerofill(glfs_fd_t *fd, off_t offset, off_t len) __THROW; int glfs_zerofill_async (glfs_fd_t *fd, off_t length, off_t len, glfs_io_cbk fn, void *data) __THROW; I'd rather have the RHS folks answer the question definitively, though. (In reply to Paolo Bonzini from comment #8) > This should be fixed by the 3.6 rebase. /usr/include/glusterfs/api/glfs.h > includes the relevant functions: > > int glfs_discard(glfs_fd_t *fd, off_t offset, size_t len) __THROW; > > > int glfs_discard_async (glfs_fd_t *fd, off_t length, size_t lent, > glfs_io_cbk fn, void *data) __THROW; > > int glfs_zerofill(glfs_fd_t *fd, off_t offset, off_t len) __THROW; > > int glfs_zerofill_async (glfs_fd_t *fd, off_t length, off_t len, > glfs_io_cbk fn, void *data) __THROW; > > I'd rather have the RHS folks answer the question definitively, though. This is correct. The 3.6 rebase introduces these APIs in RHEL. This bug can be closed. As Vijay mentioned in Comment#9, the required API was made available by the rebase to glusterfs-3.6. The APIs should be available in RHS-3.0 and RHGS-3.1 releases. Based on #c11 closing this bug |