Bug 1060316

Summary: RFE: Use virConnectGetCPUModelNames
Product: [Community] Virtualization Tools Reporter: Cole Robinson <crobinso>
Component: virt-managerAssignee: Giuseppe Scrivano <gscrivan>
Status: CLOSED UPSTREAM QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: unspecifiedCC: acathrow, berrange, crobinso, gscrivan
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-03-13 18:05:30 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Cole Robinson 2014-01-31 18:54:46 UTC
virt-manager depends on parsing the local cpu_map.xml file that libvirt ships to get a list of CPU model names. This file is meant to be private to libvirt so we shouldn't be doing that.

There's an API now called virConnectGetCPUModelNames which we should be using to get this info, on new enough libvirt.

Comment 1 Giuseppe Scrivano 2014-03-13 18:05:30 UTC
closed by commit:

commit 81696a514441f2320ea10299e1852795f8cb1682
Author: Giuseppe Scrivano <gscrivan>
Date:   Thu Mar 13 12:52:51 2014 +0100

    virtinst: use libvirt getCPUModelNames when available
    
    Read the list of CPU models trough getCPUModelNames instead of
    accessing directly the file cpu_map.xml.
    
    Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1060316
    
    Signed-off-by: Giuseppe Scrivano <gscrivan>