Bug 1060459

Summary: Crash running os-prober during F20 install with LUKS partition on disk
Product: [Fedora] Fedora Reporter: Jonathan Pallant <redhat>
Component: os-proberAssignee: Hedayat Vatankhah <hedayatv>
Status: CLOSED DUPLICATE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 20CC: bcl, dennis, hedayatv, lkundrak, mads, pjones
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-04-24 07:46:22 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Section from /var/log/messages none

Description Jonathan Pallant 2014-02-01 22:32:55 UTC 
Description of problem:

Can't install Fedora 20 from Fedora XFCE Live image (on USB) when laptop has LUKS partition. Install hangs installing bootloader (running os-prober more specifically).

Version-Release number of selected component (if applicable):

20

How reproducible:

Always.

Steps to Reproduce:
1. Boot F20 XFCE Live image from USB
2. Run Installer
3. Click through to install phase.

Actual results:

Hangs for at least 30 minutes during "Installing bootloader" phase (I got bored waiting). ps auxf shows that it's running os-prober and the logs in /tmp suggested it thought my unmounted LUKS partition (type 82) was infact a Mac OS partition. I recall it was stuck with subprocesses "logger", "tr     ^" and something else. Unfortunately I didn't save the logs.

It didn't matter whether I had previously unlocked the LUKS partition or ignored it entirely (i.e. didn't ask the installer to mount it anywhere).

Expected results:

Bootloader to install.

Additional info:

I worked around the issue by backing up the first 512KiB of my partition to a file and zero'ing it, using dd. Just to be sure, I also changed the partition type to "Non FS data". The next installation then proceeded correctly and I restored the partition type and sectors after install and added the partition to /etc/crypttab successfully.

The computer is a Toshiba L500-1XC laptop with a single 320GB SATA disk.

The partition layout is:

[root@localhost ~]# fdisk -l /dev/sda

Disk /dev/sda: 298.1 GiB, 320072933376 bytes, 625142448 sectors
Units: sectors of 1 * 512 = 512 bytes
Sector size (logical/physical): 512 bytes / 512 bytes
I/O size (minimum/optimal): 512 bytes / 512 bytes
Disklabel type: dos
Disk identifier: 0x1646ffcc

Device    Boot     Start       End    Blocks  Id System
/dev/sda1 *         2048    821247    409600  27 Hidden NTFS WinRE
/dev/sda2         821248 210536447 104857600   7 HPFS/NTFS/exFAT
/dev/sda3      210536448 313391103  51427328  83 Linux
/dev/sda4      313391104 625141759 155875328   5 Extended
/dev/sda5      313393152 321781759   4194304  82 Linux swap / Solaris
/dev/sda6      321783808 573442047 125829120   7 HPFS/NTFS/exFAT
/dev/sda7      573444096 625141759  25848832  83 Linux

sda3 is the LUKS partition. sda1/sda2 are Windows 7, sda7 is /, sda6 is just data.
Comment 1 Jonathan Pallant 2014-02-01 22:59:24 UTC 
I've rebooted back in to the Live USB environment and ran (without mounting or unlocking the LUKS partition):

[liveuser@localhost ~]$ sudo os-prober 
/dev/sda1:Windows 7 (loader):Windows:chain
umount: /var/lib/os-prober/mount: target is busy
        (In some cases useful info about processes that
         use the device is found by lsof(8) or fuser(1).)
rmdir: failed to remove ‘/var/lib/os-prober/mount’: Device or resource busy
/dev/sda7:Fedora release 20 (Heisenbug):Fedora:linux
rmdir: failed to remove ‘/var/lib/os-prober/mount’: Device or resource busy
rmdir: failed to remove ‘/var/lib/os-prober/mount’: Device or resource busy
rmdir: failed to remove ‘/var/lib/os-prober/mount’: Device or resource busy

It then hangs at that point.

The portion of /var/log/messages is attached.
Comment 2 Jonathan Pallant 2014-02-01 22:59:59 UTC 
Created attachment 858142 [details]
Section from /var/log/messages
Comment 3 Hedayat Vatankhah 2014-02-24 09:10:42 UTC 
Would you please try "umount /var/lib/os-prober/mount" manually (after running os-prober) and see if it works? If not, please lsof to see why it is busy.
Comment 4 Jonathan Pallant 2014-04-23 22:03:52 UTC 
I have to ctrl-c to get out of os-prober but after that I can sudo umount that path without issue.
Comment 5 Hedayat Vatankhah 2014-04-24 07:46:22 UTC 
It seems a duplicate of another bug which I should fix ASAP.

*** This bug has been marked as a duplicate of bug 903906 ***