Bug 1060465
| Summary: | Review Request: perl-Excel-Writer-XLSX - Create a new file in the Excel 2007+ XLSX format | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | David Dick <ddick> |
| Component: | Package Review | Assignee: | Petr Šabata <psabata> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | package-review, perl-devel, psabata |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | Flags: | psabata:
fedora-review+
gwync: fedora-cvs+ |
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| Fixed In Version: | perl-Excel-Writer-XLSX-0.76-1.el6 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-02-24 12:29:55 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
David Dick
2014-02-02 00:11:29 UTC
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=6483490 I'm taking the review and will sponsor you once the package is in a reasonable state. Items marked as TODO are optional but recommended fixes; FIX are review blockers. TODO: Drop the BuildRoot tag unless you plan to push this into EPEL5 too. This is no longer needed. TODO: The same applies to line 31 (rm -rf $RPM_BUILD_ROOT) and the whole %clean section. TODO: Remove %defattr, this is no longer required, not even in EPEL. TODO: I think the same applies to removing empty directories on line 36. TODO: Utilize DESTDIR instead of PERL_INSTALL_ROOT, line 33. TODO: Package the `examples' directory in %doc. TODO: Remove META.json from %doc; this file is of no use to the end users. Dependencies: You'll need to BuildRequire all the use'd and require'd modules to prevent possible future build failures caused by buildroot changes. FIX: BR perl TODO: BR perl(autouse) FIX: BR perl(Carp) TODO: BR perl(Date::Calc) -- this is an optional test dependency TODO: BR perl(Date::Manip) -- ditto FIX: BR perl(Encode) FIX: BR perl(Exporter) TODO: BR perl(File::Basename) FIX: BR perl(File::Copy) FIX: BR perl(File::Find) TODO: BR perl(integer) TODO: BR perl(IO::File) FIX: BR perl(lib) FIX: BR perl(List::Util) TODO: BR perl(strict) FIX: BR perl(Test::More) TODO: BR perl(utf8) TODO: BR perl(warnings) FIX: Drop the perl(Test::Simple) BR, it's not used anywhere. TODO: You (run-) require specific versions of Archive::Zip and File::Temp. You should filter out the unversioned automatically detected requires from the resulting RPM. This page will tell you how to achieve that: https://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering FIX: Your changelog entry is malformed. Use one of the formats mentioned in the guidelines: https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Changelogs The Spec and SRPM files have been updated and built on koji at https://koji.fedoraproject.org/koji/taskinfo?taskID=6503548 New koji build provided at https://koji.fedoraproject.org/koji/taskinfo?taskID=6511892 Ok, this looks much better now, just a few more things.
1. You forgot to remove the %clean section.
2. You didn't filter out the underspecified dependencies. You can achieve that with:
%global __requires_exclude %{?__requires_exclude:__requires_exclude|}^perl\\(Archive::Zip\\)$
%global __requires_exclude %__requires_exclude|^perl\\(File::Temp\\)$
Although those two were just TODO points, given this is your first package, it should be perfect :)
3. What's your FAS username?
(In reply to Petr Šabata from comment #6) > 3. What's your FAS username? ddick, mentioned already. New koji build provided at https://koji.fedoraproject.org/koji/taskinfo?taskID=6515863 Alright, sponsored and approving. New Package SCM Request ======================= Package Name: perl-Excel-Writer-XLSX Short Description: Create a new file in the Excel 2007+ XLSX format Owners: ddick Branches: f19 f20 el5 el6 InitialCC: Git done (by process-git-requests). perl-Excel-Writer-XLSX-0.76-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/perl-Excel-Writer-XLSX-0.76-1.fc20 perl-Excel-Writer-XLSX-0.76-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/perl-Excel-Writer-XLSX-0.76-1.el6 New Package SCM Request ======================= Package Name: perl-Excel-Writer-XLSX Short Description: Create a new file in the Excel 2007+ XLSX format Owners: ddick Branches: epel7 InitialCC: perl-sig Already exists, please use a Package Change Request to request a new branch. Package Change Request ====================== Package Name: perl-Excel-Writer-XLSX New Branches: epel7 Owners: ddick InitialCC: perl-sig Git done (by process-git-requests). perl-Excel-Writer-XLSX-0.76-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/perl-Excel-Writer-XLSX-0.76-1.fc19 perl-Excel-Writer-XLSX-0.76-1.fc19 has been pushed to the Fedora 19 testing repository. perl-Excel-Writer-XLSX-0.76-1.fc19 has been pushed to the Fedora 19 stable repository. perl-Excel-Writer-XLSX-0.76-1.fc20 has been pushed to the Fedora 20 stable repository. perl-Excel-Writer-XLSX-0.76-1.el6 has been pushed to the Fedora EPEL 6 stable repository. |