Bug 1060797

Summary: dist-geo-rep: When use-tarssh is set to "true" when it is already using tar+ssh, gsyncd still restarts
Product: [Community] GlusterFS Reporter: Kotresh HR <khiremat>
Component: geo-replicationAssignee: Kotresh HR <khiremat>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: medium Docs Contact:
Priority: high    
Version: mainlineCC: aavati, bugs, csaba, gluster-bugs, nsathyan, psriniva, vbhat
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: glusterfs-3.6.0beta1 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 1030052 Environment:
Last Closed: 2014-11-11 08:27:36 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1030052    
Bug Blocks:    

Comment 1 Anand Avati 2014-02-03 16:18:18 UTC
REVIEW: http://review.gluster.org/6897 (geo-rep: Fix gsyncd restart issue.) posted (#1) for review on master by Kotresh HR (khiremat)

Comment 2 Anand Avati 2014-02-03 16:29:36 UTC
REVIEW: http://review.gluster.org/6897 (glusterd/geo-rep: Fix gsyncd restart issue.) posted (#2) for review on master by Kotresh HR (khiremat)

Comment 3 Anand Avati 2014-02-05 10:04:10 UTC
REVIEW: http://review.gluster.org/6897 (geo-rep: Fix gsyncd restart issue.) posted (#3) for review on master by Kotresh HR (khiremat)

Comment 4 Anand Avati 2014-02-05 11:22:44 UTC
REVIEW: http://review.gluster.org/6897 (geo-rep: Fix gsyncd restart issue.) posted (#4) for review on master by Kotresh HR (khiremat)

Comment 5 Anand Avati 2014-02-05 11:33:08 UTC
REVIEW: http://review.gluster.org/6897 (geo-rep: Fix gsyncd restart issue.) posted (#5) for review on master by Kotresh HR (khiremat)

Comment 6 Anand Avati 2014-02-11 08:46:10 UTC
REVIEW: http://review.gluster.org/6897 (geo-rep: Fix gsyncd restart issue.) posted (#6) for review on master by Kotresh HR (khiremat)

Comment 7 Anand Avati 2014-02-13 01:38:24 UTC
COMMIT: http://review.gluster.org/6897 committed in master by Anand Avati (avati) 
------
commit 547ee245dac4f2689a0f3f8f66635e0195489602
Author: Kotresh H R <khiremat>
Date:   Wed Dec 4 14:14:20 2013 +0000

    geo-rep: Fix gsyncd restart issue.
    
    New function 'glusterd_gsync_op_already_set' is written which compares
    the geo-rep configuration value in gsync.conf with the one sent from
    cli. The generic function is written to compare op_value for any
    op_name sent from cli as this issue can happen with any configuration
    setting other than use-tarssh also. This routine is used to avoid
    restart of gsyncd if the configuration value is set to same as in
    gsyncd.conf.
    
    Also added error checking when glusterd_gsync_configure fails.
    Earlier, eventhough 'glusterd_gsync_configure' fails, error
    was not getting catched and success message was shown.
    
    Change-Id: If4dcd0ffc09e6e67c79ba86238f03eff1b7c7645
    BUG: 1060797
    Signed-off-by: Kotresh H R <khiremat>
    Reviewed-on: http://review.gluster.org/6897
    Reviewed-by: Avra Sengupta <asengupt>
    Reviewed-by: Venky Shankar <vshankar>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Anand Avati <avati>

Comment 8 Niels de Vos 2014-09-22 12:35:41 UTC
A beta release for GlusterFS 3.6.0 has been released. Please verify if the release solves this bug report for you. In case the glusterfs-3.6.0beta1 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED.

Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-September/018836.html
[2] http://supercolony.gluster.org/pipermail/gluster-users/

Comment 9 Niels de Vos 2014-11-11 08:27:36 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.1, please reopen this bug report.

glusterfs-3.6.1 has been announced [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019410.html
[2] http://supercolony.gluster.org/mailman/listinfo/gluster-users